[NFC][VPlan] Use VPUser to store block's predicate
ClosedPublic
Actions

Authored by a.elovikov on Feb 11 2021, 11:01 AM.

Details

Reviewers

fhahn
Ayal
gilr

Commits

rG3605b873f6f0: [NFC][VPlan] Use VPUser to store block's predicate

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

a.elovikov created this revision.Feb 11 2021, 11:01 AM

Herald added subscribers: tschuett, psnobl, rogfer01 and 2 others. · View Herald TranscriptFeb 11 2021, 11:01 AM

a.elovikov requested review of this revision.Feb 11 2021, 11:01 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2021, 11:01 AM

Herald added subscribers: llvm-commits, vkmr. · View Herald Transcript

Harbormaster completed remote builds in B88857: Diff 323080.Feb 11 2021, 5:04 PM

Thanks for taking a stab at this after D95382!

llvm/lib/Transforms/Vectorize/VPlan.h
428–429	The functions here are essentially the same as for CondBit, right? Could you factor out the logic into private helpers, that take a reference to `VPUser`?

Move common implementation of get/set methods into helpers

a.elovikov marked an inline comment as done.Feb 16 2021, 9:10 AM

Harbormaster completed remote builds in B89398: Diff 324029.Feb 16 2021, 10:03 AM

LGTM, thanks!

This revision is now accepted and ready to land.Feb 18 2021, 9:20 AM

This revision was landed with ongoing or failed builds.Feb 23 2021, 11:09 AM

Closed by commit rG3605b873f6f0: [NFC][VPlan] Use VPUser to store block's predicate (authored by a.elovikov). · Explain Why

This revision was automatically updated to reflect the committed changes.

a.elovikov added a commit: rG3605b873f6f0: [NFC][VPlan] Use VPUser to store block's predicate.

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Transforms/

Vectorize/

VPlan.h

47 lines

VPlan.cpp

52 lines

Diff 325841

View Options

llvm/lib/Transforms/Vectorize/VPlan.h