Page MenuHomePhabricator

a.elovikov (Andrei Elovikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2017, 8:36 AM (210 w, 5 d)

Recent Activity

Mon, Apr 19

a.elovikov added a comment to D100175: [VPlan] Add GraphTraits impl to traverse through VPRegionBlock..

I think it's functionally correct now, just have a few suggestions to simplify the code a little bit.

Mon, Apr 19, 1:50 PM · Restricted Project

Mon, Apr 12

a.elovikov accepted D100259: [VPlan] Add VPRecipeBase::mayHaveSideEffects..

LGTM, please wait a day or two to let others take a look.

Mon, Apr 12, 11:42 AM · Restricted Project
a.elovikov added inline comments to D100257: [VPlan] Add VPUserID to distinguish between recipes and others..
Mon, Apr 12, 11:40 AM · Restricted Project
a.elovikov added inline comments to D100176: [VPlan] Use recursive traversal iterator in VPSlotTracker..
Mon, Apr 12, 11:33 AM · Restricted Project
a.elovikov added inline comments to D100175: [VPlan] Add GraphTraits impl to traverse through VPRegionBlock..
Mon, Apr 12, 11:30 AM · Restricted Project
a.elovikov added inline comments to D100175: [VPlan] Add GraphTraits impl to traverse through VPRegionBlock..
Mon, Apr 12, 11:26 AM · Restricted Project

Mar 19 2021

a.elovikov committed rG92205cb27fd8: [NFC][VPlan] Guard print routines with "#if !defined(NDEBUG) || defined… (authored by a.elovikov).
[NFC][VPlan] Guard print routines with "#if !defined(NDEBUG) || defined…
Mar 19 2021, 10:51 AM
a.elovikov committed rG93a9d2de8f4f: [VPlan] Add plain text (not DOT's digraph) dumps (authored by a.elovikov).
[VPlan] Add plain text (not DOT's digraph) dumps
Mar 19 2021, 10:51 AM
a.elovikov closed D98897: [NFC][VPlan] Guard print routines with "#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)".
Mar 19 2021, 10:51 AM · Restricted Project
a.elovikov closed D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 19 2021, 10:51 AM · Restricted Project

Mar 18 2021

a.elovikov updated the diff for D98897: [NFC][VPlan] Guard print routines with "#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)".
Mar 18 2021, 3:21 PM · Restricted Project
a.elovikov requested review of D98897: [NFC][VPlan] Guard print routines with "#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)".
Mar 18 2021, 2:11 PM · Restricted Project
a.elovikov updated the diff for D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 18 2021, 1:30 PM · Restricted Project
a.elovikov reopened D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 18 2021, 1:30 PM · Restricted Project
a.elovikov added a comment to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

It seems the code wasn't properly guarded before this change, and the proper fix would require changing too many places. I'd prefer to do it in separate patch.

Mar 18 2021, 12:55 PM · Restricted Project
a.elovikov added a comment to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Sorry for the troubles and thanks for reverting that for me - I didn't receive notifications from buildbots for it. Yes, it's probably related to those #ifs. I'm starting a Release build to reproduce and create a fix.

Mar 18 2021, 12:27 PM · Restricted Project
a.elovikov committed rG6b053c9867a3: [VPlan] Add plain text (not DOT's digraph) dumps (authored by a.elovikov).
[VPlan] Add plain text (not DOT's digraph) dumps
Mar 18 2021, 11:46 AM
a.elovikov closed D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 18 2021, 11:46 AM · Restricted Project

Mar 14 2021

a.elovikov added inline comments to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 14 2021, 7:29 PM · Restricted Project

Mar 12 2021

a.elovikov added inline comments to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 12 2021, 11:53 AM · Restricted Project
a.elovikov updated the diff for D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Address review comments.

Mar 12 2021, 11:53 AM · Restricted Project

Mar 11 2021

a.elovikov added inline comments to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 11 2021, 12:36 PM · Restricted Project
a.elovikov updated the diff for D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
  • Improve comments.
  • Don't add a new dump point via cl::opt. Instead, add cl::opt to toggle behavior (dot/plain dumps) for the LVP::printPlans method.
Mar 11 2021, 12:36 PM · Restricted Project

Mar 9 2021

a.elovikov added inline comments to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 9 2021, 2:02 PM · Restricted Project

Mar 8 2021

a.elovikov added a comment to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Ping.

Mar 8 2021, 9:47 AM · Restricted Project

Mar 4 2021

a.elovikov added inline comments to D97278: [VPlan] Support to widen call intructions in VPlan native path.
Mar 4 2021, 9:55 AM · Restricted Project
a.elovikov added inline comments to D89322: [LV] Initial VPlan cost modelling.
Mar 4 2021, 9:24 AM · Restricted Project

Mar 3 2021

a.elovikov added a comment to D97712: [VPlan] Clone original VPlan and specialize for each VF (WIP)..

I didn't recognize that it's still WIP until some point, so some nitpicking comments aren't very useful probably...

Mar 3 2021, 2:08 PM · Restricted Project
a.elovikov added inline comments to D97711: [VPlan] Introduce VPWidenIntOrFpInductionRecipes to original plan..
Mar 3 2021, 1:47 PM · Restricted Project
a.elovikov added inline comments to D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.
Mar 3 2021, 1:31 PM · Restricted Project
a.elovikov added inline comments to D97136: [VPlan] Support to widen select intructions in VPlan native path.
Mar 3 2021, 1:24 PM · Restricted Project
a.elovikov added inline comments to D97278: [VPlan] Support to widen call intructions in VPlan native path.
Mar 3 2021, 11:28 AM · Restricted Project

Mar 2 2021

a.elovikov committed rGb24afec8ae58: [NFCI][VPlan] Modify Recipes' print methods to honor Indent parameter (authored by a.elovikov).
[NFCI][VPlan] Modify Recipes' print methods to honor Indent parameter
Mar 2 2021, 3:35 PM
a.elovikov closed D97787: [NFCI][VPlan] Modify Recipes' print methods to honor Indent parameter.
Mar 2 2021, 3:35 PM · Restricted Project
a.elovikov updated the diff for D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Rebased on top of D97787.

Mar 2 2021, 10:56 AM · Restricted Project
a.elovikov requested review of D97787: [NFCI][VPlan] Modify Recipes' print methods to honor Indent parameter.
Mar 2 2021, 10:51 AM · Restricted Project

Feb 25 2021

a.elovikov added a comment to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Ping

Feb 25 2021, 8:55 AM · Restricted Project

Feb 23 2021

a.elovikov committed rG3605b873f6f0: [NFC][VPlan] Use VPUser to store block's predicate (authored by a.elovikov).
[NFC][VPlan] Use VPUser to store block's predicate
Feb 23 2021, 11:09 AM
a.elovikov closed D96529: [NFC][VPlan] Use VPUser to store block's predicate.
Feb 23 2021, 11:09 AM · Restricted Project

Feb 16 2021

a.elovikov updated the diff for D96529: [NFC][VPlan] Use VPUser to store block's predicate.

Move common implementation of get/set methods into helpers

Feb 16 2021, 9:10 AM · Restricted Project

Feb 12 2021

a.elovikov requested review of D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Feb 12 2021, 12:42 PM · Restricted Project

Feb 11 2021

a.elovikov requested review of D96529: [NFC][VPlan] Use VPUser to store block's predicate.
Feb 11 2021, 11:01 AM · Restricted Project

Feb 1 2021

a.elovikov added inline comments to D92285: [VPlan] Manage scalarized values using VPValues..
Feb 1 2021, 10:35 AM · Restricted Project

Jan 28 2021

a.elovikov added a comment to D91501: [VPlan] VPTransformState::get() can always return lane 0 for uniforms..

Not blocking this review, but I think it's bug-prone to mix lane 0 of scalarized divergent values and truly uniform values that can be kept on a single scalar. Possible examples:

Jan 28 2021, 1:18 PM · Restricted Project
a.elovikov added a comment to D95382: [VPlan] Use VPUser to manage CondBit.

Hi Florian, I'm starting to familiarize myself with VPlan and wonder if that is a short/mid-term solution or something that is expected to be a long-term.

Jan 28 2021, 10:28 AM · Restricted Project

Jun 8 2020

a.elovikov added inline comments to D72425: [OptRemark] RFC: Introduce a message table for OptRemarks.
Jun 8 2020, 5:12 PM · Restricted Project

Jan 21 2020

a.elovikov committed rGe1d6d3685293: [SLP] Don't allow Div/Rem as alternate opcodes (authored by a.elovikov).
[SLP] Don't allow Div/Rem as alternate opcodes
Jan 21 2020, 3:28 PM
a.elovikov closed D72740: [SLP] Don't allow Div/Rem as alternate opcodes.
Jan 21 2020, 3:27 PM · Restricted Project
a.elovikov committed rG757fe53994c1: [SLP] Add a test showing miscompilation in AltOpcode support (authored by a.elovikov).
[SLP] Add a test showing miscompilation in AltOpcode support
Jan 21 2020, 2:24 PM
a.elovikov closed D72739: [SLP] Add a test showing miscompilation in AltOpcode support.
Jan 21 2020, 2:23 PM · Restricted Project
a.elovikov added a comment to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.

Ping. I don't see any comments that require action on my side.

Jan 21 2020, 9:29 AM · Restricted Project

Jan 15 2020

a.elovikov added a comment to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.

This (and D72739) should be in 10.0 - please can you raise a bug and block https://bugs.llvm.org/show_bug.cgi?id=44555

Jan 15 2020, 9:06 AM · Restricted Project
a.elovikov updated the diff for D72739: [SLP] Add a test showing miscompilation in AltOpcode support.

Remove target datalayout string from the test

Jan 15 2020, 8:26 AM · Restricted Project

Jan 14 2020

a.elovikov updated the diff for D72739: [SLP] Add a test showing miscompilation in AltOpcode support.

Pass tripple/target-cpu via opt's --triple/--mcpu options

Jan 14 2020, 5:42 PM · Restricted Project
a.elovikov added inline comments to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.
Jan 14 2020, 4:23 PM · Restricted Project
a.elovikov added inline comments to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.
Jan 14 2020, 3:52 PM · Restricted Project
a.elovikov added inline comments to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.
Jan 14 2020, 3:44 PM · Restricted Project
a.elovikov created D72740: [SLP] Don't allow Div/Rem as alternate opcodes.
Jan 14 2020, 3:14 PM · Restricted Project
a.elovikov created D72739: [SLP] Add a test showing miscompilation in AltOpcode support.
Jan 14 2020, 3:14 PM · Restricted Project

Dec 9 2019

a.elovikov added a comment to D69563: [LV] Strip wrap flags from vectorized reductions.

Probably not too much important because should be handled by the vector predicated instructions/intrinsics, but still

Dec 9 2019, 3:03 PM · Restricted Project

Oct 10 2019

a.elovikov added inline comments to D68484: [PATCH 01/27] [noalias] LangRef: noalias intrinsics and ptr_provenance documentation..
Oct 10 2019, 1:46 PM · Restricted Project
a.elovikov added inline comments to D68498: [PATCH 15/38] [noalias] D9382: llvm.noalias - don't prevent loop vectorization.
Oct 10 2019, 11:04 AM · Restricted Project
a.elovikov added inline comments to D68492: [PATCH 09/38] [noalias] D9376: llvm.noalias - handling of dead intrinsics.
Oct 10 2019, 10:23 AM · Restricted Project
a.elovikov added inline comments to D68488: [PATCH 03/27] [noalias] [IR] Introduce ptr_provenance for LoadInst/StoreInst.
Oct 10 2019, 9:45 AM · Restricted Project

Oct 9 2019

a.elovikov added inline comments to D68484: [PATCH 01/27] [noalias] LangRef: noalias intrinsics and ptr_provenance documentation..
Oct 9 2019, 4:40 PM · Restricted Project

Aug 1 2019

a.elovikov added a comment to D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..

Thanks for working on this! I'm really interested in using this functionality so here are some comments on the main interface header.

Aug 1 2019, 10:19 AM · Restricted Project

Aug 30 2018

a.elovikov added inline comments to D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 30 2018, 1:16 AM · Restricted Project

Aug 28 2018

a.elovikov added inline comments to D50894: Pull google/benchmark library to the LLVM tree.
Aug 28 2018, 3:49 AM

Aug 27 2018

a.elovikov added inline comments to D50935: Add data structure to form equivalence classes of mangled names..
Aug 27 2018, 7:32 AM
a.elovikov added inline comments to D50935: Add data structure to form equivalence classes of mangled names..
Aug 27 2018, 6:15 AM

Aug 20 2018

a.elovikov committed rC340174: [NFC] Don't define static function in header (UninitializedObject.h).
[NFC] Don't define static function in header (UninitializedObject.h)
Aug 20 2018, 6:47 AM
a.elovikov committed rL340174: [NFC] Don't define static function in header (UninitializedObject.h).
[NFC] Don't define static function in header (UninitializedObject.h)
Aug 20 2018, 6:46 AM
a.elovikov closed D50963: [NFC] Don't define static function in header (UninitializedObject.h).
Aug 20 2018, 6:46 AM
a.elovikov created D50963: [NFC] Don't define static function in header (UninitializedObject.h).
Aug 20 2018, 3:30 AM

Aug 1 2018

a.elovikov committed rL338551: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang….
[NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang…
Aug 1 2018, 6:42 AM
a.elovikov committed rC338551: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang….
[NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang…
Aug 1 2018, 6:42 AM
a.elovikov closed D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp..
Aug 1 2018, 6:42 AM
a.elovikov updated the diff for D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp..
  • Address Erich's comment + clang-format.
Aug 1 2018, 2:42 AM

Jul 31 2018

a.elovikov created D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp..
Jul 31 2018, 5:46 AM

Jul 26 2018

a.elovikov added a comment to D47895: llvm: Add support for "-fno-delete-null-pointer-checks".

to change this logic if there is a consensus on how inlining should be handled in case of "null-pointer-isvalid" attribute mismatches.

Jul 26 2018, 12:30 AM

Jul 25 2018

a.elovikov added a comment to D47895: llvm: Add support for "-fno-delete-null-pointer-checks".

Note that, I am expecting that functions with alwaysinline attribute should still get inlined. If that happens and caller does not have this attribute, then optimizer is free to remove the checks.

Jul 25 2018, 7:48 AM

Jun 26 2018

a.elovikov committed rL335581: [NFC] Prefer (void) to LLVM_ATTRIBUTE_UNUSED for unused var in….
[NFC] Prefer (void) to LLVM_ATTRIBUTE_UNUSED for unused var in…
Jun 26 2018, 12:09 AM
a.elovikov closed D48534: [NFC] Prefer (void) to LLVM_ATTRIBUTE_UNUSED for unused var in GlobalISElemitter.cpp..
Jun 26 2018, 12:09 AM

Jun 25 2018

a.elovikov created D48534: [NFC] Prefer (void) to LLVM_ATTRIBUTE_UNUSED for unused var in GlobalISElemitter.cpp..
Jun 25 2018, 1:39 AM
a.elovikov added inline comments to rL335433: [DAGCombiner] eliminate setcc bool math when input is low-bit of some value.
Jun 25 2018, 1:36 AM

May 24 2018

a.elovikov committed rL333187: [NFC][VPlan] Wrap PlainCFGBuilder with an anonymous namespace..
[NFC][VPlan] Wrap PlainCFGBuilder with an anonymous namespace.
May 24 2018, 7:35 AM
a.elovikov closed D47312: [NFC][VPlan] Wrap PlainCFGBuilder with an anonymous namespace..
May 24 2018, 7:35 AM
a.elovikov created D47312: [NFC][VPlan] Wrap PlainCFGBuilder with an anonymous namespace..
May 24 2018, 2:10 AM

Apr 24 2018

a.elovikov committed rL330700: [CodeGen] Do not allow opt-bisect-limit to skip ScalarizeMaskedMemIntrin..
[CodeGen] Do not allow opt-bisect-limit to skip ScalarizeMaskedMemIntrin.
Apr 24 2018, 2:27 AM
a.elovikov closed D45947: [CodeGen] Do not allow opt-bisect-limit to skip ScalarizeMaskedMemIntrin..
Apr 24 2018, 2:27 AM

Apr 23 2018

a.elovikov created D45947: [CodeGen] Do not allow opt-bisect-limit to skip ScalarizeMaskedMemIntrin..
Apr 23 2018, 6:13 AM

Mar 21 2018

a.elovikov added a comment to D44737: [LV] Remove unnecessary -O2 from the X86/reg-usage.ll test. NFC..

The test passes without that "-O2" but I'm not sure why it was there originally...

Mar 21 2018, 7:30 AM
a.elovikov created D44737: [LV] Remove unnecessary -O2 from the X86/reg-usage.ll test. NFC..
Mar 21 2018, 7:30 AM

Mar 20 2018

a.elovikov committed rL327960: [LV] Let recordVectorLoopValueForInductionCast to check if IV was created from….
[LV] Let recordVectorLoopValueForInductionCast to check if IV was created from…
Mar 20 2018, 2:08 AM
a.elovikov closed D43812: [LV] Let recordVectorLoopValueForInductionCast to check if IV was created from the cast..
Mar 20 2018, 2:08 AM

Mar 16 2018

a.elovikov added inline comments to D44338: [LV][VPlan] Build plain CFG with simple VPInstructions for outer loops..
Mar 16 2018, 5:45 AM

Mar 15 2018

a.elovikov committed rL327617: [LoopUnroll] Ignore ephemeral values when checking full unroll profitability..
[LoopUnroll] Ignore ephemeral values when checking full unroll profitability.
Mar 15 2018, 3:03 AM
a.elovikov closed D43931: [LoopUnroll] Ignore ephemeral values when checking full unroll profitability..
Mar 15 2018, 3:03 AM
a.elovikov updated the diff for D43812: [LV] Let recordVectorLoopValueForInductionCast to check if IV was created from the cast..

Improve some comments.

Mar 15 2018, 2:26 AM

Mar 14 2018

a.elovikov added inline comments to D43812: [LV] Let recordVectorLoopValueForInductionCast to check if IV was created from the cast..
Mar 14 2018, 6:10 AM