This is an archive of the discontinued LLVM Phabricator instance.

[flang] Remove `LINK_WITH_FIR` cmake switch
ClosedPublic

Authored by SouraVX on Feb 10 2021, 5:16 AM.

Details

Summary

Most components required for this are already there.

Build and Testing clean.
ninja check-flang

Diff Detail

Event Timeline

SouraVX created this revision.Feb 10 2021, 5:16 AM
SouraVX requested review of this revision.Feb 10 2021, 5:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2021, 5:16 AM
clementval accepted this revision.Feb 10 2021, 7:35 AM
This revision is now accepted and ready to land.Feb 10 2021, 7:35 AM
tskeith added inline comments.
flang/CMakeLists.txt
216

Is this used?

217

I don't think this message is needed any more.

SouraVX updated this revision to Diff 322705.Feb 10 2021, 9:03 AM
SouraVX marked 2 inline comments as done.

Addressed @tskeith comments.

flang/CMakeLists.txt
216

Seems like not needed.

217

Removed thanks!

tskeith accepted this revision.Feb 10 2021, 9:13 AM
This revision was landed with ongoing or failed builds.Feb 11 2021, 9:22 AM
This revision was automatically updated to reflect the committed changes.