This is an archive of the discontinued LLVM Phabricator instance.

[flang] include snippet example to build FIR documentation
AcceptedPublic

Authored by lsandov1 on Jan 10 2023, 12:05 PM.

Details

Summary

The new snippet is similar to the one provided by the doxygen-based
documentation, however no cmake cmd provided (no special flag is
required on the cmake step).

Diff Detail

Event Timeline

lsandov1 created this revision.Jan 10 2023, 12:05 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
lsandov1 published this revision for review.Jan 10 2023, 12:05 PM
lsandov1 updated this revision to Diff 487953.Jan 10 2023, 12:44 PM

arc diffing with the correct commit ancestor

kiranchandramohan requested changes to this revision.Jan 12 2023, 1:59 AM

Thanks for this patch. Please see comment inline.

flang/README.md
333–334

The LINK_WITH_FIR cmake variable was removed (https://reviews.llvm.org/D96411) and is not used or required now. You can remove the requirement of LINK_WITH_FIR and its usage in the snippet.

This revision now requires changes to proceed.Jan 12 2023, 1:59 AM
lsandov1 updated this revision to Diff 489988.Jan 17 2023, 4:55 PM
lsandov1 edited the summary of this revision. (Show Details)

remove the camke '-DLINK_WITH_FIR=ON' reference on text and code snippet

The documentation is also available in https://flang.llvm.org/docs/FIRLangRef.html.

flang/README.md
338
This revision is now accepted and ready to land.Jan 19 2023, 5:49 AM

@kiranchandramohan I still have no power to merge, so please go ahead.