Page MenuHomePhabricator

[TTI] Change TargetTransformInfo::getMinimumVF to return ElementCount
ClosedPublic

Authored by sdesmalen on Feb 4 2021, 5:16 AM.

Details

Summary

This will be needed in the loop-vectorizer where the minimum VF
requested may be a scalable VF. getMinimumVF now takes an additional
operand 'IsScalableVF' that indicates whether a scalable VF is required.

Diff Detail

Event Timeline

sdesmalen created this revision.Feb 4 2021, 5:16 AM
sdesmalen requested review of this revision.Feb 4 2021, 5:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2021, 5:16 AM
sdesmalen updated this revision to Diff 322654.Feb 10 2021, 4:50 AM

Removed AArch64 specific changes.

c-rhodes added inline comments.Feb 10 2021, 5:12 AM
llvm/include/llvm/Analysis/TargetTransformInfo.h
949

nit: drop VF from operand? Personally I don't think it adds much

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
5815–5816

/*IsScalableVF=*/false?

kparzysz accepted this revision.Feb 10 2021, 5:57 AM

LGTM, but please respond to outstanding comments before committing.

This revision is now accepted and ready to land.Feb 10 2021, 5:57 AM
rampitec accepted this revision.Feb 10 2021, 9:57 AM

LGTM modulo previous comments.

This revision was automatically updated to reflect the committed changes.
sdesmalen marked an inline comment as done.

Thanks for review all! I've addressed @c-rhodes comments before committing.