This is an archive of the discontinued LLVM Phabricator instance.

[mlir][pdl][NFC] Rename InputOp to OperandOp

Authored by rriddle on Jan 29 2021, 7:54 PM.



This better matches the actual IR concept that is being modeled, and is consistent with how the rest of PDL is structured.

Depends On D95717

Diff Detail

Event Timeline

rriddle created this revision.Jan 29 2021, 7:54 PM
rriddle requested review of this revision.Jan 29 2021, 7:54 PM
jpienaar accepted this revision.Feb 28 2021, 2:21 PM
jpienaar added inline comments.

Lucky that no move was required to keep it alphatized :)


Is there a non-input operand tin PDL too?

This revision is now accepted and ready to land.Feb 28 2021, 2:21 PM
rriddle updated this revision to Diff 327948.Mar 3 2021, 3:34 PM
rriddle marked an inline comment as done.



input here should probably be external, as that is the property that input was poorly trying to convey.

This revision was landed with ongoing or failed builds.Mar 3 2021, 3:55 PM
This revision was automatically updated to reflect the committed changes.