Page MenuHomePhabricator
Differential D95718

[mlir][pdl][NFC] Rename InputOp to OperandOp
ClosedPublic
Actions

Authored by rriddle on Jan 29 2021, 7:54 PM.

Details

Reviewers
mehdi_amini
jpienaar
bollu
Commits
rGe07c968a6da0: [mlir][pdl][NFC] Rename InputOp to OperandOp
Summary

This better matches the actual IR concept that is being modeled, and is consistent with how the rest of PDL is structured.

Depends On D95717

Diff Detail

Event Timeline

rriddle created this revision.Jan 29 2021, 7:54 PM
Herald added a reviewer: bollu. · View Herald TranscriptJan 29 2021, 7:54 PM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald Transcript
rriddle requested review of this revision.Jan 29 2021, 7:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 29 2021, 7:54 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle added a child revision: D95719: [mlir][pdl] Restructure how results are represented..Jan 29 2021, 7:55 PM
Harbormaster completed remote builds in B87243: Diff 320265.Jan 29 2021, 8:34 PM
jpienaar accepted this revision.Feb 28 2021, 2:21 PM
jpienaar added inline comments.
mlir/include/mlir/Dialect/PDL/IR/PDLOps.td
172

Lucky that no move was required to keep it alphatized :)

176

Is there a non-input operand tin PDL too?

This revision is now accepted and ready to land.Feb 28 2021, 2:21 PM
Herald added a subscriber: cota. · View Herald TranscriptFeb 28 2021, 2:21 PM
rriddle updated this revision to Diff 327948.Mar 3 2021, 3:34 PM
rriddle marked an inline comment as done.

Rebase

mlir/include/mlir/Dialect/PDL/IR/PDLOps.td
176

input here should probably be external, as that is the property that input was poorly trying to convey.

This revision was landed with ongoing or failed builds.Mar 3 2021, 3:55 PM
Closed by commit rGe07c968a6da0: [mlir][pdl][NFC] Rename InputOp to OperandOp (authored by rriddle). · Explain Why
This revision was automatically updated to reflect the committed changes.
rriddle added a commit: rGe07c968a6da0: [mlir][pdl][NFC] Rename InputOp to OperandOp.
Harbormaster completed remote builds in B91923: Diff 327948.Mar 4 2021, 1:32 AM

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
PDL/
IR/
4 lines
26 lines
lib/
Conversion/
PDLToPDLInterp/
6 lines
Dialect/
PDL/
IR/
8 lines
test/
Conversion/
PDLToPDLInterp/
6 lines
6 lines
Dialect/
PDL/
6 lines
6 lines

Diff 327953

View Options

mlir/include/mlir/Dialect/PDL/IR/PDLDialect.td

Loading...
View Options

mlir/include/mlir/Dialect/PDL/IR/PDLOps.td

Loading...
View Options

mlir/lib/Conversion/PDLToPDLInterp/PredicateTree.cpp

Loading...
View Options

mlir/lib/Dialect/PDL/IR/PDL.cpp

Loading...
View Options

mlir/test/Conversion/PDLToPDLInterp/pdl-to-pdl-interp-matcher.mlir

Loading...
View Options

mlir/test/Conversion/PDLToPDLInterp/pdl-to-pdl-interp-rewriter.mlir

Loading...
View Options

mlir/test/Dialect/PDL/invalid.mlir

Loading...
View Options

mlir/test/Dialect/PDL/ops.mlir

Loading...