Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

[mlir][pdl] Add a new !pdl.range<> type
ClosedPublic
Actions

Authored by rriddle on Jan 29 2021, 7:54 PM.

Details

Reviewers

mehdi_amini
jpienaar
bollu

Commits

rG55f878bad964: [mlir][pdl] Add a new !pdl.range<> type

Summary

This type represents a range of positional values. It will be used in followup revisions to add support for variadic constructs to PDL, such as operand and result ranges.

Depends On D95716

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rriddle created this revision.Jan 29 2021, 7:54 PM

Herald added a reviewer: bollu. · View Herald TranscriptJan 29 2021, 7:54 PM

Herald added subscribers: teijeong, rdzhabarov, tatianashp and 13 others. · View Herald Transcript

rriddle requested review of this revision.Jan 29 2021, 7:54 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 29 2021, 7:54 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

rriddle added a child revision: D95718: [mlir][pdl][NFC] Rename InputOp to OperandOp.Jan 29 2021, 7:54 PM

Harbormaster completed remote builds in B87242: Diff 320264.Jan 29 2021, 8:27 PM

jpienaar accepted this revision.Feb 28 2021, 2:19 PM

jpienaar added inline comments.

mlir/include/mlir/Dialect/PDL/IR/PDLTypes.td
58	So the range itself is not captured as a parem (or am I missing it?) but this the type corresponding to the runtime range
64	Could we add kwarg style comments for the different bodies?

This revision is now accepted and ready to land.Feb 28 2021, 2:19 PM

Herald added a subscriber: cota. · View Herald TranscriptFeb 28 2021, 2:19 PM

Rebase

mlir/include/mlir/Dialect/PDL/IR/PDLTypes.td
58	Reworded. If we look at something like ValueRange in the same way as Value, a `PDL_Range<Value>` is not conceptually different from a `PDL_Value`. The PDL_Range is a handle to multiple values, the PDL_Value is a handle to one.
64	Obsolete now that the getChecked body is no longer necessary.