Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[mlir][pdl][NFC] Extract the execution of each bytecode operation into its own function
ClosedPublic
Actions

Authored by rriddle on Jan 29 2021, 7:53 PM.

Details

Reviewers

mehdi_amini
jpienaar
bollu

Commits

rG154cabe722de: [mlir][pdl][NFC] Extract the execution of each bytecode operation into its own…

Summary

This makes the implementation of each bytecode operation much easier to reason about, and lets the compiler decide which implementations are beneficial to inline into the main switch.

Depends On D95715

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rriddle created this revision.Jan 29 2021, 7:53 PM

Herald added a reviewer: bollu. · View Herald TranscriptJan 29 2021, 7:53 PM

Herald added subscribers: teijeong, rdzhabarov, tatianashp and 12 others. · View Herald Transcript

rriddle requested review of this revision.Jan 29 2021, 7:53 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 29 2021, 7:53 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

rriddle added a child revision: D95717: [mlir][pdl] Add a new !pdl.range<> type.Jan 29 2021, 7:54 PM

Harbormaster completed remote builds in B87241: Diff 320263.Jan 29 2021, 8:32 PM

jpienaar accepted this revision.Feb 18 2021, 5:12 PM

This revision is now accepted and ready to land.Feb 18 2021, 5:12 PM

Closed by commit rG154cabe722de: [mlir][pdl][NFC] Extract the execution of each bytecode operation into its own… (authored by rriddle). · Explain WhyFeb 22 2021, 7:08 PM

This revision was automatically updated to reflect the committed changes.

rriddle added a commit: rG154cabe722de: [mlir][pdl][NFC] Extract the execution of each bytecode operation into its own….

Revision Contents
Changeset List

Path

Size

mlir/

lib/

Rewrite/

ByteCode.cpp

779 lines

Diff 325643

View Options

mlir/lib/Rewrite/ByteCode.cpp