This is an archive of the discontinued LLVM Phabricator instance.

[mlir][pdl] Fix bug when ordering predicates

Authored by rriddle on Jan 29 2021, 7:53 PM.



We should be ordering predicates with higher primary/secondary sums first, but we are currently ordering them last. This allows for predicates more frequently encountered to be checked first.

Diff Detail

Event Timeline

rriddle created this revision.Jan 29 2021, 7:53 PM
rriddle requested review of this revision.Jan 29 2021, 7:53 PM
jpienaar accepted this revision.Feb 18 2021, 3:47 PM
jpienaar added inline comments.

both ? This reads like a generic statement while I believe it is a specific one related to this test

This revision is now accepted and ready to land.Feb 18 2021, 3:47 PM
This revision was automatically updated to reflect the committed changes.
rriddle marked an inline comment as done.