This is an archive of the discontinued LLVM Phabricator instance.

[NFC][RISCV] Remove redundant pseudo instructions for vector load/store.
ClosedPublic

Authored by HsiangKai on Jan 28 2021, 11:16 PM.

Details

Summary

Not all combinations of SEW and LMUL we need to support. For example, we
only need to support [M1, M2, M4, M8] for SEW = 64. There is no need to
define pseudos for PseudoVLSE64MF8, PseudoVLSE64MF4, and PseudoVLSE64MF2.

Diff Detail

Event Timeline

HsiangKai created this revision.Jan 28 2021, 11:16 PM
HsiangKai requested review of this revision.Jan 28 2021, 11:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2021, 11:16 PM
Herald added a subscriber: MaskRay. · View Herald Transcript
khchen accepted this revision.Jan 29 2021, 12:17 AM

Yes, thanks for fixup!
LGTM.

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
3165

/*fault-only-first=*/ is correct style.

3192

Ditto.

This revision is now accepted and ready to land.Jan 29 2021, 12:17 AM
jrtc27 added inline comments.Jan 29 2021, 4:35 AM
llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
3165

No, /*isFF=*/, it's always the name of the argument (and fault-only-first isn't even a valid identifier).

HsiangKai added inline comments.Jan 29 2021, 5:25 AM
llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
3165

Yeah, I didn't intend to use the argument name in the comment. I use the name in the V specification for its purpose in the comments. Anyway, I will change it to /*isFF=*/.

This revision was landed with ongoing or failed builds.Jan 29 2021, 3:20 PM
This revision was automatically updated to reflect the committed changes.