This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy][NFC][Wasm] Do not use internal buffer while writing into the output.

Authored by avl on Jan 26 2021, 1:05 PM.



This patch is follow-up for D91028. It implements direct writing into the
output stream for wasm.

Depends on D91028

Diff Detail

Event Timeline

avl created this revision.Jan 26 2021, 1:05 PM
avl requested review of this revision.Jan 26 2021, 1:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2021, 1:05 PM
avl updated this revision to Diff 329844.Mar 10 2021, 9:59 PM


jhenderson accepted this revision.Mar 18 2021, 1:46 AM

LGTM, with nit.


I think prefer reinterpret_cast here and below, since that was the style that was there before.

This revision is now accepted and ready to land.Mar 18 2021, 1:46 AM
avl added a comment.Mar 18 2021, 6:04 AM

thanks for reviewing.