Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[mlir][TypeDefGen] Remove the need to define parser/printer for singleton types
ClosedPublic
Actions

Authored by rriddle on Jan 6 2021, 1:49 PM.

Details

Reviewers

jpienaar
mehdi_amini

Commits

rG41d919aa2946: [mlir][TypeDefGen] Remove the need to define parser/printer for singleton types

Summary

This allows for singleton types without an explicit parser/printer to simply use
the mnemonic as the assembly format, removing the need for these types to provide the parser/printer
fields.

Depends On D94192

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rriddle created this revision.Jan 6 2021, 1:49 PM

Herald added subscribers: teijeong, rdzhabarov, tatianashp and 12 others. · View Herald TranscriptJan 6 2021, 1:49 PM

rriddle requested review of this revision.Jan 6 2021, 1:49 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2021, 1:49 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B84254: Diff 314978.Jan 6 2021, 2:07 PM

mehdi_amini accepted this revision.Jan 6 2021, 2:33 PM

This revision is now accepted and ready to land.Jan 6 2021, 2:33 PM

Closed by commit rG41d919aa2946: [mlir][TypeDefGen] Remove the need to define parser/printer for singleton types (authored by rriddle). · Explain WhyJan 6 2021, 3:00 PM

This revision was automatically updated to reflect the committed changes.

rriddle added a commit: rG41d919aa2946: [mlir][TypeDefGen] Remove the need to define parser/printer for singleton types.

Revision Contents
Changeset List

Path

Size

mlir/

test/

lib/

Dialect/

Test/

TestTypeDefs.td

3 lines

tools/

mlir-tblgen/

TypeDefGen.cpp

46 lines

Diff 315001

View Options

mlir/test/lib/Dialect/Test/TestTypeDefs.td