This is an archive of the discontinued LLVM Phabricator instance.

[mlir][ODS] Rename several uses of 'description' to 'summary'
ClosedPublic

Authored by rriddle on Jan 5 2021, 3:51 PM.

Details

Summary

Right now constraint/predicate traits/etc. use their "description" field as a one line human readable string. This breaks the current convention, by which a "description" may be multi-line. This revision renames the "description" field in these cases to "summary" which matches what the string is actually used as. This also unbreaks the use of TypeDefs(and eventually AttrDefs) in conjunction with existing type constraint facilities like Optional.

Diff Detail

Event Timeline

rriddle created this revision.Jan 5 2021, 3:51 PM
rriddle requested review of this revision.Jan 5 2021, 3:51 PM
silvas accepted this revision.Jan 5 2021, 3:53 PM
jpienaar accepted this revision.Jan 5 2021, 5:06 PM
This revision is now accepted and ready to land.Jan 5 2021, 5:06 PM