Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D94135

[mlir][PDL] Use ODS for defining PDL types
ClosedPublic
Actions

Authored by rriddle on Jan 5 2021, 3:53 PM.

Details

Reviewers
jpienaar
antiagainst
mehdi_amini
Commits
rGe45840f4af46: [mlir][PDL] Use ODS for defining PDL types
Summary

This removes the need to define these classes and their parser/printers in C++.

Depends On D94133

Diff Detail

Event Timeline

rriddle created this revision.Jan 5 2021, 3:53 PM
Herald added a reviewer: antiagainst. · View Herald TranscriptJan 5 2021, 3:53 PM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 15 others. · View Herald Transcript
rriddle requested review of this revision.Jan 5 2021, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2021, 3:53 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B84134: Diff 314744.Jan 5 2021, 4:06 PM
mehdi_amini added inline comments.Jan 5 2021, 5:59 PM
mlir/lib/TableGen/Type.cpp
72 ↗(On Diff #314744)

This seems orthogonal to PDL, can you split it out?

rriddle updated this revision to Diff 314972.Jan 6 2021, 1:22 PM

Rebase

Harbormaster completed remote builds in B84248: Diff 314972.Jan 6 2021, 1:33 PM
rriddle updated this revision to Diff 314975.Jan 6 2021, 1:36 PM

Rebase

rriddle marked an inline comment as done.Jan 6 2021, 1:37 PM
Harbormaster completed remote builds in B84251: Diff 314975.Jan 6 2021, 1:46 PM
rriddle updated this revision to Diff 314979.Jan 6 2021, 1:50 PM

Rebase

Harbormaster completed remote builds in B84255: Diff 314979.Jan 6 2021, 2:01 PM
mehdi_amini accepted this revision.Jan 6 2021, 3:28 PM
This revision is now accepted and ready to land.Jan 6 2021, 3:28 PM
antiagainst accepted this revision.Jan 7 2021, 12:06 PM

Looks neat! :)

This revision was landed with ongoing or failed builds.Jan 8 2021, 12:45 PM
Closed by commit rGe45840f4af46: [mlir][PDL] Use ODS for defining PDL types (authored by rriddle). · Explain Why
This revision was automatically updated to reflect the committed changes.
rriddle added a commit: rGe45840f4af46: [mlir][PDL] Use ODS for defining PDL types.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
PDL/
IR/
12 lines
PDLDialect.td
PDLBase.td
37 lines
19 lines
2 lines
28 lines
84 lines
PDLInterp/
IR/
1 line
2 lines
lib/
Conversion/
PDLToPDLInterp/
2 lines
Dialect/
PDL/
IR/
62 lines
Rewrite/
2 lines

Diff 315492

View Options

mlir/include/mlir/Dialect/PDL/IR/PDL.h

Loading...
View Options

mlir/include/mlir/Dialect/PDL/IR/PDLBase.td

Loading...
View Options

mlir/include/mlir/Dialect/PDL/IR/PDLDialect.td

Loading...
View Options

mlir/include/mlir/Dialect/PDL/IR/PDLOps.h

Loading...
View Options

mlir/include/mlir/Dialect/PDL/IR/PDLOps.td

Loading...
View Options

mlir/include/mlir/Dialect/PDL/IR/PDLTypes.h

Loading...
View Options

mlir/include/mlir/Dialect/PDL/IR/PDLTypes.td

Loading...
View Options

mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterp.h

Loading...
View Options

mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterpOps.td

Loading...
View Options

mlir/lib/Conversion/PDLToPDLInterp/PredicateTree.h

Loading...
View Options

mlir/lib/Dialect/PDL/IR/PDL.cpp

Loading...
View Options

mlir/lib/Rewrite/FrozenRewritePatternList.cpp

Loading...