Page MenuHomePhabricator
Differential D93788

[X86] Transform amx pointer.
Needs ReviewPublic
Actions

Authored by LuoYuanke on Dec 23 2020, 6:03 PM.

Details

Reviewers
craig.topper
pengfei
lebedev.ri
spatel
RKSimon
jyknight
Florian
Summary

Front-end bitcast <256 x i32> to x86_amx and generate load/store <256 x i32>*.
In instruction combine pass it transform load/store <256 x i32>* to
load/store x86_amx*. In the amx type lowering pass , we lower the load/store
instructions to amx load/store intrinsics with the stride value 64.

Diff Detail

Event Timeline

LuoYuanke created this revision.Dec 23 2020, 6:03 PM
Herald added subscribers: pengfei, hiraditya. · View Herald TranscriptDec 23 2020, 6:03 PM
LuoYuanke requested review of this revision.Dec 23 2020, 6:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 23 2020, 6:03 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B83443: Diff 313636.Dec 23 2020, 6:04 PM
LuoYuanke added a parent revision: D91927: [X86] Add x86_amx type for intel AMX..Dec 23 2020, 6:04 PM
LuoYuanke mentioned this in D98247: [X86][AMX] Prevent transforming load pointer from <256 x i32>* to x86_amx*..Mar 9 2021, 4:53 AM
LuoYuanke updated this revision to Diff 332053.Mar 19 2021, 6:29 PM

Rebase.

Harbormaster completed remote builds in B94825: Diff 332053.Mar 19 2021, 6:29 PM
LuoYuanke updated this revision to Diff 332098.Mar 20 2021, 5:40 AM

Support PHI operation.

Harbormaster completed remote builds in B94855: Diff 332098.Mar 20 2021, 5:41 AM
LuoYuanke edited the summary of this revision. (Show Details)Mar 20 2021, 5:44 AM
LuoYuanke added reviewers: craig.topper, pengfei, lebedev.ri, spatel, RKSimon, jyknight, Florian.
LuoYuanke edited the summary of this revision. (Show Details)
LuoYuanke added a subscriber: annita.zhang.
RKSimon added a comment.Mar 23 2021, 2:44 AM

a few style comments

llvm/lib/Target/X86/X86LowerAMXType.cpp
102

isa<>

130

isa<>

348

'''
if (auto *ST = dyn_cast<StoreInst>(I))
'''

lebedev.ri added a comment.Jan 11 2022, 2:31 PM

What's the status here?

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
X86/
136 lines
test/
CodeGen/
X86/
AMX/
92 lines

Diff 332098

View Options

llvm/lib/Target/X86/X86LowerAMXType.cpp

Loading...
View Options

llvm/test/CodeGen/X86/AMX/amx-type.ll

Loading...