This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] libomp: fix non-X86 non-AARCH64 builds
ClosedPublic

Authored by AndreyChurbanov on Nov 24 2020, 6:42 AM.

Details

Summary

Macro KMP_PREFIX_UNDERSCORE defined only for x86, x86_64 and aarch64 architectures.
This patch defines the macro to no-op in case it was not defined previously.

Diff Detail

Event Timeline

AndreyChurbanov requested review of this revision.Nov 24 2020, 6:42 AM

Adding that “emergency definition” of KMP_PREFIX_UNDERSCORE there at line 1730 seems reasonable. Similar code appears at lines 71 and 133; the function’s overall lack of orthogonality between OS and Hardware could be addressed later. I perceive no enthusiasm for a redesign.

Hi Andrey, I can confirm this fixes the build for RISC-V.

kaz7 added a comment.Nov 24 2020, 2:48 PM

Hi, it works fine for, not merged yet, VE architecture. Thank you for emergency patch.

hbae accepted this revision.Nov 24 2020, 4:01 PM

LGTM.

This revision is now accepted and ready to land.Nov 24 2020, 4:01 PM
This revision was automatically updated to reflect the committed changes.