LLD/AMDGPU: Infer os abi based on input llvm bitcode

[MaskRay]

lld/test/ELF/lto/amdgcn-amdhsa.ll

1 ↗

(On Diff #296949)

The three tests are mostly identical. ; RUN: split-file %s %t may be a good fit to place the three tests in one file.

[kzhuravl]

Address review feedback:

• Merge tests into one test file

lld/ELF/InputFiles.cpp

case Triple::x86_64:
     return EM_X86_64;
   default:
     error(path + ": could not infer e_machine from bitcode target triple " +
           t.str());
     return EM_NONE;
   }
 }
 
+static uint8_t getOsAbi(const Triple &t) {
+  switch (t.getOS()) {
+  case Triple::AMDHSA:
+    return ELF::ELFOSABI_AMDGPU_HSA;
+  case Triple::AMDPAL:
+    return ELF::ELFOSABI_AMDGPU_PAL;
+  case Triple::Mesa3D:
+    return ELF::ELFOSABI_AMDGPU_MESA3D;
+  default:
+    return ELF::ELFOSABI_NONE;
+  }
+}
+
 BitcodeFile::BitcodeFile(MemoryBufferRef mb, StringRef archiveName,
                          uint64_t offsetInArchive)
     : InputFile(BitcodeKind, mb) {
   this->archiveName = std::string(archiveName);
 
   std::string path = mb.getBufferIdentifier().str();
   if (config->thinLTOIndexOnly)
     path = replaceThinLTOSuffix(mb.getBufferIdentifier());
StringRef name =
                        utostr(offsetInArchive) + ")");
   MemoryBufferRef mbref(mb.getBuffer(), name);
 
   obj = CHECK(lto::InputFile::create(mbref), this);
 
   Triple t(obj->getTargetTriple());
   ekind = getBitcodeELFKind(t);
   emachine = getBitcodeMachineKind(mb.getBufferIdentifier(), t);
+  osabi = getOsAbi(t);
 }
 
 static uint8_t mapVisibility(GlobalValue::VisibilityTypes gvVisibility) {
   switch (gvVisibility) {
   case GlobalValue::DefaultVisibility:
     return STV_DEFAULT;
   case GlobalValue::HiddenVisibility:
     return STV_HIDDEN;

lld/test/ELF/lto/amdgcn-oses.ll

+; REQUIRES: amdgpu
+
+; RUN: split-file %s %t
+
+; RUN: llvm-as %t/amdhsa.ll -o %t/amdhsa.o
+; RUN: ld.lld %t/amdhsa.o -o %t/amdhsa.so
+; RUN: llvm-readobj --file-headers %t/amdhsa.so | FileCheck %s --check-prefixes=GCN,AMDHSA
+
+; RUN: llvm-as %t/amdpal.ll -o %t/amdpal.o
+; RUN: ld.lld %t/amdpal.o -o %t/amdpal.so
+; RUN: llvm-readobj --file-headers %t/amdpal.so | FileCheck %s --check-prefixes=GCN,AMDPAL
+
+; RUN: llvm-as %t/mesa3d.ll -o %t/mesa3d.o
+; RUN: ld.lld %t/mesa3d.o -o %t/mesa3d.so
+; RUN: llvm-readobj --file-headers %t/mesa3d.so | FileCheck %s --check-prefixes=GCN,MESA3D
+
+; AMDHSA: OS/ABI: AMDGPU_HSA (0x40)
+; AMDPAL: OS/ABI: AMDGPU_PAL (0x41)
+; MESA3D: OS/ABI: AMDGPU_MESA3D (0x42)
+; GCN: ABIVersion: 0
+
+;--- amdhsa.ll
+target triple = "amdgcn-amd-amdhsa"
+target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-S32-A5"
+
+define void @_start() {
+  ret void
+}
+
+;--- amdpal.ll
+target triple = "amdgcn-amd-amdpal"
+target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-S32-A5"
+
+define void @_start() {
+  ret void
+}
+
+;--- mesa3d.ll
+target triple = "amdgcn-amd-mesa3d"
+target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-S32-A5"
+
+define void @_start() {
+  ret void
+}