Page MenuHomePhabricator

[mlir][openacc] Introduce acc.enter_data operation
ClosedPublic

Authored by clementval on Oct 6 2020, 7:33 PM.

Details

Summary

This patch introduces the acc.enter_data operation that represents an OpenACC Enter Data directive.
Operands and attributes are dervied from clauses in the spec 2.6.6.

Diff Detail

Event Timeline

clementval created this revision.Oct 6 2020, 7:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2020, 7:33 PM
clementval requested review of this revision.Oct 6 2020, 7:33 PM
clementval added inline comments.Oct 6 2020, 7:36 PM
mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
249

I added a topic on discourse a while back about modeling of if clause in OpenACC or OpenMP dialects. So it can be modeled on the op directly or we could let the frontend do the work and for example insert a scf.if operation with the acc.enter_data operation inside its then region. Anybody has a guidance on this.

https://llvm.discourse.group/t/modeled-as-operand-on-the-operation-or-done-by-the-frontend/1875?u=clementval

bondhugula added inline comments.
mlir/test/Dialect/OpenACC/ops.mlir
675–677

Nit: VALUE -> ONE

clementval added inline comments.Oct 7 2020, 11:19 AM
mlir/test/Dialect/OpenACC/ops.mlir
675–677

I don't mind changing this but other tests above use VALUE so just for consistency if I change here would need to change all the rest.

This revision is now accepted and ready to land.Oct 10 2020, 1:26 PM
This revision was landed with ongoing or failed builds.Oct 11 2020, 6:27 PM
This revision was automatically updated to reflect the committed changes.