Page MenuHomePhabricator

[mlir][openacc] Introduce acc.exit_data operation
ClosedPublic

Authored by clementval on Oct 7 2020, 8:00 AM.

Details

Summary

This patch introduces the acc.exit_data operation that represents an OpenACC Exit Data directive.
Operands and attributes are derived from clauses in the spec 2.6.6.

Diff Detail

Event Timeline

clementval created this revision.Oct 7 2020, 8:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2020, 8:00 AM
clementval requested review of this revision.Oct 7 2020, 8:00 AM

LGTM.

mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
252–254

#just-asking: Could the wait operand value be modelled as a type, so that we do not have to split it across three operands/attributes?

mlir/test/Dialect/OpenACC/invalid.mlir
182

Nit: No newline.

This revision is now accepted and ready to land.Oct 8 2020, 12:22 AM
clementval updated this revision to Diff 296963.Oct 8 2020, 7:08 AM

Add missing new line

clementval marked an inline comment as done.Oct 8 2020, 7:10 AM
clementval added inline comments.
mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
252–254

I guess we could. Operands and the attribute are mutually exclusive. The attribute is there only when there is no value in the clause. I'll have a look a that but will probably put that in a separate patch if we can change that since other op already model the wait clause this way.

This revision was automatically updated to reflect the committed changes.

@kiranchandramohan Thanks for the review. IF you have 2 minutes can you have a look at D88941. It's pretty much the same op for enter_data.