This is an archive of the discontinued LLVM Phabricator instance.

Differential D88040

[mlir] NFC: fix trivial typos under include directory
ClosedPublic

Authored by kiszk on Sep 21 2020, 12:07 PM.

Download Raw Diff

Details

Reviewers

mravishankar
antiagainst
rriddle
aartbik
jpienaar
ftynse
silvas
jdoerfert
nicolasvasilache

Commits

rGd7336ad5ff98: [mlir] NFC: fix trivial typos under include directory

Diff Detail

Event Timeline

kiszk created this revision.Sep 21 2020, 12:07 PM

Herald added a reviewer: mravishankar. · View Herald TranscriptSep 21 2020, 12:07 PM

Herald added a reviewer: antiagainst. · View Herald Transcript

Herald added a reviewer: rriddle. · View Herald Transcript

Herald added a reviewer: aartbik. · View Herald Transcript

Herald added a reviewer: jpienaar. · View Herald Transcript

Herald added a reviewer: ftynse. · View Herald Transcript

Herald added a reviewer: silvas. · View Herald Transcript

Herald added a reviewer: jdoerfert. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: tatianashp, ThomasRaoux, AlexeySotkin and 15 others. · View Herald Transcript

kiszk requested review of this revision.Sep 21 2020, 12:07 PM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptSep 21 2020, 12:07 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

jurahul added inline comments.Sep 21 2020, 12:16 PM

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td
633	should this be func?

Harbormaster completed remote builds in B72411: Diff 293226.Sep 21 2020, 12:26 PM

Thanks!

Thanks, LG with Rahul's comments addressed.

This revision is now accepted and ready to land.Sep 22 2020, 6:09 AM

address review comment

address review comment

Closed by commit rGd7336ad5ff98: [mlir] NFC: fix trivial typos under include directory (authored by kiszk). · Explain WhySep 22 2020, 10:02 AM

This revision was automatically updated to reflect the committed changes.

kiszk added a commit: rGd7336ad5ff98: [mlir] NFC: fix trivial typos under include directory.

Revision Contents

Path

Size

mlir/

include/

mlir/

Dialect/

Affine/

IR/

2 lines

Diff 293485

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td

Context not available.
	Example (3x3 valid convolution):			Example (3x3 valid convolution):

	```mlir			```mlir
	function @conv_2d(%D : memref<100x100xf32>, %K : memref<3x3xf32>) -> (memref<98x98xf32>) {			func @conv_2d(%D : memref<100x100xf32>, %K : memref<3x3xf32>) -> (memref<98x98xf32>) {
				jurahulUnsubmitted Not Done Reply Inline Actions should this be func? jurahul: should this be func?
	%O = alloc memref<98x98xf32>			%O = alloc memref<98x98xf32>
	affine.parallel (%x, %y) = (0, 0) to (98, 98) {			affine.parallel (%x, %y) = (0, 0) to (98, 98) {
	%0 = affine.parallel (%kx, %ky) = (0, 0) to (2, 2) reduce ("addf") {			%0 = affine.parallel (%kx, %ky) = (0, 0) to (2, 2) reduce ("addf") {
Context not available.