Details
- Reviewers
RKSimon nikic craig.topper spatel
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
This isn't ready to commit yet:
- there are a few code quality regressions in the test cases
- it provokes a crash on test/CodeGen/AMDGPU/global-extload-i16.ll which I haven't been able to fix yet
Update:
- See inline comments on the regressions.
- The crash is fixed. See D87757.
llvm/test/CodeGen/Mips/cconv/vector.ll | ||
---|---|---|
4206–4248 | There are some regressions in this file but also some improvements. I haven't worked out what's going on yet. | |
llvm/test/CodeGen/Thumb2/mve-vecreduce-mla.ll | ||
218–232 | Regression here and in other cases that are now using muls instead of umull/umlal. | |
llvm/test/CodeGen/X86/vector-fshl-128.ll | ||
188–190 | Regression. Quite a few tests are now using pxor+punpckhdq instead of pshufd. I wonder if some kind of combine could spot this case and turn it back into pshufd. | |
llvm/test/CodeGen/X86/vector-trunc-math.ll | ||
2712 | Regression. Perhaps we need better known bits analysis. |
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | ||
---|---|---|
17887 | Would this be better handled by SimplifyDemandedBits? |
Would this be better handled by SimplifyDemandedBits?