Details

Reviewers

jhenderson
labath
grimar
MaskRay
• espindola
alexander-shaposhnikov
rupprecht
jdoerfert

Commits

rGe151acc073ab: [DWARFYAML] Add support for emitting multiple abbrev tables.
rG290e399f9673: [DWARFYAML] Add support for emitting multiple abbrev tables.

Summary

This patch adds support for emitting multiple abbrev tables. Currently,
compilation units will always reference the first abbrev table.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	70 ms	linux > flang-Unit.Lower/_/FlangLoweringOpenMPTests::OpenMPLoweringTest.Barrier Note: Google Test filter = OpenMPLoweringTest.Barrier [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.
	70 ms	linux > flang-Unit.Lower/_/FlangLoweringOpenMPTests::OpenMPLoweringTest.EmptyParallel Note: Google Test filter = OpenMPLoweringTest.EmptyParallel [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.
	60 ms	linux > flang-Unit.Lower/_/FlangLoweringOpenMPTests::OpenMPLoweringTest.TaskWait Note: Google Test filter = OpenMPLoweringTest.TaskWait [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.
	60 ms	linux > flang-Unit.Lower/_/FlangLoweringOpenMPTests::OpenMPLoweringTest.TaskYield Note: Google Test filter = OpenMPLoweringTest.TaskYield [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.

Event Timeline

Higuoxing created this revision.Aug 18 2020, 11:00 PM

Herald added a reviewer: • espindola. · View Herald TranscriptAug 18 2020, 11:00 PM

Herald added a reviewer: alexander-shaposhnikov. · View Herald Transcript

Herald added a reviewer: rupprecht. · View Herald Transcript

Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, lldb-commits, cmtice and 3 others. · View Herald Transcript

Higuoxing requested review of this revision.Aug 18 2020, 11:00 PM

Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 18 2020, 11:00 PM

Herald added subscribers: sstefan1, JDevlieghere. · View Herald Transcript

Modified tests:

test/tools/yaml2obj/ELF/debug-abbrev.yaml: Add one more abbrev table in test case (a).
test/tools/yaml2obj/ELF/debug-info.yaml: Add test case (n). Test that yaml2obj emits an error message when a compilation unit has values but there is no associated abbrev tables.

The generated abbrev tables are verified using llvm-dwarfdump.

Harbormaster completed remote builds in B68854: Diff 286481.Aug 18 2020, 11:40 PM

Higuoxing added inline comments.Aug 18 2020, 11:56 PM

llvm/lib/ObjectYAML/DWARFEmitter.cpp
259–265	Comments from D83116 @jhenderson : It might make more sense to do this work in the caller of this function, and to maintain this function's interface. Some DIEs only have abbrev codes and do not have values. If we do this work in the caller of this function, yaml2obj will reject empty DIEs.

jhenderson added inline comments.Aug 19 2020, 1:08 AM

llvm/lib/ObjectYAML/DWARFEmitter.cpp
100	Don't use `auto` here. It's not obvious what the type is.
llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml
900
llvm/tools/obj2yaml/dwarf2yaml.cpp
27–44	Does this work?

Address review comments.
Modify test: llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml

llvm/tools/obj2yaml/dwarf2yaml.cpp
27–44	Yes, I think it works.

LGTM, except for the new test change - I think that should be in a different patch.

llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml
2	Let's move this test change into a different patch, to avoid doing too much at once.

This revision is now accepted and ready to land.Aug 19 2020, 2:04 AM

Revert "llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml"

Harbormaster completed remote builds in B68866: Diff 286507.Aug 19 2020, 2:26 AM

jhenderson accepted this revision.Aug 19 2020, 2:27 AM

Harbormaster completed remote builds in B68869: Diff 286511.Aug 19 2020, 3:06 AM

labath accepted this revision.Aug 19 2020, 4:42 AM

Rebase.

Thanks for reviewing!

Harbormaster completed remote builds in B68979: Diff 286708.Aug 19 2020, 10:03 PM

Higuoxing added a child revision: D83116: [DWARFYAML] Add support for referencing different abbrev tables..Aug 20 2020, 2:45 AM

This revision was landed with ongoing or failed builds.Aug 20 2020, 7:31 PM

Closed by commit rG290e399f9673: [DWARFYAML] Add support for emitting multiple abbrev tables. (authored by Higuoxing). · Explain Why

This revision was automatically updated to reflect the committed changes.

Higuoxing added a commit: rG290e399f9673: [DWARFYAML] Add support for emitting multiple abbrev tables..

Higuoxing added a commit: rGe151acc073ab: [DWARFYAML] Add support for emitting multiple abbrev tables..Aug 20 2020, 8:44 PM

[DWARFYAML] Add support for emitting multiple abbrev tables.
ClosedPublic
Actions

Details

Diff Detail

Unit TestsFailed
View All

Event Timeline

Revision Contents
Changeset List

Diff 286708

lldb/test/API/functionalities/source-map/a.yaml

lldb/unittests/Expression/DWARFExpressionTest.cpp

lldb/unittests/Symbol/Inputs/inlined-functions.yaml

lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp

lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp

llvm/include/llvm/ObjectYAML/DWARFYAML.h

llvm/lib/ObjectYAML/DWARFEmitter.cpp

llvm/lib/ObjectYAML/DWARFYAML.cpp

llvm/test/ObjectYAML/MachO/DWARF-BigEndian.yaml

llvm/test/ObjectYAML/MachO/DWARF-LittleEndian.yaml

llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml

llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml

llvm/test/ObjectYAML/MachO/DWARF-debug_line.yaml

llvm/test/ObjectYAML/MachO/DWARF-debug_ranges.yaml

llvm/test/ObjectYAML/MachO/DWARF2-AddrSize8-FormValues.yaml

llvm/test/ObjectYAML/MachO/DWARF5-abbrevValues.yaml

llvm/test/ObjectYAML/MachO/DWARF5-debug_info.yaml

llvm/test/tools/llvm-dwarfdump/X86/verify_attr_file_indexes.yaml

llvm/test/tools/llvm-dwarfdump/X86/verify_attr_file_indexes_no_files.yaml

llvm/test/tools/llvm-dwarfdump/X86/verify_file_encoding.yaml

llvm/test/tools/llvm-dwarfdump/X86/verify_overlapping_cu_ranges.yaml

llvm/test/tools/llvm-gsymutil/ARM_AArch64/fat-macho-dwarf.yaml

llvm/test/tools/llvm-gsymutil/X86/mach-dwarf.yaml

llvm/test/tools/llvm-objcopy/MachO/Inputs/strip-all-with-dwarf.yaml

llvm/test/tools/yaml2obj/ELF/DWARF/debug-abbrev.yaml

llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml

llvm/tools/obj2yaml/dwarf2yaml.cpp

llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp

llvm/unittests/DebugInfo/DWARF/DWARFDieTest.cpp

llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp

[DWARFYAML] Add support for emitting multiple abbrev tables.ClosedPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Revision ContentsChangeset List

Diff 286708

lldb/test/API/functionalities/source-map/a.yaml

lldb/unittests/Expression/DWARFExpressionTest.cpp

lldb/unittests/Symbol/Inputs/inlined-functions.yaml

lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp

lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp

llvm/include/llvm/ObjectYAML/DWARFYAML.h

llvm/lib/ObjectYAML/DWARFEmitter.cpp

llvm/lib/ObjectYAML/DWARFYAML.cpp

llvm/test/ObjectYAML/MachO/DWARF-BigEndian.yaml

llvm/test/ObjectYAML/MachO/DWARF-LittleEndian.yaml

llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml

llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml

llvm/test/ObjectYAML/MachO/DWARF-debug_line.yaml

llvm/test/ObjectYAML/MachO/DWARF-debug_ranges.yaml

llvm/test/ObjectYAML/MachO/DWARF2-AddrSize8-FormValues.yaml

llvm/test/ObjectYAML/MachO/DWARF5-abbrevValues.yaml

llvm/test/ObjectYAML/MachO/DWARF5-debug_info.yaml

llvm/test/tools/llvm-dwarfdump/X86/verify_attr_file_indexes.yaml

llvm/test/tools/llvm-dwarfdump/X86/verify_attr_file_indexes_no_files.yaml

llvm/test/tools/llvm-dwarfdump/X86/verify_file_encoding.yaml

llvm/test/tools/llvm-dwarfdump/X86/verify_overlapping_cu_ranges.yaml

llvm/test/tools/llvm-gsymutil/ARM_AArch64/fat-macho-dwarf.yaml

llvm/test/tools/llvm-gsymutil/X86/mach-dwarf.yaml

llvm/test/tools/llvm-objcopy/MachO/Inputs/strip-all-with-dwarf.yaml

llvm/test/tools/yaml2obj/ELF/DWARF/debug-abbrev.yaml

llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml

llvm/tools/obj2yaml/dwarf2yaml.cpp

llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp

llvm/unittests/DebugInfo/DWARF/DWARFDieTest.cpp

llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp

[DWARFYAML] Add support for emitting multiple abbrev tables.
ClosedPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List