This patch adds support for emitting multiple abbrev tables. Currently,
compilation units will always reference the first abbrev table.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
Modified tests:
test/tools/yaml2obj/ELF/debug-abbrev.yaml: Add one more abbrev table in test case (a).
test/tools/yaml2obj/ELF/debug-info.yaml: Add test case (n). Test that yaml2obj emits an error message when a compilation unit has values but there is no associated abbrev tables.
The generated abbrev tables are verified using llvm-dwarfdump.
llvm/lib/ObjectYAML/DWARFEmitter.cpp | ||
---|---|---|
259–265 | Some DIEs only have abbrev codes and do not have values. If we do this work in the caller of this function, yaml2obj will reject empty DIEs. |
- Address review comments.
- Modify test: llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml
llvm/tools/obj2yaml/dwarf2yaml.cpp | ||
---|---|---|
27–44 | Yes, I think it works. |
LGTM, except for the new test change - I think that should be in a different patch.
llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml | ||
---|---|---|
2 | Let's move this test change into a different patch, to avoid doing too much at once. |
clang-tidy: error: 'lldb/Expression/DWARFExpression.h' file not found [clang-diagnostic-error]
not useful