This patch adds support for emitting multiple abbrev tables. Currently,
compilation units will always reference the first abbrev table.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Time | Test | |
---|---|---|
70 ms | linux > flang-Unit.Lower/_/FlangLoweringOpenMPTests::OpenMPLoweringTest.Barrier Note: Google Test filter = OpenMPLoweringTest.Barrier
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
| |
70 ms | linux > flang-Unit.Lower/_/FlangLoweringOpenMPTests::OpenMPLoweringTest.EmptyParallel Note: Google Test filter = OpenMPLoweringTest.EmptyParallel
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
| |
60 ms | linux > flang-Unit.Lower/_/FlangLoweringOpenMPTests::OpenMPLoweringTest.TaskWait Note: Google Test filter = OpenMPLoweringTest.TaskWait
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
| |
60 ms | linux > flang-Unit.Lower/_/FlangLoweringOpenMPTests::OpenMPLoweringTest.TaskYield Note: Google Test filter = OpenMPLoweringTest.TaskYield
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
|
Event Timeline
Comment Actions
Modified tests:
test/tools/yaml2obj/ELF/debug-abbrev.yaml: Add one more abbrev table in test case (a).
test/tools/yaml2obj/ELF/debug-info.yaml: Add test case (n). Test that yaml2obj emits an error message when a compilation unit has values but there is no associated abbrev tables.
The generated abbrev tables are verified using llvm-dwarfdump.
llvm/lib/ObjectYAML/DWARFEmitter.cpp | ||
---|---|---|
259–265 | Some DIEs only have abbrev codes and do not have values. If we do this work in the caller of this function, yaml2obj will reject empty DIEs. |
Comment Actions
- Address review comments.
- Modify test: llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml
llvm/tools/obj2yaml/dwarf2yaml.cpp | ||
---|---|---|
27–44 | Yes, I think it works. |
Comment Actions
LGTM, except for the new test change - I think that should be in a different patch.
llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml | ||
---|---|---|
2 | Let's move this test change into a different patch, to avoid doing too much at once. |