Page MenuHomePhabricator

Higuoxing (Xing GUO)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2018, 6:21 AM (233 w, 23 h)

Recent Activity

Feb 19 2022

Higuoxing added a comment to D115973: [llvm-profgen] Support symbol loading for debug fission.

Currently, yaml2obj doesn't support generating split dwarf object files. I can help add support for some of the dwo sections but it needs several weeks? I guess. I proposed D120184 for adding support for emitting/dumping the .debug_str.dwo section.

Feb 19 2022, 4:33 AM · Unknown Object (Project)
Higuoxing requested review of D120184: [DWARFYAML] Add support for emitting/dumping the .debug_str.dwo section..
Feb 19 2022, 4:25 AM · Unknown Object (Project)

Dec 16 2021

Higuoxing added a comment to D113552: [yaml2obj][XCOFF] parsing auxiliary symbols..

Thank you so much for your reviewing. @jhenderson @Higuoxing
Do you have more comments for this patch?
Btw. there are 2 accepted patches (D113825 and D114434) depends on this patch.

Dec 16 2021, 12:48 AM · Unknown Object (Project)

Dec 9 2021

Higuoxing accepted D113825: [llvm-readobj][XCOFF] dump auxiliary symbols..
Dec 9 2021, 7:02 AM · Unknown Object (Project)

Nov 24 2021

Higuoxing added inline comments to D113825: [llvm-readobj][XCOFF] dump auxiliary symbols..
Nov 24 2021, 3:19 AM · Unknown Object (Project)

Nov 15 2021

Higuoxing added a comment to D82367: [ObjectYAML][ELF] Add support for emitting the .debug_gnu_pubnames/pubtypes sections..

The GCC doc mentions that the "-ggnu-pubnames" option is only useful with a linker that can produce GDB@ index version 7.

Nov 15 2021, 5:39 PM · Unknown Object (Project)

Nov 10 2021

Higuoxing added inline comments to D113552: [yaml2obj][XCOFF] parsing auxiliary symbols..
Nov 10 2021, 6:59 PM · Unknown Object (Project)
Higuoxing added inline comments to D113552: [yaml2obj][XCOFF] parsing auxiliary symbols..
Nov 10 2021, 6:52 PM · Unknown Object (Project)

Oct 24 2021

Higuoxing added inline comments to D111700: [XCOFF] [llvm-readobj] improve the relocation output..
Oct 24 2021, 10:02 PM · Unknown Object (Project)

Oct 20 2021

Higuoxing accepted D112151: [llvm-dwarfdump] Add a test for --summarize-types.

I was looking to do this in YAML but I don't think there is support for debug_types?

Oct 20 2021, 6:59 PM · Unknown Object (Project)

Oct 13 2021

Higuoxing added inline comments to D111700: [XCOFF] [llvm-readobj] improve the relocation output..
Oct 13 2021, 6:42 PM · Unknown Object (Project)

Sep 27 2021

Higuoxing accepted D110595: [llvm-objdump] Fix -R display and support ET_EXEC.

LGTM.

Sep 27 2021, 6:05 PM · Unknown Object (Project)

Sep 24 2021

Higuoxing added inline comments to D110320: [XCOFF] Improve error message context..
Sep 24 2021, 1:47 AM · Unknown Object (Project)

Sep 23 2021

Higuoxing added a comment to D110320: [XCOFF] Improve error message context..

The code change generally looks good to me. But please make the error messages consistent, see my inline comments.

Sep 23 2021, 8:48 PM · Unknown Object (Project)

Sep 20 2021

Higuoxing updated subscribers of D109534: fixed ambiguous overload build failure.

Hi, @jhenderson, could you please help @juchem push his change since I haven't pushed to LLVM repo for a time.

Sep 20 2021, 11:49 PM · Unknown Object (Project)

Sep 14 2021

Higuoxing added a comment to D109534: fixed ambiguous overload build failure.

@Higuoxing the test that's failing on CI sounds unrelated to this patch. Can you help me figure out if that's the case? I'm unfamiliar with LLVM CI.
Also, I am not authorized to merge. If everything looks fine, who can help me with that?

Sep 14 2021, 11:10 PM · Unknown Object (Project)

Sep 13 2021

Higuoxing accepted D109566: [yaml2obj][XCOFF] add the SectionIndex field for symbol..

LGTM, thanks!

Sep 13 2021, 5:30 AM · Unknown Object (Project)
Higuoxing accepted D109534: fixed ambiguous overload build failure.

You are able to drop llvm::. Otherwise, LGTM.

Sep 13 2021, 5:28 AM · Unknown Object (Project)

Sep 12 2021

Higuoxing added inline comments to D109566: [yaml2obj][XCOFF] add the SectionIndex field for symbol..
Sep 12 2021, 8:42 AM · Unknown Object (Project)

Aug 22 2021

Higuoxing added a comment to D107421: [yaml2obj][XCOFF] Customize the string table..

The codes generally looks good to me.

Aug 22 2021, 10:36 PM · Unknown Object (Project)

Aug 12 2021

Higuoxing added inline comments to D107421: [yaml2obj][XCOFF] Customize the string table..
Aug 12 2021, 2:36 AM · Unknown Object (Project)

Aug 11 2021

Higuoxing added inline comments to D107421: [yaml2obj][XCOFF] Customize the string table..
Aug 11 2021, 1:36 AM · Unknown Object (Project)

Aug 4 2021

Higuoxing added inline comments to D107421: [yaml2obj][XCOFF] Customize the string table..
Aug 4 2021, 7:35 AM · Unknown Object (Project)
Higuoxing added inline comments to D107421: [yaml2obj][XCOFF] Customize the string table..
Aug 4 2021, 7:24 AM · Unknown Object (Project)

Aug 3 2021

Higuoxing added a comment to D107048: [dwarf][bugfix] Recompute the size of block before getting it's BestForm.

Can we make the test by using YAML (by hard-coding the DWARF)?

An example of DWARF YAML test is llvm/test/tools/llvm-dwarfdump/X86/stats-scope-bytes-covered.yaml.

@Higuoxing may be able to assist with this, if he's around - he did a fair bit of the yaml2obj DWARF support.

Aug 3 2021, 9:50 AM · debug-info, Restricted Project, Unknown Object (Project)
Higuoxing accepted D107333: [llvm-readobj][XCOFF] Print the length of the string table..

LGTM.

Aug 3 2021, 8:25 AM · Unknown Object (Project)

Jul 21 2021

Higuoxing accepted D106420: [yaml2obj] Do not write the string table if there is no string entry..

LGTM, thanks!

Jul 21 2021, 8:09 AM · Unknown Object (Project)

Jun 21 2021

Higuoxing added inline comments to D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Jun 21 2021, 7:33 PM · Unknown Object (Project)

Jun 15 2021

Higuoxing accepted D104035: [yaml2obj][obj2yaml] Support custom ELF section header string table name.

This patch looks great! I think the tests have covered everything.

Jun 15 2021, 10:59 PM · Unknown Object (Project)

Jun 9 2021

Higuoxing added a comment to D104005: [DWARFYAML] make obj2yaml use existing DWARF support for ELF.

As you see, the original DWARF parser is buggy and lacking of tests, so we haven't employed it in elf2yaml. You might need to modify the parser before adding it to elf2yaml. Could you please split this patch into several small patches and add some tests for it? Test cases for DWARF of elf2yaml are in llvm/test/tools/obj2yaml/ELF/DWARF (https://github.com/llvm/llvm-project/tree/main/llvm/test/tools/obj2yaml/ELF/DWARF).

Jun 9 2021, 10:35 PM · Unknown Object (Project)

Jun 8 2021

Higuoxing accepted D103901: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants..

LGTM, once @sfertile 's comments are addressed. Thanks!

Jun 8 2021, 5:50 PM · Unknown Object (Project)

Jun 4 2021

Higuoxing accepted D103676: [test] Fix accidental match in parent_recurse_depth.s.

LGTM, thanks!

Jun 4 2021, 3:03 AM · Unknown Object (Project)

Jun 3 2021

Higuoxing added inline comments to D103455: [yaml2obj] Add support for writing the long symbol name..
Jun 3 2021, 7:19 PM · Unknown Object (Project)

Jun 1 2021

Higuoxing accepted D103250: [llvm-dwarfdump][test] Add missing dedicated tests for some options.

LGTM. Thanks!

Jun 1 2021, 4:21 AM · Unknown Object (Project)

May 29 2021

Higuoxing added inline comments to D103250: [llvm-dwarfdump][test] Add missing dedicated tests for some options.
May 29 2021, 8:42 PM · Unknown Object (Project)

May 27 2021

Higuoxing added inline comments to D103250: [llvm-dwarfdump][test] Add missing dedicated tests for some options.
May 27 2021, 8:10 PM · Unknown Object (Project)

May 25 2021

Higuoxing accepted D103079: [XCOFF] [llvm-objdump] Add XCOFF recognition of debug section types under `--section-headers` option..

LGTM, thanks! But please wait until another reviewer is happy about this change :)

May 25 2021, 7:38 PM · Unknown Object (Project)
Higuoxing accepted D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..
May 25 2021, 3:26 AM · Unknown Object (Project)

May 24 2021

Higuoxing added inline comments to D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..
May 24 2021, 11:10 PM · Unknown Object (Project)

May 17 2021

Higuoxing added inline comments to D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..
May 17 2021, 7:56 PM · Unknown Object (Project)

May 5 2021

Higuoxing accepted D101646: [llvm-dwarfdump] Help option output should be consistent with the command guide.

LGTM

May 5 2021, 7:23 PM · Unknown Object (Project)

Apr 29 2021

Higuoxing accepted D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..

Only minor suggestions, otherwise LGTM. But please give somebody else a chance to review this change :)

Apr 29 2021, 8:00 PM · Unknown Object (Project)

Apr 13 2021

Higuoxing added inline comments to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Apr 13 2021, 6:10 PM · Unknown Object (Project)

Mar 29 2021

Higuoxing added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Mar 29 2021, 8:04 PM · Unknown Object (Project)

Mar 16 2021

Higuoxing added a comment to D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

@Higuoxing added more support to yaml2obj last year for DWARF emission via YAML. Maybe it would be best to wait on basic XCOFF yaml2obj support to be finished, add DWARF emission support to that, and then use yaml2obj to generate the DWARF output as required?

Also, the pre-merge checks claim your tests are failing.

Finally, how does this actually add support for llvm-dwarfdump + XCOFF? It's not particularly obvious to me, but I'm not all that familiar about what llvm-dwarfdump requires for this support.

Mar 16 2021, 5:19 AM · Unknown Object (Project)

Feb 15 2021

Higuoxing added inline comments to D96602: [llvm-nm][test] Add additional test coverage for llvm-nm options.
Feb 15 2021, 2:13 AM · Unknown Object (Project)

Feb 12 2021

Higuoxing accepted D96602: [llvm-nm][test] Add additional test coverage for llvm-nm options.

I only have one inline comment. Otherwise LGTM :)

Feb 12 2021, 7:23 AM · Unknown Object (Project)
Higuoxing accepted D96601: [llvm-nm] Tidy up error messages.

LGTM. Thanks!

Feb 12 2021, 6:56 AM · Unknown Object (Project)

Nov 2 2020

Higuoxing accepted D87179: Fix debug_abbrev emitter to only assign table id once.

LGTM, thanks!

Nov 2 2020, 2:41 AM · Unknown Object (Project)

Oct 16 2020

Higuoxing added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Oct 16 2020, 4:06 AM · Restricted Project, Unknown Object (Project)

Oct 13 2020

Higuoxing added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Oct 13 2020, 1:30 AM · Restricted Project, Unknown Object (Project)

Oct 8 2020

Higuoxing committed rGc1489ee5a773: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC. (authored by Higuoxing).
[llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC.
Oct 8 2020, 8:14 PM
Higuoxing closed D88200: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC..
Oct 8 2020, 8:13 PM · Unknown Object (Project)
Higuoxing committed rGdd554994729b: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields… (authored by Higuoxing).
[DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields…
Oct 8 2020, 8:10 PM
Higuoxing closed D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
Oct 8 2020, 8:10 PM · Unknown Object (Project)
Higuoxing updated the summary of D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
Oct 8 2020, 8:09 PM · Unknown Object (Project)
Higuoxing added inline comments to D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
Oct 8 2020, 1:52 AM · Unknown Object (Project)
Higuoxing updated the diff for D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
  • Test the default opcode_base field and the standard_opcode_lengths array of DWARFv2-DWARFv4 (DWARFv5 isn't supported yet).
  • Add missing comment.
Oct 8 2020, 1:43 AM · Unknown Object (Project)

Oct 4 2020

Higuoxing updated the diff for D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..

Use Version to determine the default opcode_base and standard_opcode_lengths fields.

Oct 4 2020, 11:42 PM · Unknown Object (Project)

Sep 28 2020

Higuoxing added inline comments to D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
Sep 28 2020, 5:57 AM · Unknown Object (Project)
Higuoxing updated the diff for D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
  • Make getStandardOpcodeLengths() return the standard_opcode_lengths according to the latest DWARF spec by default.
  • Add one test case where the opcode_base is greater than 13.
  • Address some inline comments.
Sep 28 2020, 5:57 AM · Unknown Object (Project)

Sep 26 2020

Higuoxing updated the diff for D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..

Update.

Sep 26 2020, 6:09 AM · Unknown Object (Project)
Higuoxing requested review of D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
Sep 26 2020, 5:19 AM · Unknown Object (Project)

Sep 24 2020

Higuoxing updated the diff for D88200: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC..

Split commands.

Sep 24 2020, 1:09 AM · Unknown Object (Project)
Higuoxing requested review of D88200: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC..
Sep 24 2020, 12:50 AM · Unknown Object (Project)

Sep 23 2020

Higuoxing committed rG505ac22f1a1a: [DWARFYAML] Make the ExtLen field of extended opcodes optional. (authored by Higuoxing).
[DWARFYAML] Make the ExtLen field of extended opcodes optional.
Sep 23 2020, 11:20 PM
Higuoxing closed D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..
Sep 23 2020, 11:20 PM · Unknown Object (Project)
Higuoxing updated the diff for D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..

Append --strict-whitespace option.
Use {{ }} to match more (2) spaces.

Sep 23 2020, 3:19 AM · Unknown Object (Project)
Higuoxing updated the diff for D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..

Thanks!

Sep 23 2020, 2:05 AM · Unknown Object (Project)
Higuoxing added inline comments to D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..
Sep 23 2020, 1:49 AM · Unknown Object (Project)
Higuoxing updated the diff for D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..

Address review comments.

Sep 23 2020, 1:49 AM · Unknown Object (Project)

Sep 22 2020

Higuoxing requested review of D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..
Sep 22 2020, 11:47 PM · Unknown Object (Project)
Higuoxing committed rG64435a427a01: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC. (authored by Higuoxing).
[DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC.
Sep 22 2020, 5:43 PM
Higuoxing closed D88073: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC..
Sep 22 2020, 5:43 PM · Unknown Object (Project)
Higuoxing requested review of D88073: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC..
Sep 22 2020, 12:18 AM · Unknown Object (Project)

Sep 21 2020

Higuoxing added inline comments to D88048: [dwarfdump] Add verifier check to find DIEs with DW_CHILDREN_yes but without children..
Sep 21 2020, 7:58 PM · Unknown Object (Project)
Higuoxing added a comment to D88048: [dwarfdump] Add verifier check to find DIEs with DW_CHILDREN_yes but without children..

maybe slightly long test case - could do this with the CU DIE itself? (perhaps a case where hand-crafted/substantially hand-modified assembly is OK, because it can be made /so/ simple - or maybe yaml2obj dwarf support is adequate for this use case?)

Sep 21 2020, 7:57 PM · Unknown Object (Project)

Sep 20 2020

Higuoxing added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 20 2020, 10:50 PM · Unknown Object (Project)
Higuoxing added inline comments to rG6bb912336804: DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI..
Sep 20 2020, 9:44 AM

Sep 18 2020

Higuoxing committed rG2d35092cd258: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the… (authored by Higuoxing).
[DWARFYAML] Make the include_directories, file_names and opcodes fields of the…
Sep 18 2020, 5:22 AM
Higuoxing closed D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional..
Sep 18 2020, 5:22 AM · Unknown Object (Project), Restricted Project
Higuoxing committed rGa761e81e2202: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC. (authored by Higuoxing).
[DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC.
Sep 18 2020, 5:20 AM
Higuoxing closed D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..
Sep 18 2020, 5:20 AM · Unknown Object (Project)
Higuoxing retitled D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC. from [DWARFYAML][test] Make checkers stricter. NFC. to [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..
Sep 18 2020, 1:32 AM · Unknown Object (Project)
Higuoxing updated the diff for D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional..

I might be missing it, but do you have direct testing showing that the default for IncludeDirs\Files\Opcodes is an empty output, when the output is written? I think it's important that this is tested.

Sep 18 2020, 1:30 AM · Unknown Object (Project), Restricted Project

Sep 17 2020

Higuoxing requested review of D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional..
Sep 17 2020, 8:03 PM · Unknown Object (Project), Restricted Project
Higuoxing updated the diff for D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..

Check the DWARF: tag.

Sep 17 2020, 7:49 PM · Unknown Object (Project)
Higuoxing requested review of D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..
Sep 17 2020, 7:46 PM · Unknown Object (Project)

Sep 15 2020

Higuoxing committed rG4171d5c30ad3: [obj2yaml] Add support for dumping the .debug_addr(v5) section. (authored by Higuoxing).
[obj2yaml] Add support for dumping the .debug_addr(v5) section.
Sep 15 2020, 11:49 PM
Higuoxing closed D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..
Sep 15 2020, 11:48 PM · Unknown Object (Project)
Higuoxing added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Sep 15 2020, 11:36 PM · Restricted Project, Unknown Object (Project)
Higuoxing updated the diff for D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..

Address comments.

Sep 15 2020, 12:21 AM · Unknown Object (Project)

Sep 14 2020

Higuoxing added inline comments to D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..
Sep 14 2020, 11:06 PM · Unknown Object (Project)
Higuoxing updated the diff for D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..

Address review comments.

Sep 14 2020, 11:06 PM · Unknown Object (Project)
Higuoxing requested review of D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..
Sep 14 2020, 1:30 AM · Unknown Object (Project)

Sep 13 2020

Higuoxing added a comment to D87179: Fix debug_abbrev emitter to only assign table id once.

@Higuoxing I didn't realize the DWARF section was completely new until I read your GSOC project. Thanks a lot for this work otherwise it would have been impossible for me to create the tests I needed for my other diff!

Sep 13 2020, 6:47 PM · Unknown Object (Project)
Higuoxing accepted D87179: Fix debug_abbrev emitter to only assign table id once.

LGTM with nit.

Sep 13 2020, 6:11 PM · Unknown Object (Project)

Sep 10 2020

Higuoxing committed rG0e47a8d17fe8: [obj2yaml] Add support for dumping the .debug_ranges section. (authored by Higuoxing).
[obj2yaml] Add support for dumping the .debug_ranges section.
Sep 10 2020, 5:49 PM
Higuoxing closed D87429: [obj2yaml] Add support for dumping the .debug_ranges section..
Sep 10 2020, 5:48 PM · Restricted Project
Higuoxing updated the diff for D87429: [obj2yaml] Add support for dumping the .debug_ranges section..

Address comments.

Sep 10 2020, 5:45 PM · Restricted Project