Page MenuHomePhabricator

Higuoxing (Xing)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2018, 6:21 AM (52 w, 2 d)

Recent Activity

Today

Higuoxing added a comment to D56533: [DOCS] it it => it.

Just a friendly ping. Thanks for your contribution. Do you have privilege to commit this change? If not, I'm glad to help you :)

Wed, Jan 16, 9:00 AM

Thu, Jan 10

Higuoxing accepted D56533: [DOCS] it it => it.

LGTM

Thu, Jan 10, 1:05 AM

Mon, Jan 7

Higuoxing accepted D56388: [ELF] Remove checking for spurious '@' at the end of dynamic symbol names.

LGTM

Mon, Jan 7, 9:26 AM

Sat, Jan 5

Higuoxing accepted D56319: [llvm-readobj] Don't print '@' at end of dynamic symbol names for symbols with no version.
Sat, Jan 5, 8:32 PM

Wed, Dec 19

Higuoxing updated the diff for D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).

(WIP) This is a backup.

Wed, Dec 19, 1:32 AM

Dec 17 2018

Higuoxing added a comment to D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).

Hi @Higuoxing. Is this ready for review again? It is currently marked as WIP/changes planned.

Dec 17 2018, 5:23 AM

Dec 15 2018

Higuoxing planned changes to D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).
Dec 15 2018, 1:49 AM
Higuoxing updated the diff for D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).
Dec 15 2018, 1:49 AM

Dec 12 2018

Higuoxing added a comment to D55329: [llvm-readobj] Little clean up inside `parseDynamicTable`.

FWIW: The check you mention in ELF.cpp is triggered by the following test script. This causes llvm-readelf to generate an unexpected error message, LLVM ERROR: Virtual address is not in any segment

cat > 1.c << \!
int foo = 10;
int main() { return foo; }
!

cat > script.t << \!
PHDRS {
  CODE_RO PT_LOAD;
  DATA PT_LOAD;
  GOT PT_LOAD;
  DYN PT_LOAD;
  DYNAMIC PT_DYNAMIC;
  RELADYN PT_LOAD;
}
SECTIONS {
  .text : { *(.text) } :CODE_RO
  .data : { *(.data) } :DATA
  .dynamic : { *(.dynamic) }: DYN : DYNAMIC
  .rela.dyn : {*(.rel.dyn)} : RELADYN
}
!

gcc -c 1.c -fPIC
ld -shared 1.o -T script.t -Bsymbolic -pie -soname foo -o foo
echo llvm-readelf:
llvm-readelf -d foo
echo readelf:
readelf -d foo
Dec 12 2018, 11:52 PM

Dec 7 2018

Higuoxing committed rL348701: [llvm-readobj] Little clean up inside `parseDynamicTable`.
[llvm-readobj] Little clean up inside `parseDynamicTable`
Dec 7 2018, 9:36 PM
Higuoxing closed D55329: [llvm-readobj] Little clean up inside `parseDynamicTable`.
Dec 7 2018, 9:36 PM
Higuoxing updated the diff for D55329: [llvm-readobj] Little clean up inside `parseDynamicTable`.

Rebase

Dec 7 2018, 9:35 PM
Higuoxing added a comment to D55329: [llvm-readobj] Little clean up inside `parseDynamicTable`.

LGTM for this change. The refactor is certainly good. I feel like I might have suggested this in a previous review a while back, but it obviously never happened (see D49016).

As for whether or not we should error in this case, the problem is that things like the Hash table are looked up using this function, and then an attempt may be made to dump the hash table from the loaded address. Potentially, this could lead to trying to access invalid memory, which is obviously bad. So perhaps before making any decision, you should look up what the implications would be of removing the error?

Dec 7 2018, 9:29 PM
Higuoxing committed rL348580: [yaml2obj] format some codes NFC..
[yaml2obj] format some codes NFC.
Dec 7 2018, 3:07 AM
Higuoxing closed D55419: [yaml2obj] format some codes NFC..
Dec 7 2018, 3:07 AM
Higuoxing updated the diff for D55419: [yaml2obj] format some codes NFC..

rebase

Dec 7 2018, 3:06 AM
Higuoxing reopened D55419: [yaml2obj] format some codes NFC..
Dec 7 2018, 3:05 AM
Higuoxing added a comment to rL348578: [yaml2obj] format some codes NFC..

@Higuoxing I'm seeing build failures because ELFYAML::VersionNeedSection is not defined - please revert and recommit with the missing definition.

Dec 7 2018, 2:54 AM
Higuoxing committed rL348579: [yaml2obj] revert bad change.
[yaml2obj] revert bad change
Dec 7 2018, 2:53 AM
Higuoxing added a comment to rL348578: [yaml2obj] format some codes NFC..

reverted

Dec 7 2018, 2:53 AM
Higuoxing added a comment to D55419: [yaml2obj] format some codes NFC..

Sorry, I commit this patch by mistakes, can someone help me revert this?

Dec 7 2018, 2:38 AM
Higuoxing committed rL348578: [yaml2obj] format some codes NFC..
[yaml2obj] format some codes NFC.
Dec 7 2018, 2:34 AM
Higuoxing closed D55419: [yaml2obj] format some codes NFC..
Dec 7 2018, 2:34 AM
Higuoxing updated the diff for D55419: [yaml2obj] format some codes NFC..

Rebase

Dec 7 2018, 2:32 AM
Higuoxing created D55419: [yaml2obj] format some codes NFC..
Dec 7 2018, 2:30 AM

Dec 5 2018

Higuoxing updated the summary of D55329: [llvm-readobj] Little clean up inside `parseDynamicTable`.
Dec 5 2018, 7:53 AM
Higuoxing created D55329: [llvm-readobj] Little clean up inside `parseDynamicTable`.
Dec 5 2018, 7:53 AM

Dec 4 2018

Higuoxing committed rL348264: [yaml2obj] Move redundant statements into a separate static function.
[yaml2obj] Move redundant statements into a separate static function
Dec 4 2018, 6:30 AM
Higuoxing closed D55220: [yaml2obj] Move redundant statements into a separate static function.
Dec 4 2018, 6:30 AM
Higuoxing updated the diff for D55220: [yaml2obj] Move redundant statements into a separate static function.

I just want to make the logic inside initSectionHeaders simple. I could wait until there are two places that needs simplify ...

Dec 4 2018, 6:18 AM
Higuoxing updated the diff for D55220: [yaml2obj] Move redundant statements into a separate static function.
Dec 4 2018, 2:53 AM
Higuoxing updated the diff for D55220: [yaml2obj] Move redundant statements into a separate static function.
Dec 4 2018, 2:38 AM
Higuoxing added inline comments to D55220: [yaml2obj] Move redundant statements into a separate static function.
Dec 4 2018, 2:20 AM
Higuoxing added inline comments to D55220: [yaml2obj] Move redundant statements into a separate static function.
Dec 4 2018, 2:19 AM

Dec 3 2018

Higuoxing planned changes to D54867: [yaml2obj] Introduce symbol version section to yaml2obj.
Dec 3 2018, 10:42 PM
Higuoxing created D55220: [yaml2obj] Move redundant statements into a separate static function.
Dec 3 2018, 7:28 AM

Dec 2 2018

Higuoxing planned changes to D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).
Dec 2 2018, 2:52 AM
Higuoxing updated the diff for D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).

Add dumper for symbol version definitions.

Dec 2 2018, 2:52 AM

Dec 1 2018

Higuoxing planned changes to D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971).
Dec 1 2018, 11:41 PM
Higuoxing added a parent revision for D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241): D54867: [yaml2obj] Introduce symbol version section to yaml2obj.
Dec 1 2018, 7:32 PM
Higuoxing added a child revision for D54867: [yaml2obj] Introduce symbol version section to yaml2obj: D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).
Dec 1 2018, 7:32 PM
Higuoxing committed rL348074: [llvm-readobj] Improve dynamic section iteration NFC..
[llvm-readobj] Improve dynamic section iteration NFC.
Dec 1 2018, 4:30 AM

Nov 30 2018

Higuoxing added inline comments to D21552: [llvm-readobj] - Teach llvm-readobj to print dependencies of SHT_GNU_verdef and refactor dumping method..
Nov 30 2018, 6:35 AM
Higuoxing added inline comments to D21552: [llvm-readobj] - Teach llvm-readobj to print dependencies of SHT_GNU_verdef and refactor dumping method..
Nov 30 2018, 6:26 AM
Higuoxing added inline comments to D21552: [llvm-readobj] - Teach llvm-readobj to print dependencies of SHT_GNU_verdef and refactor dumping method..
Nov 30 2018, 6:18 AM
Higuoxing added inline comments to D21552: [llvm-readobj] - Teach llvm-readobj to print dependencies of SHT_GNU_verdef and refactor dumping method..
Nov 30 2018, 6:17 AM
Higuoxing updated the diff for D54867: [yaml2obj] Introduce symbol version section to yaml2obj.

Refactor some codes

Nov 30 2018, 5:21 AM
Higuoxing updated the diff for D54867: [yaml2obj] Introduce symbol version section to yaml2obj.
Nov 30 2018, 4:54 AM

Nov 29 2018

Higuoxing added inline comments to D54867: [yaml2obj] Introduce symbol version section to yaml2obj.
Nov 29 2018, 7:32 AM
Higuoxing added a comment to D54867: [yaml2obj] Introduce symbol version section to yaml2obj.

Sorry, I've been a bit busy over the last couple of days. Where can I find documentation on these two sections you are adding support for?

Nov 29 2018, 7:26 AM
Higuoxing added a reviewer for D54867: [yaml2obj] Introduce symbol version section to yaml2obj: jakehehrlich.
Nov 29 2018, 3:19 AM
Higuoxing updated the diff for D54867: [yaml2obj] Introduce symbol version section to yaml2obj.

Updating D54867: [yaml2obj] Introduce symbol version section to yaml2obj

Nov 29 2018, 3:12 AM
Higuoxing updated the diff for D54867: [yaml2obj] Introduce symbol version section to yaml2obj.

Updating D54867: [yaml2obj] Introduce symbol version section to yaml2obj

Nov 29 2018, 3:10 AM
Higuoxing planned changes to D54867: [yaml2obj] Introduce symbol version section to yaml2obj.
Nov 29 2018, 12:07 AM

Nov 27 2018

Higuoxing updated the diff for D54867: [yaml2obj] Introduce symbol version section to yaml2obj.

format code

Nov 27 2018, 6:33 PM
Higuoxing updated the diff for D54867: [yaml2obj] Introduce symbol version section to yaml2obj.

Updating D54867: [yaml2obj] Introduce symbol version section to yaml2obj

Nov 27 2018, 6:10 PM
Higuoxing retitled D54867: [yaml2obj] Introduce symbol version section to yaml2obj from [yaml2obj] Make sh_info field editable in raw content section to [yaml2obj] Introduce symbol version section to yaml2obj.
Nov 27 2018, 6:08 PM

Nov 24 2018

Higuoxing updated the diff for D54867: [yaml2obj] Introduce symbol version section to yaml2obj.

format codes

Nov 24 2018, 3:05 AM
Higuoxing created D54867: [yaml2obj] Introduce symbol version section to yaml2obj.
Nov 24 2018, 3:01 AM

Nov 23 2018

Higuoxing planned changes to D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).
Nov 23 2018, 11:38 PM
Higuoxing added a comment to D54864: Introduce llvm-objdump man page.

lgtm, but seems that some hidden/alias options are not listed here. I am not expert in this area, so I will leave the decision to @kristina

Nov 23 2018, 8:33 PM
Higuoxing added a comment to D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).

I want to use YAML2Obj to generate the test files, but there are something wrong with that tool. So, I have to write a patch for that. This patch have to be suspended for some time, until that one landed ...

Nov 23 2018, 3:53 AM

Nov 21 2018

Higuoxing retitled D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241) from [llvm-objdump] Add `Version References` dumper (PR30241) to [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).
Nov 21 2018, 2:00 AM
Higuoxing added inline comments to D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).
Nov 21 2018, 1:47 AM
Higuoxing added inline comments to D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).
Nov 21 2018, 1:45 AM
Higuoxing updated the diff for D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).

Updating D54697: [llvm-objdump] Add Version References dumper (PR30241)

Nov 21 2018, 1:38 AM
Higuoxing updated the diff for D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).

Updating D54697: [llvm-objdump] Add Version References dumper (PR30241)
Partially refactored some codes

Nov 21 2018, 1:36 AM

Nov 20 2018

Higuoxing added a comment to D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).

Could you add tests for the cases where a) there is no DT_VERNEEDNUM tag, and b) where it has a value of 0, please.

Sure, I will add them

Nov 20 2018, 3:56 AM
Higuoxing updated the diff for D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).

Updating D54697: [llvm-objdump] Add Version References dumper (PR30241)

Nov 20 2018, 2:18 AM

Nov 19 2018

Higuoxing updated the diff for D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).

Updating D54697: [llvm-objdump] Add Version References dumper (PR30241)

Nov 19 2018, 5:20 PM
Higuoxing added inline comments to D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).
Nov 19 2018, 7:00 AM
Higuoxing updated the diff for D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).

[llvm-objdump] Add Version References dumper (PR30241)

Nov 19 2018, 6:51 AM
Higuoxing created D54697: [llvm-objdump] Add `Version References` dumper (WIP) (PR30241).
Nov 19 2018, 4:34 AM

Nov 17 2018

Higuoxing added inline comments to D54674: [llvm-objcopy] First bits for MachO .
Nov 17 2018, 10:28 PM
Higuoxing added a comment to D54665: [llvm-objdump] Print a blank row at the end of sections.

I'm implementing the Version Reference for #30241 and find that some info emitted from option -x are crowded. If this not ok, I will revert this change.

Nov 17 2018, 3:35 AM
Higuoxing committed rL347135: [llvm-objdump] Print a blank row at the end of sections.
[llvm-objdump] Print a blank row at the end of sections
Nov 17 2018, 12:15 AM
Higuoxing closed D54665: [llvm-objdump] Print a blank row at the end of sections.
Nov 17 2018, 12:15 AM
Higuoxing accepted D54665: [llvm-objdump] Print a blank row at the end of sections.
Nov 17 2018, 12:14 AM
Higuoxing created D54665: [llvm-objdump] Print a blank row at the end of sections.
Nov 17 2018, 12:14 AM

Nov 15 2018

Higuoxing added a comment to D54575: [llvm-objdump] Replace cast<> by dyn_cast<>.

Seems there are some legacy codes, like:

Nov 15 2018, 5:12 AM
Higuoxing abandoned D54575: [llvm-objdump] Replace cast<> by dyn_cast<>.
Nov 15 2018, 5:10 AM
Higuoxing created D54575: [llvm-objdump] Replace cast<> by dyn_cast<>.
Nov 15 2018, 5:05 AM
Higuoxing committed rL346946: [llvm-objdump] Use `auto` declaration in typecasting.
[llvm-objdump] Use `auto` declaration in typecasting
Nov 15 2018, 3:54 AM
Higuoxing closed D54573: [llvm-objdump] Use `auto` declaration in typecasting.
Nov 15 2018, 3:53 AM
Higuoxing added inline comments to D54509: [llvm-objdump] Improve ELF file type checking statements.
Nov 15 2018, 3:40 AM
Higuoxing created D54573: [llvm-objdump] Use `auto` declaration in typecasting.
Nov 15 2018, 3:29 AM

Nov 14 2018

Higuoxing committed rL346924: [commit-test] Add blank line for test/tools/llvm-objdump/symbol-table-elf.test.
[commit-test] Add blank line for test/tools/llvm-objdump/symbol-table-elf.test
Nov 14 2018, 6:39 PM
Higuoxing closed D54562: [commit-test] Add blank line for test/tools/llvm-objdump/symbol-table-elf.test.
Nov 14 2018, 6:39 PM
Higuoxing accepted D54562: [commit-test] Add blank line for test/tools/llvm-objdump/symbol-table-elf.test.
Nov 14 2018, 6:38 PM
Higuoxing created D54562: [commit-test] Add blank line for test/tools/llvm-objdump/symbol-table-elf.test.
Nov 14 2018, 6:37 PM
Higuoxing added inline comments to D54509: [llvm-objdump] Improve ELF file type checking statements.
Nov 14 2018, 5:44 PM
Higuoxing abandoned D54520: [llvm-objdump] Using consistent arguments name.
Nov 14 2018, 5:49 AM
Higuoxing added a comment to D54520: [llvm-objdump] Using consistent arguments name.

If anything, the header should be updated to use "Obj" for one or two of the other cases. "o" does not fit LLVM's current coding standards, and also does not match the name used in the .cpp file (see ELFDump.cpp).

Nov 14 2018, 4:53 AM
Higuoxing added a comment to D54509: [llvm-objdump] Improve ELF file type checking statements.

Just as a tip, don't forget to put the Differential Revision field in your commit message. Then, when you commit it, the commit will automatically get associated with Phabricator, and you don't need to do anything manually, like close the revision or update the final diff. There are some instructions here: https://llvm.org/docs/Phabricator.html#committing-a-change. Also, take a look at commits made by various other people as well based on Phabricator reviews.

Nov 14 2018, 4:37 AM
Higuoxing updated the summary of D54520: [llvm-objdump] Using consistent arguments name.
Nov 14 2018, 3:55 AM
Higuoxing created D54520: [llvm-objdump] Using consistent arguments name.
Nov 14 2018, 3:53 AM
Higuoxing accepted D54509: [llvm-objdump] Improve ELF file type checking statements.
Nov 14 2018, 3:35 AM
Higuoxing closed D54509: [llvm-objdump] Improve ELF file type checking statements.
Nov 14 2018, 3:35 AM
Higuoxing committed rL346851: [llvm-objdump] Improve ELF file type checking statements (D54509).
[llvm-objdump] Improve ELF file type checking statements (D54509)
Nov 14 2018, 3:33 AM
Higuoxing added a comment to D54509: [llvm-objdump] Improve ELF file type checking statements.

LGTM. Do you need it committing? You've probably had enough commits by now that you could probably request commit access, if you want.

Nov 14 2018, 3:31 AM