Page MenuHomePhabricator

Higuoxing (Xing)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2018, 6:21 AM (61 w, 6 d)

Recent Activity

Today

Higuoxing committed rGea16be1ca7e4: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU… (authored by Higuoxing).
[llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU…
Mon, Mar 25, 4:03 AM
Higuoxing committed rL356881: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU….
[llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU…
Mon, Mar 25, 4:03 AM
Higuoxing closed D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.
Mon, Mar 25, 4:02 AM · Restricted Project
Higuoxing added a comment to D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

LGTM.

Mon, Mar 25, 4:02 AM · Restricted Project
Higuoxing added inline comments to D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.
Mon, Mar 25, 3:55 AM · Restricted Project
Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

.

Mon, Mar 25, 3:49 AM · Restricted Project
Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Update diff according to comments.

Mon, Mar 25, 3:47 AM · Restricted Project
Higuoxing added inline comments to D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.
Mon, Mar 25, 3:45 AM · Restricted Project

Yesterday

Higuoxing requested review of D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.
Sun, Mar 24, 6:52 AM · Restricted Project
Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

I am sorry that this patch should be reviewed once again. I made a mistake in previous patch, which I will illustrate it below.

Sun, Mar 24, 6:47 AM · Restricted Project

Fri, Mar 22

Higuoxing added a comment to D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Oops, I made a mistake in this patch, so I reverted the change. I'm sorry.

@Higuoxing The reversion doesn't appear to have been committed

It looks like you only reverted ElfDumper.cpp at rL356777 - @dyung reverted the tests at rL356811

Fri, Mar 22, 4:44 PM · Restricted Project
Higuoxing committed rG4218d45f6581: [llvm-readobj] Revert bad changes (authored by Higuoxing).
[llvm-readobj] Revert bad changes
Fri, Mar 22, 9:22 AM
Higuoxing reopened D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Oops, I made a mistake in this patch, so I reverted the change. I'm sorry.

Fri, Mar 22, 9:21 AM · Restricted Project
Higuoxing committed rL356777: [llvm-readobj] Revert bad changes.
[llvm-readobj] Revert bad changes
Fri, Mar 22, 9:20 AM
Higuoxing committed rG94a0cffe250c: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU… (authored by Higuoxing).
[llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU…
Fri, Mar 22, 8:42 AM
Higuoxing committed rL356764: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU….
[llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU…
Fri, Mar 22, 8:41 AM
Higuoxing closed D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.
Fri, Mar 22, 8:41 AM · Restricted Project
Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Addressed comments.

Fri, Mar 22, 8:41 AM · Restricted Project

Thu, Mar 21

Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Rebase.

Thu, Mar 21, 7:50 AM · Restricted Project
Higuoxing committed rG3e9e55491e78: [llvm-readobj] Format codes. NFC. (authored by Higuoxing).
[llvm-readobj] Format codes. NFC.
Thu, Mar 21, 6:42 AM
Higuoxing committed rL356664: [llvm-readobj] Format codes. NFC..
[llvm-readobj] Format codes. NFC.
Thu, Mar 21, 6:42 AM
Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Thanks :) I will work on following patches.

Thu, Mar 21, 4:17 AM · Restricted Project
Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Addressed comments. Thanks for reviewing!

Thu, Mar 21, 3:32 AM · Restricted Project

Wed, Mar 20

Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Right, so does this patch depend on D59545 then?

No, this is the first patch, which makes way for future implementation.

Wed, Mar 20, 8:38 AM · Restricted Project
Higuoxing added a comment to D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

What's the relation between this patch and D59545?

Wed, Mar 20, 5:34 AM · Restricted Project

Tue, Mar 19

Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Addressed @rupprecht 's comments.

  • Add llvm-readelf to test cases.
Tue, Mar 19, 5:56 PM · Restricted Project
Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Addressed @jhenderson 's comments.

  • Using the actual section name.
  • Add FIXME comments near report_fatal_error() (I would like to fix this in the future).
Tue, Mar 19, 10:32 AM · Restricted Project
Higuoxing planned changes to D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`.
Tue, Mar 19, 7:58 AM · Restricted Project
Higuoxing updated the diff for D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`.

Format codes.

Tue, Mar 19, 7:52 AM · Restricted Project
Higuoxing added reviewers for D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`: jhenderson, rupprecht.
Tue, Mar 19, 7:37 AM · Restricted Project
Higuoxing created D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`.
Tue, Mar 19, 7:37 AM · Restricted Project
Higuoxing added a comment to D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

I'm always in favour of splitting up changes into multiple smaller reviews, as long as it doesn't make things more complicated by requiring temporary logic or whatever that is just going to be removed again immediately. It'll hopefully help diffing the changes too.

Tue, Mar 19, 4:45 AM · Restricted Project

Mon, Mar 18

Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Addressed @jhenderson 's comments

It may be worth factoring out this->dumper() into a local variable, since you use it in a number of places.

Done

I know this was there before, but report_fatal_error is not a good way of reporting errors, since it implies an internal bug in LLVM. It should

report a normal parse error or similar in the same way as other errors in llvm-readobj.
I would like to fix this issue here and that in LLVM style dumper

Mon, Mar 18, 8:00 PM · Restricted Project

Thu, Mar 14

Higuoxing accepted D59372: [yaml2obj]Allow explicit setting of p_filesz, p_memsz, and p_offset.

LGTM

Thu, Mar 14, 4:32 PM · Restricted Project

Tue, Mar 12

Higuoxing committed rG08dc382465d0: fix break tests after rL355922. NFCI (authored by Higuoxing).
fix break tests after rL355922. NFCI
Tue, Mar 12, 7:57 AM
Higuoxing committed rL355925: fix break tests after rL355922. NFCI.
fix break tests after rL355922. NFCI
Tue, Mar 12, 7:57 AM
Higuoxing committed rLLD355925: fix break tests after rL355922. NFCI.
fix break tests after rL355922. NFCI
Tue, Mar 12, 7:57 AM
Higuoxing added a comment to rL355922: [llvm-readobj] Print symbol version when dumping relocations (PR31564).

Seems that this patch breaks some lld test cases. I will fix them

Tue, Mar 12, 7:57 AM
Higuoxing committed rGeec3206a41e7: [llvm-readobj] Print symbol version when dumping relocations (PR31564) (authored by Higuoxing).
[llvm-readobj] Print symbol version when dumping relocations (PR31564)
Tue, Mar 12, 7:33 AM
Higuoxing committed rL355922: [llvm-readobj] Print symbol version when dumping relocations (PR31564).
[llvm-readobj] Print symbol version when dumping relocations (PR31564)
Tue, Mar 12, 7:29 AM
Higuoxing closed D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564).
Tue, Mar 12, 7:29 AM · Restricted Project
Higuoxing updated the diff for D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564).

.

Tue, Mar 12, 7:24 AM · Restricted Project
Higuoxing added a comment to D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564).

LGTM.

Tue, Mar 12, 7:20 AM · Restricted Project
Higuoxing added inline comments to D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564).
Tue, Mar 12, 7:20 AM · Restricted Project
Higuoxing updated the diff for D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564).

Addressed @jhenderson 's comments

  • Add a dynamic symbol without versioning.
Tue, Mar 12, 6:55 AM · Restricted Project
Higuoxing added inline comments to D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564).
Tue, Mar 12, 6:41 AM · Restricted Project
Higuoxing added a comment to D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

I'll leave this to James. AFAIK he will do a BoF at LLVM 2019.

Cool! I would like to watch it on Youtube ...
Thank you for taking time review this.

Tue, Mar 12, 4:56 AM · Restricted Project
Higuoxing added a comment to D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Are you definitely going to implement a GNU style after this? Otherwise, you've removed any form of support from the GNU dumper, without replacing it with something.

Tue, Mar 12, 4:42 AM · Restricted Project
Higuoxing updated the diff for D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564).

Addressed @jhenderson 's comments.

  • Use -demangle option to test that mangled name can be demangled correctly.
Tue, Mar 12, 4:35 AM · Restricted Project
Higuoxing accepted D59243: [format] \t => ' '.

LGTM :)

Tue, Mar 12, 2:28 AM · Restricted Project
Higuoxing added a comment to D59242: [typo] we we => we.

Hi, seems that this patch has been committed in rL355895

Tue, Mar 12, 1:26 AM · Restricted Project

Mon, Mar 11

Higuoxing added inline comments to D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564).
Mon, Mar 11, 6:00 AM · Restricted Project
Higuoxing updated the diff for D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564).

Addressed @grimar 's comments.

Mon, Mar 11, 5:58 AM · Restricted Project

Sun, Mar 10

Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Updating D59186: [llvm-readobj] Separate Symbol Version dumpers into LLVM style and GNU style

Sun, Mar 10, 4:33 AM · Restricted Project
Higuoxing updated the diff for D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.

Format codes.

Sun, Mar 10, 1:02 AM · Restricted Project
Higuoxing created D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`.
Sun, Mar 10, 12:54 AM · Restricted Project

Sat, Mar 9

Higuoxing created D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564).
Sat, Mar 9, 5:17 AM · Restricted Project

Fri, Mar 8

Higuoxing added inline comments to D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.
Fri, Mar 8, 3:46 AM · Restricted Project, Restricted Project
Higuoxing added inline comments to D59095: [llvm-readelf]Don't lose negative-ness of negative addends for no symbol relocations.
Fri, Mar 8, 3:08 AM · Restricted Project

Thu, Mar 7

Higuoxing accepted D59095: [llvm-readelf]Don't lose negative-ness of negative addends for no symbol relocations.

LGTM, but a small nit

Thu, Mar 7, 4:59 PM · Restricted Project
Higuoxing added a comment to D59095: [llvm-readelf]Don't lose negative-ness of negative addends for no symbol relocations.
Thu, Mar 7, 4:57 PM · Restricted Project
Higuoxing committed rGeee6226c21d7: [llvm-readobj] Dump DT_USED value as string like GNU readelf does (authored by Higuoxing).
[llvm-readobj] Dump DT_USED value as string like GNU readelf does
Thu, Mar 7, 6:53 AM
Higuoxing committed rL355600: [llvm-readobj] Dump DT_USED value as string like GNU readelf does.
[llvm-readobj] Dump DT_USED value as string like GNU readelf does
Thu, Mar 7, 6:52 AM
Higuoxing closed D59089: [llvm-readobj] Dump DT_USED value as string like GNU readelf does.
Thu, Mar 7, 6:52 AM · Restricted Project
Higuoxing updated the diff for D59089: [llvm-readobj] Dump DT_USED value as string like GNU readelf does.

Addressed @jhenderson 's comments

Thu, Mar 7, 4:54 AM · Restricted Project
Higuoxing created D59089: [llvm-readobj] Dump DT_USED value as string like GNU readelf does.
Thu, Mar 7, 3:53 AM · Restricted Project

Tue, Mar 5

Higuoxing committed rGdd440675cf7c: [BinaryFormat] Add DT_USED tag into dynamic section. (authored by Higuoxing).
[BinaryFormat] Add DT_USED tag into dynamic section.
Tue, Mar 5, 5:28 PM
Higuoxing committed rL355468: [BinaryFormat] Add DT_USED tag into dynamic section..
[BinaryFormat] Add DT_USED tag into dynamic section.
Tue, Mar 5, 5:28 PM
Higuoxing closed D58762: [BinaryFormat] Add DT_USED tag into dynamic section..
Tue, Mar 5, 5:28 PM · Restricted Project
Higuoxing added a comment to D58762: [BinaryFormat] Add DT_USED tag into dynamic section..

Sorry for the delay.

Tue, Mar 5, 4:57 AM · Restricted Project

Mon, Mar 4

Higuoxing committed rG013e17f50ef5: [ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt' (authored by Higuoxing).
[ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'
Mon, Mar 4, 7:07 PM
Higuoxing committed rL355374: [ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'.
[ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'
Mon, Mar 4, 7:07 PM
Higuoxing closed D58873: [ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'.
Mon, Mar 4, 7:07 PM · Restricted Project
Higuoxing added a comment to D58873: [ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'.

Oh, okay. LGTM.

Mon, Mar 4, 7:00 PM · Restricted Project
Higuoxing added a comment to D58873: [ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'.

I spotted this FIXME when I trying to find some typos in llvm. I don't know if it's a deliberate typo to skip CHECK, because the encoding is a valid arm instruction.

Mon, Mar 4, 6:56 PM · Restricted Project
Higuoxing added a comment to D58873: [ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'.

Oh, I see, you changed the instruction bytes for the test.

Are you planning to fix the decoding for "dbg" instructions? If not, is there a bug filed?

Mon, Mar 4, 6:51 PM · Restricted Project
Higuoxing added a comment to D58873: [ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'.

Maybe leave the FIXME if the current decoding is wrong?

Mon, Mar 4, 6:13 PM · Restricted Project

Sat, Mar 2

Higuoxing updated the diff for D58873: [ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'.

Add CHECK-NEXT

Sat, Mar 2, 5:02 AM · Restricted Project
Higuoxing created D58873: [ARM][MC] Update one test case in 'test/MC/Disassembler/ARM/invalid-armv7.txt'.
Sat, Mar 2, 4:59 AM · Restricted Project
Higuoxing committed rG23b1dfe675cb: [Transforms] fix typo in test case. NFC. (authored by Higuoxing).
[Transforms] fix typo in test case. NFC.
Sat, Mar 2, 12:32 AM
Higuoxing committed rL355265: [Transforms] fix typo in test case. NFC..
[Transforms] fix typo in test case. NFC.
Sat, Mar 2, 12:31 AM
Higuoxing abandoned D58865: [AMDGPU][Codegen] fix typos in test file.
Sat, Mar 2, 12:05 AM · Restricted Project
Higuoxing abandoned D58867: [AArch64][Codegen] fix typos in test file.
Sat, Mar 2, 12:05 AM · Restricted Project
Higuoxing abandoned D58868: [NVPTX][Codegen] fix typos in test file.

I think such typo fixes can be done in batch and you do not need to ask for reviews..

Oh, I am just afraid this may cause some bots failed. I will commit them. Thanks a lot!

You can test it locally before committing..

Sat, Mar 2, 12:05 AM · Restricted Project
Higuoxing committed rG33649349c552: [Codegen] fix typos in test case (authored by Higuoxing).
[Codegen] fix typos in test case
Sat, Mar 2, 12:04 AM
Higuoxing committed rL355264: [Codegen] fix typos in test case.
[Codegen] fix typos in test case
Sat, Mar 2, 12:03 AM

Fri, Mar 1

Higuoxing added a comment to D58868: [NVPTX][Codegen] fix typos in test file.

I think such typo fixes can be done in batch and you do not need to ask for reviews..

Fri, Mar 1, 11:53 PM · Restricted Project
Higuoxing created D58868: [NVPTX][Codegen] fix typos in test file.
Fri, Mar 1, 10:46 PM · Restricted Project
Higuoxing created D58867: [AArch64][Codegen] fix typos in test file.
Fri, Mar 1, 10:41 PM · Restricted Project
Higuoxing added a reviewer for D58865: [AMDGPU][Codegen] fix typos in test file: sheredom.
Fri, Mar 1, 10:36 PM · Restricted Project
Higuoxing created D58865: [AMDGPU][Codegen] fix typos in test file.
Fri, Mar 1, 10:31 PM · Restricted Project
Higuoxing committed rGb28587890761: [llvm-objdump] Should print unknown d_tag in hex format (authored by Higuoxing).
[llvm-objdump] Should print unknown d_tag in hex format
Fri, Mar 1, 8:22 PM
Higuoxing committed rL355262: [llvm-objdump] Should print unknown d_tag in hex format.
[llvm-objdump] Should print unknown d_tag in hex format
Fri, Mar 1, 8:22 PM
Higuoxing closed D58763: [llvm-objdump] Should print unknown d_tag in hex format.
Fri, Mar 1, 8:22 PM · Restricted Project
Higuoxing updated the diff for D58763: [llvm-objdump] Should print unknown d_tag in hex format.

Addressed @jhenderson 's comment

Fri, Mar 1, 8:18 PM · Restricted Project

Thu, Feb 28

Higuoxing updated the diff for D58763: [llvm-objdump] Should print unknown d_tag in hex format.

Addressed @jhenderson 's comment

Thu, Feb 28, 11:14 PM · Restricted Project
Higuoxing accepted D58771: [llvm-readobj]Add test showing behaviour of thin archive member path printing.

LGTM :)

Thu, Feb 28, 3:32 AM · Restricted Project
Higuoxing updated the diff for D58762: [BinaryFormat] Add DT_USED tag into dynamic section..

Address @grimar 's comment.

Thu, Feb 28, 12:25 AM · Restricted Project
Higuoxing added inline comments to D58763: [llvm-objdump] Should print unknown d_tag in hex format.
Thu, Feb 28, 12:10 AM · Restricted Project

Wed, Feb 27

Higuoxing created D58763: [llvm-objdump] Should print unknown d_tag in hex format.
Wed, Feb 27, 11:51 PM · Restricted Project