Page MenuHomePhabricator

cmtice (Caroline Tice)
User

Projects

User does not belong to any projects.

User Details

User Since
May 3 2018, 11:15 AM (80 w, 6 d)

Recent Activity

Thu, Nov 7

cmtice updated the diff for D69822: [clang] Add new -fdebug-default-version flag..

Fix small typo in comments.

Thu, Nov 7, 8:00 AM · Restricted Project

Wed, Nov 6

cmtice updated the diff for D69822: [clang] Add new -fdebug-default-version flag..

Remove quotes from -NOT tests.

Wed, Nov 6, 2:20 PM · Restricted Project
cmtice updated the diff for D69822: [clang] Add new -fdebug-default-version flag..

Fix NODEBUGINFO-NOT test.

Wed, Nov 6, 1:24 PM · Restricted Project
cmtice updated the diff for D69822: [clang] Add new -fdebug-default-version flag..

Remove period from help text. Fix tests.

Wed, Nov 6, 12:02 PM · Restricted Project

Tue, Nov 5

cmtice updated the diff for D69822: [clang] Add new -fdebug-default-version flag..

Rename flag to -fdebug-default-version; add help text, mentioning DWARF. Update tests to use -### and add assembler tests.

Tue, Nov 5, 3:51 PM · Restricted Project
cmtice added a comment to D69822: [clang] Add new -fdebug-default-version flag..

Yes, I will change the flag name back to debug-default-version, and add help text mentioning dwarf. I'm in the process of trying to re-do the test cases as required (I'm a bit new to this so it's taking me a bit to figure this out).

Tue, Nov 5, 2:29 PM · Restricted Project
cmtice updated the diff for D69822: [clang] Add new -fdebug-default-version flag..

Make second call to ParseDwarfDefaultVersion unconditional (to match the first and avoid errors with -Werror).

Tue, Nov 5, 1:06 PM · Restricted Project
cmtice added a comment to D69822: [clang] Add new -fdebug-default-version flag..

For the record, I double-checked and if we use the flag and don't check for it (i.e. if we move the parsing inside the EmitDwarf is True block) then -Werror does indeed complain about an unused command line argument.

Tue, Nov 5, 12:57 PM · Restricted Project
cmtice added a comment to D69822: [clang] Add new -fdebug-default-version flag..

dblaikie: The code, as written, parses the dwarf default version flag, whether or not DWARFVersion is 0, i.e. whether or not a -gdwarf-N flag was passed. It only USES the value if there's no overriding value.

Tue, Nov 5, 12:29 PM · Restricted Project
cmtice updated the diff for D69822: [clang] Add new -fdebug-default-version flag..

re-try upload again.

Tue, Nov 5, 11:52 AM · Restricted Project
cmtice added a comment to D69822: [clang] Add new -fdebug-default-version flag..

Ok, I think the upload was correct this time.

Tue, Nov 5, 11:52 AM · Restricted Project
cmtice added a comment to D69822: [clang] Add new -fdebug-default-version flag..

Hmmm...I'm having upload issues.

Tue, Nov 5, 11:52 AM · Restricted Project
cmtice updated the diff for D69822: [clang] Add new -fdebug-default-version flag..

Try uploading correct diff file?

Tue, Nov 5, 11:52 AM · Restricted Project
cmtice updated the diff for D69822: [clang] Add new -fdebug-default-version flag..

Made requested changes:

  • renamed option to be dwarf-specific
  • fixed spelling & blank line issues
  • only set version if emit-dwarf is true
  • move test to Driver directory
Tue, Nov 5, 10:10 AM · Restricted Project

Mon, Nov 4

cmtice updated the summary of D69822: [clang] Add new -fdebug-default-version flag..
Mon, Nov 4, 3:21 PM · Restricted Project
cmtice updated the diff for D69822: [clang] Add new -fdebug-default-version flag..

Made requested formatting changes.

Mon, Nov 4, 1:58 PM · Restricted Project
cmtice added inline comments to D69822: [clang] Add new -fdebug-default-version flag..
Mon, Nov 4, 1:40 PM · Restricted Project
cmtice created D69822: [clang] Add new -fdebug-default-version flag..
Mon, Nov 4, 1:19 PM · Restricted Project

Jun 5 2019

cmtice added a comment to D54348: Permit multiple .file directives with -g.

Ping? Is anybody looking at or working on this? The bug this fixes is one of the issues currently blocking Chrome OS from being able to adopt Dwarf v5, so we are hoping for a fix?

Hmm, apologies. I will take a look tomorrow to try and pick this back up. But unfortunately I'll be away on vacation after tomorrow and it may not be addressed soon. Is Dwarfv5 for ChromeOS bound to a particular llvm release or release date?

Jun 5 2019, 4:45 PM · Restricted Project, debug-info
Herald added a project to D54348: Permit multiple .file directives with -g: Restricted Project.

Ping? Is anybody looking at or working on this? The bug this fixes is one of the issues currently blocking Chrome OS from being able to adopt Dwarf v5, so we are hoping for a fix?

Jun 5 2019, 4:06 PM · Restricted Project, debug-info

May 13 2019

cmtice closed D61755: llvm-dwarfdump: Add dwo parsing to --statistics..

Committed in r360380.

May 13 2019, 10:08 AM · Restricted Project

May 9 2019

cmtice committed rGabf25745b339: llvm-dwarfdump: Add dwo parsing to --statistics. (authored by cmtice).
llvm-dwarfdump: Add dwo parsing to --statistics.
May 9 2019, 2:52 PM
cmtice created D61755: llvm-dwarfdump: Add dwo parsing to --statistics..
May 9 2019, 1:13 PM · Restricted Project

Apr 1 2019

cmtice committed rG2a67c910764b: Commit accidentally omitted test case. (authored by cmtice).
Commit accidentally omitted test case.
Apr 1 2019, 9:30 AM
cmtice added a comment to D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169).

Test case has been committed, as of revision 357409.

Apr 1 2019, 9:30 AM · Restricted Project

Mar 1 2019

cmtice committed rGbcdb1f3d04ae: llvm-dwarfdump: Add new variable, parameter and inlining statistics; also… (authored by cmtice).
llvm-dwarfdump: Add new variable, parameter and inlining statistics; also…
Mar 1 2019, 3:51 PM
cmtice updated the diff for D58849: llvm-dwarfdump: Add new variable, parameter and inlining statistics; also function source location statistics..

Ran clang-format on Statistics.cpp

Mar 1 2019, 3:09 PM · Restricted Project
cmtice created D58849: llvm-dwarfdump: Add new variable, parameter and inlining statistics; also function source location statistics..
Mar 1 2019, 2:13 PM · Restricted Project

Feb 7 2019

cmtice committed rGcef4c294170d: lvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions"… (authored by cmtice).
lvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions"…
Feb 7 2019, 4:52 PM
cmtice added a comment to D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic..

It appears to me that on line 131 we are already adding/counting the ConstantMembers in FnStats.VarsInFunction, so adding "+ Constants" would be counting them twice. Alternatively we can change the code on line 131 to not include ConstantMembers...

Feb 7 2019, 4:33 PM · Restricted Project
cmtice updated the diff for D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic..

I was mistaken before: we were never counting the template parameters. What was happening was that we were counting the variables in both inlined instances, and we were also counting the variables for a concrete, out-of-line instance of the inlined function, even though in this particular case there was no concrete out-of-line instance. I have updated the patch now to only count vars in DW_TAG_subprogram DIEs if the subprogram DIE has PC addresses. I believe this is the correct fix for this issue.

Feb 7 2019, 4:10 PM · Restricted Project
cmtice updated the diff for D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic..

This increases the version number, as requested.

Feb 7 2019, 11:02 AM · Restricted Project
cmtice added inline comments to D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic..
Feb 7 2019, 10:56 AM · Restricted Project
cmtice updated the diff for D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic..

Now we correctly count only real constant members as "constant members" and we count global variables with locations as part of the "vars with locs".

Feb 7 2019, 10:07 AM · Restricted Project
cmtice updated the diff for D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic..

aprantl@, you were right, my original change was not correctly updating the variable counts to include variables occuring in inlined instances of functions. I have update the patch to fix this issue. There were two additional changes needed: one to make sure we were counting variables for functions that had no inlined instances at all; and one to avoid double-counting member constants.

Feb 7 2019, 9:08 AM · Restricted Project

Feb 6 2019

cmtice created D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic..
Feb 6 2019, 2:41 PM · Restricted Project

Sep 21 2018

cmtice created D52383: Fix codemodels.c test case (only test mcmodel-kernel on x86).
Sep 21 2018, 4:03 PM
cmtice updated the diff for D52322: Pass code-model through Module IR to LTO which will use is.

Use Conf.CodeModel in LTO, if it exists.

Sep 21 2018, 10:37 AM
cmtice updated the diff for D52322: Pass code-model through Module IR to LTO which will use is.

Add comment explaining why mixing two code models is an error. Add missing Inputs/codemodel-3.ll file.

Sep 21 2018, 9:46 AM
cmtice updated the diff for D52323: Add necessary support for storing code-model to module IR..

Move include statement from CodeGenModule.h to CodeGenModule.cpp
Remove incorrect "default" case statement.
Add test for "tiny" code model.

Sep 21 2018, 9:39 AM
cmtice added inline comments to D52323: Add necessary support for storing code-model to module IR..
Sep 21 2018, 9:33 AM

Sep 20 2018

cmtice updated the summary of D52322: Pass code-model through Module IR to LTO which will use is.
Sep 20 2018, 2:20 PM
cmtice created D52323: Add necessary support for storing code-model to module IR..
Sep 20 2018, 2:19 PM
cmtice created D52322: Pass code-model through Module IR to LTO which will use is.
Sep 20 2018, 2:15 PM

Jul 20 2018

cmtice updated the diff for D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169).

Simplify test case, as requested by Peter.

Jul 20 2018, 4:34 PM · Restricted Project
cmtice updated the diff for D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169).

I just realized that my patch did not contain the actual move of RuntimeLibcalls.def from CodeGen to IR. This update includes that move.

Jul 20 2018, 2:35 PM · Restricted Project
cmtice updated the diff for D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169).

Made requested fixes.

Jul 20 2018, 11:25 AM · Restricted Project
cmtice updated the diff for D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169).

I've made Peter's suggested changes.

Jul 20 2018, 8:36 AM · Restricted Project

Jul 19 2018

cmtice updated the diff for D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169).

pcc's original suggested fix did not work, because the real issue was the function definitions being initially internalized by LTO and later DCE'd. Peter's suggestion did not prevent them from being internalized. I consulted with him offline and we came up with this alternative solution. It fixes the issue for the new LTO implemention. The old LTO implementation still internalizes the function definitions, but they do not get Dead Code Eliminated. I have also fixed the test case, and have generalized the code to check for all builtin functions (as requested).

Jul 19 2018, 2:51 PM · Restricted Project

Jul 17 2018

cmtice added a comment to D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169).

pcc@ Originally I tried to make the change in ModuleSummaryAnalysis.cpp, but it turns out that this is not allowed in LLVM: I am not supposed to make changes to the IR in the Analysis layer of LLVM. I need to find some place in the Transform layer to make the change. Hence my first guess as to a location: GlobalOpt.cpp. I would be happy to make the change in some other location instead, but it must be someplace in the Transform layer.

Jul 17 2018, 11:41 AM · Restricted Project
cmtice updated the summary of D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169).
Jul 17 2018, 10:27 AM · Restricted Project
cmtice updated subscribers of D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169).
Jul 17 2018, 10:26 AM · Restricted Project
cmtice created D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169).
Jul 17 2018, 10:20 AM · Restricted Project

May 7 2018

cmtice updated the diff for D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..

Make cfi_blacklist.txt be an empty file.

May 7 2018, 1:47 PM
cmtice updated the diff for D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..

Make -resource-dir point to correct directory, in test case; move cfi_blacklist.txt file to 'share' subdirectory in test resource dir.

May 7 2018, 1:40 PM
cmtice added a comment to D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..

I'm not sure if I have commit access or not; Peter was working with me on trying to commit the change.

May 7 2018, 1:22 PM
cmtice updated the diff for D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..

Fix test failure that my previous changes caused.

May 7 2018, 1:17 PM

May 4 2018

cmtice added a comment to D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..

vsk: Are you asking me to put together a cfi blacklist to ship in the resource directory in the default install as part of this code review? Or is that something you want to see in a different code reivew?

May 4 2018, 4:45 PM
cmtice updated the diff for D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..

Added comment to change in source code.

May 4 2018, 1:30 PM
cmtice updated the diff for D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..

Updated the error to only occur for CFI blacklist, and added test case.

May 4 2018, 11:47 AM

May 3 2018

cmtice added a comment to D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..

Ok, I'll work on making this CFI-specific and adding a test case.

May 3 2018, 12:44 PM
cmtice updated the diff for D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..

Tried to upload the diff from the correct location.

May 3 2018, 12:42 PM
cmtice created D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..
May 3 2018, 12:20 PM