Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

cmtice (Caroline Tice)
User

Projects

User Details

User Since
May 3 2018, 11:15 AM (282 w, 1 d)

Recent Activity

Jul 10 2023

cmtice committed rG3885ceafa934: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (authored by cmtice).
[LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate
Jul 10 2023, 7:48 PM · Restricted Project
cmtice closed D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt).
Jul 10 2023, 7:48 PM · Unknown Object (Project), Restricted Project
cmtice added a comment to D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt).

Thanks Jason. I think the compiler is generating some bad DWARF. David Blaikie was investigating that on our end, but he's on vacation this week.

Jul 10 2023, 7:45 PM · Unknown Object (Project), Restricted Project
cmtice updated the summary of D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt).
Jul 10 2023, 5:04 PM · Unknown Object (Project), Restricted Project
cmtice updated the summary of D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt).
Jul 10 2023, 4:58 PM · Unknown Object (Project), Restricted Project
cmtice requested review of D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt).
Jul 10 2023, 4:52 PM · Unknown Object (Project), Restricted Project
cmtice added a reverting change for rGee476996bec7: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.: rG5f6c55836fb4: Revert "[LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.".
Jul 10 2023, 4:39 PM · Restricted Project
cmtice committed rG5f6c55836fb4: Revert "[LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate." (authored by cmtice).
Revert "[LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate."
Jul 10 2023, 4:39 PM · Restricted Project
cmtice added a reverting change for D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.: rG5f6c55836fb4: Revert "[LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.".
Jul 10 2023, 4:38 PM · Unknown Object (Project), Restricted Project

Jul 5 2023

cmtice added a comment to D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate..

Hi Jason,

Jul 5 2023, 9:39 AM · Unknown Object (Project), Restricted Project

Jun 28 2023

cmtice added a comment to D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate..

I updated the version that I committed to use 'sizeof' as recommended.

Jun 28 2023, 11:49 AM · Unknown Object (Project), Restricted Project
cmtice committed rGee476996bec7: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate. (authored by cmtice).
[LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.
Jun 28 2023, 11:49 AM · Restricted Project
cmtice closed D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate..
Jun 28 2023, 11:48 AM · Unknown Object (Project), Restricted Project

Jun 27 2023

cmtice requested review of D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate..
Jun 27 2023, 12:36 AM · Unknown Object (Project), Restricted Project

May 6 2023

cmtice committed rG123f939c14f7: [lldb] Fix language label in ObjC Language unittest (authored by cmtice).
[lldb] Fix language label in ObjC Language unittest
May 6 2023, 12:30 PM · Restricted Project
cmtice closed D150019: [lldb] Fix language label in ObjC Language unittest.
May 6 2023, 12:30 PM · Unknown Object (Project), Restricted Project
cmtice added reviewers for D150019: [lldb] Fix language label in ObjC Language unittest: JDevlieghere, bulbazord, jingham.
May 6 2023, 12:04 AM · Unknown Object (Project), Restricted Project
cmtice requested review of D150019: [lldb] Fix language label in ObjC Language unittest.
May 6 2023, 12:02 AM · Unknown Object (Project), Restricted Project

May 5 2023

cmtice added a reverting change for rG0a532207b869: Give NullabilityKind a printing operator<<: rG5326c9e480d7: Revert "Give NullabilityKind a printing operator<<".
May 5 2023, 11:41 PM · Restricted Project, Restricted Project
cmtice committed rG5326c9e480d7: Revert "Give NullabilityKind a printing operator<<" (authored by cmtice).
Revert "Give NullabilityKind a printing operator<<"
May 5 2023, 11:41 PM · Restricted Project, Restricted Project
cmtice added a reverting change for D149650: Give NullabilityKind a printing operator<<: rG5326c9e480d7: Revert "Give NullabilityKind a printing operator<<".
May 5 2023, 11:41 PM · Restricted Project, Restricted Project
cmtice added a comment to D149650: Give NullabilityKind a printing operator<<.

This is breaking some of our tests. I will give the author a reproducible test case. I am going to revert this while waiting for a fix.

May 5 2023, 11:30 PM · Restricted Project, Restricted Project
cmtice added a comment to D149940: [ValueTracking][NFC] Split off computeKnownBitsFromCmp from computeKnownBitsFromAssume.

Never mind; I seem to have gotten a bad download. Please forgive the noise.

May 5 2023, 2:08 PM · Restricted Project, Restricted Project
cmtice added a comment to D149940: [ValueTracking][NFC] Split off computeKnownBitsFromCmp from computeKnownBitsFromAssume.

This change causes build failures for builds that eliminate asserts:

May 5 2023, 1:14 PM · Restricted Project, Restricted Project

May 1 2023

cmtice added a comment to D149423: [ValueTracking] Use knownbits interface for determining if `div`/`rem` are safe to speculate.

Yes, you're updated patch seems to have fixed my problem :-)

May 1 2023, 1:17 PM · Restricted Project, Restricted Project
cmtice added a comment to D149423: [ValueTracking] Use knownbits interface for determining if `div`/`rem` are safe to speculate.

Just a heads up: This commit appears to be breaking one of our tests. I'll see if I can get a reproducible test case. Would you consider reverting this in the meantime?

May 1 2023, 11:12 AM · Restricted Project, Restricted Project

Apr 29 2023

cmtice added a comment to D149397: Host: generalise `GetXcodeSDKPath`.

I'm seeing the same build failures reported by mgorny. Would you consider reverting this patch until you can fix it?

Apr 29 2023, 1:32 PM · Restricted Project, Unknown Object (Project)

Apr 13 2023

cmtice committed rGbe58b42a7510: [lldb] Add 'CHECK' to class-type-nullptr-deref.s test. (authored by cmtice).
[lldb] Add 'CHECK' to class-type-nullptr-deref.s test.
Apr 13 2023, 8:19 AM · Restricted Project
cmtice closed D148151: [lldb] Add 'CHECK' to class-type-nullptr-deref.s test..
Apr 13 2023, 8:19 AM · Unknown Object (Project), Restricted Project

Apr 12 2023

cmtice requested review of D148151: [lldb] Add 'CHECK' to class-type-nullptr-deref.s test..
Apr 12 2023, 11:25 AM · Unknown Object (Project), Restricted Project

Apr 11 2023

cmtice committed rG1fa26e64fd87: [PATCH][lldb] Fix dereference of null pointer. (authored by cmtice).
[PATCH][lldb] Fix dereference of null pointer.
Apr 11 2023, 1:42 PM · Restricted Project
cmtice added a comment to D147973: [LLDB] Fix null pointer dereference in DWARFASTParserClang::ParsePointerToMemberType.

I've added the test, as requested. Since this has been approved, I'll go ahead and commit it now.

Apr 11 2023, 1:40 PM · Restricted Project
cmtice updated the diff for D147973: [LLDB] Fix null pointer dereference in DWARFASTParserClang::ParsePointerToMemberType.
Apr 11 2023, 1:39 PM · Restricted Project

Apr 10 2023

cmtice requested review of D147973: [LLDB] Fix null pointer dereference in DWARFASTParserClang::ParsePointerToMemberType.
Apr 10 2023, 3:01 PM · Restricted Project

Feb 23 2023

cmtice added a reverting change for D144484: [Tooling/Inclusion] Handle std::get symbol.: rG7c9b15fbaeb2: Revert "[Tooling/Inclusion] Handle std::get symbol.".
Feb 23 2023, 3:20 PM · Restricted Project, Restricted Project, Restricted Project
cmtice added a reverting change for rGcbcb3eef70de: [Tooling/Inclusion] Handle std::get symbol.: rG7c9b15fbaeb2: Revert "[Tooling/Inclusion] Handle std::get symbol.".
Feb 23 2023, 3:19 PM · Restricted Project, Restricted Project, Restricted Project
cmtice committed rG7c9b15fbaeb2: Revert "[Tooling/Inclusion] Handle std::get symbol." (authored by cmtice).
Revert "[Tooling/Inclusion] Handle std::get symbol."
Feb 23 2023, 3:19 PM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

cmtice added a comment to D140985: [IR] Support importing modules with invalid data layouts..

Just a heads up: It looks like this change is causing many of our internal tests to fail. I'm working on trying to create a reproducer for you.

Jan 12 2023, 9:31 PM · Restricted Project, Restricted Project

Jan 11 2023

cmtice added a comment to D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading.

Just a heads up: This commit is causing our bootstrap build to fail (your new openmp-system-arch.c test is failing in our stage1 compiler).

Jan 11 2023, 10:24 PM · Restricted Project, Restricted Project
cmtice committed rGbdcba89356f8: [Bazel] Fix typo (missing comma) in previous commit. (authored by cmtice).
[Bazel] Fix typo (missing comma) in previous commit.
Jan 11 2023, 11:15 AM · Restricted Project
cmtice committed rGb4477dd8c5d1: [Bazel] Add //llvm:TargetParser depenendency to clang driver for… (authored by cmtice).
[Bazel] Add //llvm:TargetParser depenendency to clang driver for…
Jan 11 2023, 11:10 AM · Restricted Project

Jan 9 2023

cmtice added a comment to D138132: [JumpThreading] Preserve profile metadata during select unfolding.

Never mind; I just noticed that https://github.com/llvm/llvm-project/commit/230dba0ad30e826407e783d19234c8b9d3373e2a fixes this issue.

Jan 9 2023, 9:31 PM · Restricted Project, Restricted Project
cmtice added a comment to D138132: [JumpThreading] Preserve profile metadata during select unfolding.

This commit breaks the test llvm/test/Transforms/JumpThreading/select.ll if you build the compiler optimized I.e. with '-DCMAKE_BUILD_TYPE=Release'. I tested this by building both the version just before this commit and just after this commit with -DCMAKE_BUILD_TYPE=Release, then running the test:

Jan 9 2023, 9:20 PM · Restricted Project, Restricted Project
cmtice added a comment to D141164: [AAUnderlyingObjects] Introduce an AA for getting underlying objects of a pointer.

It still breaks asan/ubsan builds. I have committed a patch that initializes it it false. That should fix the saniziter issues, and the callees can still overwrite the value as needed.

Jan 9 2023, 4:16 PM · Restricted Project, Restricted Project
cmtice committed rG2700d0d13ac2: [AAUnderlyingObjects] Initialize an uninitialized boolean. (authored by cmtice).
[AAUnderlyingObjects] Initialize an uninitialized boolean.
Jan 9 2023, 3:47 PM · Restricted Project, Restricted Project
cmtice added a comment to D141164: [AAUnderlyingObjects] Introduce an AA for getting underlying objects of a pointer.

It appears that the actual problem is your use of an uninitialized Boolean, UsedAssumedInformation, which you declare but don't initialize on line 11231 of AttributorAttributes.cpp, then proceed to pass into other functions without initializing it first.

Jan 9 2023, 3:31 PM · Restricted Project, Restricted Project
cmtice added a comment to D141164: [AAUnderlyingObjects] Introduce an AA for getting underlying objects of a pointer.

Just a heads up: This is causing some of our clang tests to fail when run under asan/ubasn. E.g. for llvm/test/Transforms:Attributor/nosync.ll.test, we get

Jan 9 2023, 3:05 PM · Restricted Project, Restricted Project

Sep 22 2022

cmtice added a reviewer for D134505: [bazel] Remove Mips from Exegesis cc_library definition: aeubanks.
Sep 22 2022, 5:34 PM · Restricted Project, Restricted Project
cmtice requested review of D134505: [bazel] Remove Mips from Exegesis cc_library definition.
Sep 22 2022, 5:33 PM · Restricted Project, Restricted Project

Sep 20 2022

cmtice added a comment to D130105: [NFC][AMDGPU] Refactor AMDGPUDisassembler.

This commit appears to be causing our bootstrap builds to fail, while running these tests. The error we get for kd-vgpr.s is
[ 5] ;--- 1.s
[ 6] ; RUN: %assemble -mcpu=gfx908 <1.s >1.o [FAIL]
%assemble -mcpu=gfx908 <1.s >1.o
bash: line 0: fg: no job control
Command failed: exit status 1

Sep 20 2022, 9:45 PM · Restricted Project, Restricted Project
cmtice accepted D134301: [MLIR] Update bazel build files after 242d558658cd5a480b02883e2982d7246342e0d0.
Sep 20 2022, 12:19 PM · Restricted Project, Restricted Project

Jun 24 2022

cmtice added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

I did some testing and verified that this commit is causing some of the Sanitizer issues we are seeing. Is there any chance of a revert?

Jun 24 2022, 4:40 PM · Restricted Project, Restricted Project
cmtice added a comment to D128152: [lldb] [llgs] Support multiprocess in qfThreadInfo.

Just FYI, this commit appears to cause lldb//test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py to fail. The error I'm seeing is:

Jun 24 2022, 12:48 PM · Unknown Object (Project), Restricted Project
cmtice added a comment to D127702: Support logpoints in lldb-vscode.

I apologize; I was looking at several commits, and I accidentally added my comment to the wrong one. No, this commit is not the one that caused my problem (I am very sorry about the confusion).

Jun 24 2022, 12:47 PM · Restricted Project, Unknown Object (Project)
cmtice added a comment to D127702: Support logpoints in lldb-vscode.

Just FYI, this commit appears to cause lldb//test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py to fail. The error I'm seeing is:

Jun 24 2022, 12:29 PM · Restricted Project, Unknown Object (Project)

Jun 23 2022

cmtice added a comment to D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

Ignore my revert request; Your later commit seems to have fixed most of my issues.

Jun 23 2022, 4:17 PM · Unknown Object (Project), Restricted Project
cmtice added a comment to D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

This appears to have broken a lot of LLDB tests in our bootstrap as well. Is there any chance this might get reverted?

Jun 23 2022, 3:58 PM · Unknown Object (Project), Restricted Project

Jun 22 2022

cmtice added a comment to D124346: [libc++] Complete the implementation of N4190.

@philnik Ah, thanks for pointing that out. Ignore my previous comment. :-)

Jun 22 2022, 9:45 AM · Restricted Project, Restricted Project
cmtice added a comment to D124346: [libc++] Complete the implementation of N4190.

Just a heads up, this looks like it may have broken compiler-rt builds. I'm seeing errors like:
ERROR: third_party/stl/BUILD:57:11: Compiling third_party/stl/stl.cppmap failed: (Exit 1) wrapped_clang failed: error executing command (from target third_party/stl:stl) third_party/crosstool/v18/llvm_unstable/toolchain/bin/wrapped_clang '-frandom-seed=blaze-out/k8-opt/bin/third_party/stl/_objs/stl/stl.pcm' -iquote . -iquote blaze-out/k8-opt/genfiles -iquote ... (remaining 224 arguments skipped). [forge_remote_host=lmdw19]
While building module '
third_party/stl:stl':
In file included from <module-includes>:43:
./third_party/stl/cxx17/ext/functional:17:24: error: no template named 'unary_function' in namespace 'std'; did you mean '__unary_function'?
struct identity : std::unary_function<T, T> {

~~~~~^~~~~~~~~~~~~~
     __unary_function

third_party/crosstool/v18/llvm_unstable/toolchain/bin/../include/c++/v1/__functional/unary_function.h:46:1: note: 'unary_function' declared here
using
unary_function = unary_function_keep_layout_base<_Arg, _Result>;
^
While building module '//third_party/stl:stl':
In file included from <module-includes>:43:
./third_party/stl/cxx17/ext/functional:22:25: error: no template named 'unary_function' in namespace 'std'; did you mean '
unary_function'?
struct select1st : std::unary_function<Pair, typename Pair::first_type> {

~~~~~^~~~~~~~~~~~~~
     __unary_function

third_party/crosstool/v18/llvm_unstable/toolchain/bin/../include/c++/v1/__functional/unary_function.h:46:1: note: 'unary_function' declared here
using
unary_function = __unary_function_keep_layout_base<_Arg, _Result>;

Jun 22 2022, 7:34 AM · Restricted Project, Restricted Project

Feb 5 2022

cmtice added a comment to D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`.

When building/running third_party/llvm/llvm-project/clang/test/OpenMP/atomic_messages.c and third_party/llvm/llvm-project/clang/test/OpenMP/atomic_ast_print.cpp, we get use-of-uninitialized-variable error messages:

Feb 5 2022, 12:11 AM · Restricted Project

Feb 4 2022

cmtice abandoned D119037: Fix target dependencies for libtool in Bazel build files..

Never mind; someone beat me to the fix. Abandoning this.

Feb 4 2022, 2:32 PM
cmtice requested review of D119037: Fix target dependencies for libtool in Bazel build files..
Feb 4 2022, 2:13 PM
cmtice added a comment to D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`.

This commit is causing some of our builds to fail with these errors:

Feb 4 2022, 10:07 AM · Restricted Project

Feb 3 2022

cmtice added a reviewer for D118955: Update Symbolize dependencies in bazel build file.: GMNGeoffrey.
Feb 3 2022, 4:47 PM
cmtice requested review of D118955: Update Symbolize dependencies in bazel build file..
Feb 3 2022, 4:47 PM

Feb 2 2022

cmtice abandoned D118863: Update mlir bazel build file with appropriate math header dependencies..

It looks like someone else fixed this issue while I was creating this patch: https://github.com/llvm/llvm-project/commit/4a6c9b5686.

Feb 2 2022, 5:00 PM
cmtice requested review of D118863: Update mlir bazel build file with appropriate math header dependencies..
Feb 2 2022, 4:43 PM

Feb 1 2022

cmtice added a comment to D115955: [SLP]Alternate vectorization for cmp instructions..

We're still working on getting you a reproducible test case, but this is definitely causing some bad codegen for us. Could you please revert it while we work on getting you the test case?

Feb 1 2022, 6:12 PM · Restricted Project
cmtice added a comment to D115955: [SLP]Alternate vectorization for cmp instructions..

Just a heads-up: This commit appears to be breaking some of our tests. We're working on trying to get a reproducible test case.

Feb 1 2022, 5:25 PM · Restricted Project

Jan 31 2022

cmtice added a comment to D116542: [OpenMP] Add a flag for embedding a file into the module.

This change introduces a circular dependency: BitcodeWriters now depends on TransformUtils, but TransformUtils also depends on BitcodeWriters. This appears to be a layering violation.

Jan 31 2022, 3:35 PM · Restricted Project, Restricted Project

Aug 12 2021

cmtice added a comment to rG6de1dbbd09c1: [InstCombine] factorize min/max intrinsic ops with common operand.

Just a heads up: We are seeing some new clang/llvm crashes, and we believe this CL is the culprit. I am working on trying to get a good reproducer. This CL may need to be reverted.

Aug 12 2021, 12:21 PM

Jun 30 2021

cmtice committed rG05915400b7f9: [lldb] Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with… (authored by cmtice).
[lldb] Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with…
Jun 30 2021, 9:27 AM
cmtice closed D104826: Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with their equivalent defintions in LinuxPTraceDefines_arm64sve.h.
Jun 30 2021, 9:27 AM · Unknown Object (Project)

Jun 26 2021

cmtice added a comment to D104826: Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with their equivalent defintions in LinuxPTraceDefines_arm64sve.h.

I have tried to build lldb-server for aarch64 inside Chrome OS following the instructions above, but due to the way things build in Chrome OS (using the Gentoo Linux portage system) this does not work. I also have not been able to find these definitions in ptrace.h files inside Chrome OS.

Jun 26 2021, 10:54 PM · Unknown Object (Project)

Jun 23 2021

cmtice added a comment to D104826: Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with their equivalent defintions in LinuxPTraceDefines_arm64sve.h.

Can we do this just using clang/llvm? We've stopped using GCC in Chrome OS and have pretty much removed it altogether.

Jun 23 2021, 5:15 PM · Unknown Object (Project)
cmtice added a comment to D104826: Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with their equivalent defintions in LinuxPTraceDefines_arm64sve.h.

To be clear, this is all elf/linux, and the builds happen on x86_64 machines.

Jun 23 2021, 5:04 PM · Unknown Object (Project)
cmtice added a comment to D104826: Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with their equivalent defintions in LinuxPTraceDefines_arm64sve.h.

I found a need for this change when I was trying to build (cross-compile) lldb/lldb-server for aarch64 inside Chrome OS -- the build I had was failing for aarch64 with all of these symbols "undefined". If you can tell me the cmake configs and/or build flags I should use to try to get these symbols from ptrace.h, I can try that instead. But since this is a cross-compile, they might not be available on the build system?

Jun 23 2021, 5:02 PM · Unknown Object (Project)
cmtice retitled D104826: Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with their equivalent defintions in LinuxPTraceDefines_arm64sve.h from Replace SVE_PT* in NativeRegisterContextLinux_arm64.{cpp,h} with their equivalent defintions in LinuxPTraceDefines_arm64sve.h to Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with their equivalent defintions in LinuxPTraceDefines_arm64sve.h.
Jun 23 2021, 4:52 PM · Unknown Object (Project)
cmtice added reviewers for D104826: Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with their equivalent defintions in LinuxPTraceDefines_arm64sve.h: labath, omjavaid.
Jun 23 2021, 4:49 PM · Unknown Object (Project)
cmtice requested review of D104826: Replace SVE_PT* macros in NativeRegisterContextLinux_arm64.{cpp,h} with their equivalent defintions in LinuxPTraceDefines_arm64sve.h.
Jun 23 2021, 4:47 PM · Unknown Object (Project)

Apr 16 2021

cmtice committed rG3dc24bc31edb: [LLDB] Re-land: Use path relative to binary for finding .dwo files. (authored by cmtice).
[LLDB] Re-land: Use path relative to binary for finding .dwo files.
Apr 16 2021, 11:13 AM
cmtice added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

Pavel's test case passed on my local machine (x86_64 linux workstation).

Apr 16 2021, 8:00 AM · Restricted Project, Restricted Project, Unknown Object (Project)
cmtice added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

Hi Pavel,

Apr 16 2021, 7:20 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Apr 15 2021

cmtice added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

I had to revert this change because the test case broke the windows builder. What's the right way to update/mark the test case so that it is only run on appropriate architectures & operating systems?

Apr 15 2021, 5:23 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cmtice added a reverting change for rGb241f3cb292d: [LLDB] Use path relative to binary for finding .dwo files.: rG042668d092bb: Revert "[LLDB] Use path relative to binary for finding .dwo files.".
Apr 15 2021, 5:19 PM
cmtice committed rG042668d092bb: Revert "[LLDB] Use path relative to binary for finding .dwo files." (authored by cmtice).
Revert "[LLDB] Use path relative to binary for finding .dwo files."
Apr 15 2021, 5:19 PM
cmtice added a reverting change for D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.: rG042668d092bb: Revert "[LLDB] Use path relative to binary for finding .dwo files.".
Apr 15 2021, 5:19 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cmtice committed rGb241f3cb292d: [LLDB] Use path relative to binary for finding .dwo files. (authored by cmtice).
[LLDB] Use path relative to binary for finding .dwo files.
Apr 15 2021, 2:44 PM
cmtice closed D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..
Apr 15 2021, 2:44 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Apr 14 2021

cmtice added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

I did leave 'main' in the .s file, but it's not very big. Is this ok now?

Apr 14 2021, 9:02 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cmtice updated the diff for D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

Update test case to use lldb on .o file and not run the inferior.

Apr 14 2021, 9:01 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Apr 13 2021

cmtice added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

Pavel, your last comment lost me completely. How can I test the code I added to lldb if I don't run lldb? I am a complete newbie at writing test cases so there's probably something basic I'm missing? How would I observe the value of the variable without running lldb? Also, if the program doesn't contain 'main', won't the compiler complain? Is there an existing test that does what you're suggesting that I could look at?

Apr 13 2021, 7:40 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Apr 8 2021

cmtice updated the diff for D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

Add a test case.

Apr 8 2021, 5:15 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Apr 7 2021

cmtice added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

It has taken a bit of time to get through the GDB reviews, but the change to GDB was accepted and committed: https://sourceware.org/pipermail/gdb-cvs/2021-April/050267.html

Apr 7 2021, 9:09 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Mar 7 2021

cmtice added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

I'm not sure about using target.debug-file-search-paths, and what the changes Pavel is suggesting would entail.

I imagine it would involve calling Symbols::LocateExecutableSymbolFile to locate the dwo file, similar to how we do that for dwp files (see SymbolFileDWARF::GetDwpSymbolFile). (Disclaimer: I have not tried doing this, so I don't know if that function would work out-of-the-box.)
Note that I myself am not convinced that this is the right solution (that function is rather heavy), but it does solve the problem of "how do we let the user specify/choose the location of the dwo files" (answer: put the path in the target.debug-file-search-paths setting), and it would search the cwd and the module directory automatically. And the "heavy-ness" of the function is moderated by the fact that it is a no-op for absolute paths to existing files.

But the real question I am trying to resolve here is not "what are all the places we should be searching for the .dwo files?" but "When we're given a *relative path* in the DWARF for finding the files, what should it be relative TO?".

I'm sorry, but what's the difference between those two questions? Is it about the fact that the second question sort of implies that there should only be one correct location where we should be searching?

Mar 7 2021, 8:53 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Mar 4 2021

cmtice updated the diff for D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

Update to incorporate Pavel's suggested simplification.

Mar 4 2021, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
cmtice added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

I'm not sure about using target.debug-file-search-paths, and what the changes Pavel is suggesting would entail. But the real question I am trying to resolve here is not "what are all the places we should be searching for the .dwo files?" but "When we're given a *relative path* in the DWARF for finding the files, what should it be relative TO?".

Mar 4 2021, 8:01 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2021

cmtice added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

It is true that the compiler will not know where the final executable will be placed, and if the executable gets moved then debugging with .dwo files will probably not work anyway, However as it is currently written, LLDB will fail to find the .dwo files, *even when the binary has not been moved*, if the debugger is launched from any directory other than the one containing the binary.

Mar 2 2021, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
cmtice updated the diff for D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

Upload the correct patch this time. (sorry!)

Mar 2 2021, 11:04 AM · Restricted Project, Restricted Project, Restricted Project
cmtice updated subscribers of D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

Something went very wrong on the patch upload. This does NOT look like the
patch I intended!

Mar 2 2021, 10:55 AM · Restricted Project, Restricted Project, Restricted Project