Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
@int3, For tests cases, I did the simple fix of adjusting addresses to accommodate the expansion of the load-command section. Should I expend the effort to generalize via patterns in order to quietly absorb future load-command expansions?
Should I expend the effort to generalize via patterns in order to quietly absorb future load-command expansions?
The reason those tests use hardcoded offsets instead of FileCheck's numeric substitutions is because of little-endianness. I'm not sure how they can be generalized while still checking for the things we care about. (Well, this is true for local-got.s at least. relocations.s just seems to be checking the little-endian encodings of the addresses, but doesn't check that it matches the big-endian form... this was an oversight)
lld/MachO/Writer.cpp | ||
---|---|---|
281 | codebase convention is not to prefix member variables | |
lld/test/MachO/headerpad.s | ||
14–15 | nit: add spaces to align with column |
lgtm!
lld/MachO/Writer.cpp | ||
---|---|---|
255 | nit: const ref | |
281 | const ref | |
lld/test/MachO/lc-build-version.s | ||
16 | JFYI, [[#]] will also match any number: https://llvm.org/docs/CommandGuide/FileCheck.html#filecheck-numeric-substitution-blocks |
lld/MachO/Writer.cpp | ||
---|---|---|
257 | Nit: can this and platform be private? |
lld/test/MachO/lc-build-version.s | ||
---|---|---|
14 | This macro is a bit overly restrictive: our version of lld does not start with a leading 1 and fails this test. I relaxed it in https://github.com/llvm/llvm-project/commit/22cbe40fa99795766f352c08a7c0748704c9d2d5 for now, if you would like a more specific checks I can propose this instead https://reviews.llvm.org/D86026 ? |
nit: const ref