Page MenuHomePhabricator

cishida (Cyndy Ishida)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2019, 1:26 PM (12 w, 1 d)

Recent Activity

Wed, Oct 9

cishida committed rGf9d8162b573d: Reland "[TextAPI] Introduce TBDv4" (authored by cishida).
Reland "[TextAPI] Introduce TBDv4"
Wed, Oct 9, 9:26 PM
cishida committed rL374277: Reland "[TextAPI] Introduce TBDv4".
Reland "[TextAPI] Introduce TBDv4"
Wed, Oct 9, 9:26 PM

Tue, Oct 8

cishida committed rGfb92ef1e55d7: Revert [TextAPI] Introduce TBDv4 (authored by cishida).
Revert [TextAPI] Introduce TBDv4
Tue, Oct 8, 8:26 AM
cishida committed rL374062: Revert [TextAPI] Introduce TBDv4.
Revert [TextAPI] Introduce TBDv4
Tue, Oct 8, 8:26 AM
cishida committed rG5d566c5a46ae: [TextAPI] Introduce TBDv4 (authored by cishida).
[TextAPI] Introduce TBDv4
Tue, Oct 8, 8:07 AM
cishida committed rL374058: [TextAPI] Introduce TBDv4.
[TextAPI] Introduce TBDv4
Tue, Oct 8, 8:07 AM
cishida closed D67529: [TextAPI] Introduce TBDv4.
Tue, Oct 8, 8:07 AM · Restricted Project

Mon, Oct 7

cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Fix a few typos in comments

Mon, Oct 7, 11:20 AM · Restricted Project
cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Add simulator + tests

Mon, Oct 7, 11:08 AM · Restricted Project
cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Reduce inplace limit for TargetList

Mon, Oct 7, 9:49 AM · Restricted Project

Fri, Sep 27

cishida added inline comments to D67529: [TextAPI] Introduce TBDv4.
Fri, Sep 27, 10:21 AM · Restricted Project
cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Update: Enforce Integer value for swift abi version

Fri, Sep 27, 9:22 AM · Restricted Project

Tue, Sep 24

cishida added inline comments to D63978: Clang Interface Stubs merger plumbing for Driver.
Tue, Sep 24, 8:07 AM · Restricted Project, Restricted Project

Mon, Sep 23

cishida added inline comments to D67529: [TextAPI] Introduce TBDv4.
Mon, Sep 23, 12:35 PM · Restricted Project
cishida committed rGd8d99d957c16: [TextAPI] Add New Supported Platforms (authored by cishida).
[TextAPI] Add New Supported Platforms
Mon, Sep 23, 8:29 AM
cishida committed rL372618: [TextAPI] Add New Supported Platforms.
[TextAPI] Add New Supported Platforms
Mon, Sep 23, 8:29 AM
cishida closed D67528: [TextAPI] Add New Supported Platforms.
Mon, Sep 23, 8:29 AM · Restricted Project

Sep 20 2019

cishida committed rG81669d5ead6f: [TextAPI] Arch&Platform to Target (authored by cishida).
[TextAPI] Arch&Platform to Target
Sep 20 2019, 7:32 AM
cishida committed rL372396: [TextAPI] Arch&Platform to Target.
[TextAPI] Arch&Platform to Target
Sep 20 2019, 7:31 AM
cishida closed D67527: [TextAPI] Arch&Platform to Target.
Sep 20 2019, 7:30 AM · Restricted Project

Sep 18 2019

cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Additional Cleanup.

Sep 18 2019, 1:04 PM · Restricted Project
cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Address comments from review

Sep 18 2019, 10:29 AM · Restricted Project

Sep 16 2019

cishida created D67646: [TextAPI] Add Multiple Document Support to TBDv3.
Sep 16 2019, 7:35 PM · Restricted Project

Sep 13 2019

cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Add enum to MetaDataSection

Sep 13 2019, 8:27 AM · Restricted Project
cishida updated the diff for D67528: [TextAPI] Add New Supported Platforms.

Inline PlatformSet Output

Sep 13 2019, 7:56 AM · Restricted Project

Sep 12 2019

cishida added a child revision for D67528: [TextAPI] Add New Supported Platforms: D67529: [TextAPI] Introduce TBDv4.
Sep 12 2019, 4:51 PM · Restricted Project
cishida added a parent revision for D67529: [TextAPI] Introduce TBDv4: D67528: [TextAPI] Add New Supported Platforms.
Sep 12 2019, 4:51 PM · Restricted Project
cishida created D67529: [TextAPI] Introduce TBDv4.
Sep 12 2019, 4:51 PM · Restricted Project
cishida added a parent revision for D67528: [TextAPI] Add New Supported Platforms: D67527: [TextAPI] Arch&Platform to Target.
Sep 12 2019, 4:24 PM · Restricted Project
cishida added a child revision for D67527: [TextAPI] Arch&Platform to Target: D67528: [TextAPI] Add New Supported Platforms.
Sep 12 2019, 4:24 PM · Restricted Project
cishida created D67528: [TextAPI] Add New Supported Platforms.
Sep 12 2019, 4:24 PM · Restricted Project
cishida created D67527: [TextAPI] Arch&Platform to Target.
Sep 12 2019, 4:21 PM · Restricted Project

Sep 11 2019

cishida added a comment to D66160: [llvm-nm] Add tapi file support.
In D66160#1666925, @kcc wrote:

Hi.

The asan bot is unhappy:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35078/steps/check-llvm%20asan/logs/stdio

Please fix or revert ASAP.

=================================================================
==10406==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 312 byte(s) in 1 object(s) allocated from:

#0 0x514d38 in operator new(unsigned long) /b/sanitizer-x86_64-linux-fast/build/llvm-project/compiler-rt/lib/asan/asan_new_delete.cc:105
#1 0x15627c9 in llvm::yaml::MappingTraits<llvm::MachO::InterfaceFile const*>::NormalizedTBD::denormalize(llvm::yaml::IO&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/TextAPI/MachO/TextStub.cpp:403:20
#2 0x1548510 in ~MappingNormalization /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:1321:24
#3 0x1548510 in llvm::yaml::MappingTraits<llvm::MachO::InterfaceFile const*>::mapping(llvm::yaml::IO&, llvm::MachO::InterfaceFile const*&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/TextAPI/MachO/TextStub.cpp:592
#4 0x1542bbe in doMapping<const llvm::MachO::InterfaceFile *> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:961:3
#5 0x1542bbe in yamlize<const llvm::MachO::InterfaceFile *, llvm::yaml::EmptyContext> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:1085
#6 0x1542bbe in operator>><std::__1::vector<const llvm::MachO::InterfaceFile *, std::__1::allocator<const llvm::MachO::InterfaceFile *> > > /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:1696
#7 0x1542bbe in llvm::MachO::TextAPIReader::get(llvm::MemoryBufferRef) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/TextAPI/MachO/TextStub.cpp:633
#8 0x139fd27 in llvm::object::TapiUniversal::TapiUniversal(llvm::MemoryBufferRef, llvm::Error&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Object/TapiUniversal.cpp:25:17
#9 0x13a0b0d in llvm::object::TapiUniversal::create(llvm::MemoryBufferRef) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Object/TapiUniversal.cpp:50:42
#10 0x122d5e9 in llvm::object::createBinary(llvm::MemoryBufferRef, llvm::LLVMContext*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Object/Binary.cpp:91:12
#11 0x51cf7c in dumpSymbolNamesFromFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llvm-nm/llvm-nm.cpp:1795:7
#12 0x51bbf7 in for_each<std::__1::__wrap_iter<std::__1::basic_string<char> *>, void (*)(std::__1::basic_string<char> &)> /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/algorithm:886:9
#13 0x51bbf7 in for_each<llvm::cl::list<std::__1::basic_string<char>, bool, llvm::cl::parser<std::string> > &, void (*)(std::__1::basic_string<char> &)> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/STLExtras.h:1159
#14 0x51bbf7 in main /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llvm-nm/llvm-nm.cpp:2163
#15 0x7f08c0c232e0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
Sep 11 2019, 2:54 PM · Restricted Project
cishida committed rGbc40836a433d: Revert [llvm-nm] Add tapi file support (authored by cishida).
Revert [llvm-nm] Add tapi file support
Sep 11 2019, 2:39 PM
cishida committed rL371676: Revert [llvm-nm] Add tapi file support.
Revert [llvm-nm] Add tapi file support
Sep 11 2019, 2:39 PM
cishida committed rGaeeb9e3895e2: Revert [Object][TextAPI] NFC, fix tapi lit tests (authored by cishida).
Revert [Object][TextAPI] NFC, fix tapi lit tests
Sep 11 2019, 2:33 PM
cishida committed rL371674: Revert [Object][TextAPI] NFC, fix tapi lit tests.
Revert [Object][TextAPI] NFC, fix tapi lit tests
Sep 11 2019, 2:32 PM

Sep 10 2019

cishida committed rGb2b0ccab2f76: [Object][TextAPI] NFC, fix tapi lit tests (authored by cishida).
[Object][TextAPI] NFC, fix tapi lit tests
Sep 10 2019, 5:14 PM
cishida committed rL371577: [Object][TextAPI] NFC, fix tapi lit tests.
[Object][TextAPI] NFC, fix tapi lit tests
Sep 10 2019, 5:14 PM
cishida committed rGf88f46358dbf: [llvm-nm] Add tapi file support (authored by cishida).
[llvm-nm] Add tapi file support
Sep 10 2019, 5:01 PM
cishida committed rL371576: [llvm-nm] Add tapi file support.
[llvm-nm] Add tapi file support
Sep 10 2019, 4:59 PM
cishida closed D66160: [llvm-nm] Add tapi file support.
Sep 10 2019, 4:59 PM · Restricted Project
cishida updated the diff for D66160: [llvm-nm] Add tapi file support.

[TextAPI] add num bits to architecture

Sep 10 2019, 2:44 PM · Restricted Project
cishida updated the diff for D66160: [llvm-nm] Add tapi file support.
  • [TextAPI] move archs to architecture.def
Sep 10 2019, 1:07 PM · Restricted Project
cishida added a comment to D66160: [llvm-nm] Add tapi file support.

Does this addition mean that llvm-nm should eventually include some support for other text formats like ifs/elfabi etc? I think this could be pretty useful for writing tests, which I assume is part of the motivation here?

Sep 10 2019, 8:38 AM · Restricted Project
cishida updated the diff for D66160: [llvm-nm] Add tapi file support.

Add 64bit symbol reading

Sep 10 2019, 8:23 AM · Restricted Project

Sep 7 2019

cishida added inline comments to D63978: Clang Interface Stubs merger plumbing for Driver.
Sep 7 2019, 6:03 PM · Restricted Project, Restricted Project

Sep 6 2019

cishida accepted D67255: [llvm-ifs] Fixing hardcoding of PlatformKind for TBD generation.

LGTM

Sep 6 2019, 8:11 AM · Restricted Project
cishida added a comment to D67255: [llvm-ifs] Fixing hardcoding of PlatformKind for TBD generation.

bridgeOS hasn't been added to llvm triple yet, so it's fine to exclude it for now.
also I have a patch I'm adding very soon that takes in llvm::triple and does the arch/platform mapping so you won't need to. I'll update this file when it comes out.

Sep 6 2019, 8:10 AM · Restricted Project
cishida committed rG4f8d005831a0: [Object] remove struct constructor, NFC (authored by cishida).
[Object] remove struct constructor, NFC
Sep 6 2019, 8:02 AM
cishida committed rL371211: [Object] remove struct constructor, NFC.
[Object] remove struct constructor, NFC
Sep 6 2019, 8:02 AM
cishida closed D67251: [Object] remove struct constructor, NFC.
Sep 6 2019, 8:02 AM · Restricted Project

Sep 5 2019

cishida created D67251: [Object] remove struct constructor, NFC.
Sep 5 2019, 5:57 PM · Restricted Project
cishida committed rG541ab7130e2c: [TextAPI] update interface file for filtered iter (authored by cishida).
[TextAPI] update interface file for filtered iter
Sep 5 2019, 10:34 AM
cishida committed rL371097: [TextAPI] update interface file for filtered iter.
[TextAPI] update interface file for filtered iter
Sep 5 2019, 10:34 AM
cishida closed D67204: [TextAPI] update interface file for filtered iter.
Sep 5 2019, 10:34 AM · Restricted Project

Sep 4 2019

cishida created D67204: [TextAPI] update interface file for filtered iter.
Sep 4 2019, 5:53 PM · Restricted Project
cishida added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Sep 4 2019, 3:27 PM · Restricted Project
cishida committed rL370909: Request commit access for cishida.
Request commit access for cishida
Sep 4 2019, 7:46 AM

Aug 21 2019

cishida committed rG9443d0e2c09b: [Object] FIX: update PlatformKind name in TapiFile (authored by cishida).
[Object] FIX: update PlatformKind name in TapiFile
Aug 21 2019, 5:10 PM
cishida committed rL369602: [Object] FIX: update PlatformKind name in TapiFile.
[Object] FIX: update PlatformKind name in TapiFile
Aug 21 2019, 5:07 PM
cishida committed rGc20d1f90b53a: [Object] Add tapi files to object (authored by cishida).
[Object] Add tapi files to object
Aug 21 2019, 4:36 PM
cishida committed rL369600: [Object] Add tapi files to object.
[Object] Add tapi files to object
Aug 21 2019, 4:35 PM
cishida closed D66159: [Object] Add tapi files to object.
Aug 21 2019, 4:35 PM · Restricted Project
cishida committed rG359840a6e4ae: [BinaryFormat] Teach identify_magic about Tapi files. (authored by cishida).
[BinaryFormat] Teach identify_magic about Tapi files.
Aug 21 2019, 2:00 PM
cishida committed rL369579: [BinaryFormat] Teach identify_magic about Tapi files..
[BinaryFormat] Teach identify_magic about Tapi files.
Aug 21 2019, 1:59 PM
cishida closed D66149: [BinaryFormat] Teach identify_magic about Tapi files..
Aug 21 2019, 1:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 20 2019

cishida added a reviewer for D66159: [Object] Add tapi files to object: lhames.
Aug 20 2019, 10:16 AM · Restricted Project

Aug 16 2019

cishida committed rG5f865ecf06cb: [TextAPI] Update reader to be supported by lib/Object (authored by cishida).
[TextAPI] Update reader to be supported by lib/Object
Aug 16 2019, 8:35 AM
cishida committed rL369119: [TextAPI] Update reader to be supported by lib/Object.
[TextAPI] Update reader to be supported by lib/Object
Aug 16 2019, 8:35 AM
cishida closed D66147: [TextAPI] Update reader to be supported by lib/Object.
Aug 16 2019, 8:35 AM · Restricted Project

Aug 14 2019

cishida updated the diff for D66149: [BinaryFormat] Teach identify_magic about Tapi files..

Reverse order of conditional for file_magic

Aug 14 2019, 11:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
cishida removed reviewers for D66149: [BinaryFormat] Teach identify_magic about Tapi files.: bollu, JDevlieghere, martong, espindola, jfb, shafik, jdoerfert.
Aug 14 2019, 11:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
cishida abandoned D66149: [BinaryFormat] Teach identify_magic about Tapi files..
Aug 14 2019, 11:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
cishida updated the diff for D66149: [BinaryFormat] Teach identify_magic about Tapi files..
  • Reverse order of conditional for file_magic
Aug 14 2019, 11:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
cishida updated the diff for D66149: [BinaryFormat] Teach identify_magic about Tapi files..

Reverse order of conditional for file_magic

Aug 14 2019, 10:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 13 2019

cishida added inline comments to D66149: [BinaryFormat] Teach identify_magic about Tapi files..
Aug 13 2019, 4:28 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
cishida added inline comments to D66147: [TextAPI] Update reader to be supported by lib/Object.
Aug 13 2019, 4:21 PM · Restricted Project
cishida updated the diff for D66147: [TextAPI] Update reader to be supported by lib/Object.

[TextAPI] prevent memory leak for Interface File

Aug 13 2019, 4:18 PM · Restricted Project
cishida added a comment to D66147: [TextAPI] Update reader to be supported by lib/Object.

I currently don't have commit access, so would anyone mind pushing this up to master?

Aug 13 2019, 1:33 PM · Restricted Project
cishida updated the summary of D66159: [Object] Add tapi files to object.
Aug 13 2019, 1:29 PM · Restricted Project
cishida added a parent revision for D66160: [llvm-nm] Add tapi file support: D66159: [Object] Add tapi files to object.
Aug 13 2019, 1:11 PM · Restricted Project
cishida added a child revision for D66159: [Object] Add tapi files to object: D66160: [llvm-nm] Add tapi file support.
Aug 13 2019, 1:11 PM · Restricted Project
cishida added a child revision for D66149: [BinaryFormat] Teach identify_magic about Tapi files.: D66159: [Object] Add tapi files to object.
Aug 13 2019, 1:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
cishida added a parent revision for D66159: [Object] Add tapi files to object: D66149: [BinaryFormat] Teach identify_magic about Tapi files..
Aug 13 2019, 1:11 PM · Restricted Project
cishida created D66160: [llvm-nm] Add tapi file support.
Aug 13 2019, 1:06 PM · Restricted Project
cishida created D66159: [Object] Add tapi files to object.
Aug 13 2019, 1:06 PM · Restricted Project
cishida added a child revision for D66147: [TextAPI] Update reader to be supported by lib/Object: D66149: [BinaryFormat] Teach identify_magic about Tapi files..
Aug 13 2019, 9:58 AM · Restricted Project
cishida added a parent revision for D66149: [BinaryFormat] Teach identify_magic about Tapi files.: D66147: [TextAPI] Update reader to be supported by lib/Object.
Aug 13 2019, 9:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
cishida created D66149: [BinaryFormat] Teach identify_magic about Tapi files..
Aug 13 2019, 9:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
cishida updated the summary of D66147: [TextAPI] Update reader to be supported by lib/Object.
Aug 13 2019, 9:22 AM · Restricted Project
cishida created D66147: [TextAPI] Update reader to be supported by lib/Object.
Aug 13 2019, 9:12 AM · Restricted Project

Aug 12 2019

cishida added a comment to D66041: [TextAPI] Fix & Add tests for tbd files version 3..

I currently don't have commit access rights to push this patch. Can you commit this change for me while I request access?

Aug 12 2019, 3:29 PM · Restricted Project
cishida updated the diff for D66041: [TextAPI] Fix & Add tests for tbd files version 3..
  • [TextAPI] Remove windows guard from tests
Aug 12 2019, 3:20 PM · Restricted Project
cishida added inline comments to D66041: [TextAPI] Fix & Add tests for tbd files version 3..
Aug 12 2019, 9:26 AM · Restricted Project

Aug 9 2019

cishida created D66041: [TextAPI] Fix & Add tests for tbd files version 3..
Aug 9 2019, 5:57 PM · Restricted Project