Page MenuHomePhabricator

cishida (Cyndy Ishida)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2019, 1:26 PM (59 w, 5 d)

Recent Activity

Aug 15 2020

cishida committed rG85d381eb02a2: [TextAPI] update DriverKit string value (authored by cishida).
[TextAPI] update DriverKit string value
Aug 15 2020, 6:47 AM

Aug 14 2020

cishida accepted D85594: [MachO] Add skeletal support for DriverKit platform.
Aug 14 2020, 12:34 PM · Restricted Project

Aug 13 2020

cishida added inline comments to D85594: [MachO] Add skeletal support for DriverKit platform.
Aug 13 2020, 11:02 PM · Restricted Project
cishida accepted D85594: [MachO] Add skeletal support for DriverKit platform.
Aug 13 2020, 9:38 PM · Restricted Project

Aug 12 2020

cishida added a comment to D84770: [llvm-libtool-darwin] Add support for -arch_only.

I think I need to add V8 support under llvm/include/llvm/TextAPI/MachO/Architecture.def here:

///
/// ARM64 architectures sorted by cpu sub type id.
///
ARCHINFO(arm64, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64_ALL, 64)
ARCHINFO(arm64e, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64E, 64)

What should be the first element for that tuple in case of V8 (arm64_v8 or arm64v8 or maybe something else) ? Thanks.

Hmm, what necessitates the TAPI patch? arm64_v8 seems fine to me, though @ributzka and @cishida should weigh in there.

Converting a yaml file with Subtype V8 to an object file requires this patch. I was trying to add a test for V8, but my yaml was incorrectly parsed as an object file with unknown architecture.

Aug 12 2020, 12:59 AM · Restricted Project
cishida added a comment to D85594: [MachO] Add skeletal support for DriverKit platform.
In D85594#2207080, @gkm wrote:

@tschuett, I prefer not to do anything that involves semantics for DriverKit, since I don't have any domain knowledge. For that matter, perhaps I shouldn't even follow-through with this diff, which I only embarked upon at your suggestion because the original author of the MachO -platform_version diff (I commandeered it) had a TODO comment. I can code-monkey the TBDv4 testcase via simple substitution, but what about TBDv1 .. TBDv3? IDK, and don't want to spend time determining minimum version# for DriverKit. Do you know that?

Aug 12 2020, 12:07 AM · Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rG5541dbb0c022: Merge pull request #984 from cyndyishida/tapi-weakdef-cherrypick (authored by cishida).
Merge pull request #984 from cyndyishida/tapi-weakdef-cherrypick
Jul 14 2020, 4:37 PM
cishida committed rGa08a41ea9c91: [llvm][MachO] fix adding weak def syms (authored by cishida).
[llvm][MachO] fix adding weak def syms
Jul 14 2020, 4:37 PM
GitHub <noreply@github.com> committed rGbdb7e469df4f: Merge pull request #768 from cyndyishida/apple/stable/20200108 (authored by cishida).
Merge pull request #768 from cyndyishida/apple/stable/20200108
Jul 14 2020, 4:22 PM
cishida committed rG8002f917938d: [llvm][TextAPI] add simulators to output (authored by cishida).
[llvm][TextAPI] add simulators to output
Jul 14 2020, 4:22 PM

Jun 30 2020

cishida committed rG89a0c4066b0e: [clang][diagnostics] Add '-Wundef-prefix' warning option (authored by zixuw).
[clang][diagnostics] Add '-Wundef-prefix' warning option
Jun 30 2020, 2:10 PM
cishida closed D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
Jun 30 2020, 2:10 PM · Restricted Project

Jun 15 2020

cishida committed rG2ba320846b1b: [llvm][TextAPI/MachO] clean up auto usages in tests, NFC (authored by cishida).
[llvm][TextAPI/MachO] clean up auto usages in tests, NFC
Jun 15 2020, 8:23 PM

Jun 11 2020

cishida accepted D81717: [llvm/Object] Reimplment basic_symbol_iterator in TapiFile.

Thanks for fixing this! one nit but LGTM

Jun 11 2020, 11:57 PM · Restricted Project
cishida committed rG28fefcc83c52: [llvm][llvm-nm] add TextAPI/MachO support (authored by cishida).
[llvm][llvm-nm] add TextAPI/MachO support
Jun 11 2020, 7:16 PM
cishida closed D81614: [llvm][llvm-nm] add TextAPI/MachO support.
Jun 11 2020, 7:16 PM · Restricted Project
cishida added a comment to D81614: [llvm][llvm-nm] add TextAPI/MachO support.

the landed patch has applied MaskRay's comments.

Jun 11 2020, 7:15 PM · Restricted Project
cishida updated the diff for D81614: [llvm][llvm-nm] add TextAPI/MachO support.

adopintg jhenderson's comments to increase Readablity & Coding Guidelines

Jun 11 2020, 8:46 AM · Restricted Project

Jun 10 2020

cishida updated the diff for D81614: [llvm][llvm-nm] add TextAPI/MachO support.

Updating to address comments, add more const correctness, fix casing on FileCheck

Jun 10 2020, 4:08 PM · Restricted Project
cishida added inline comments to D81614: [llvm][llvm-nm] add TextAPI/MachO support.
Jun 10 2020, 4:08 PM · Restricted Project
cishida created D81614: [llvm][llvm-nm] add TextAPI/MachO support.
Jun 10 2020, 3:02 PM · Restricted Project

Apr 2 2020

cishida committed rGfd4d07517b2c: [llvm][TextAPI] adding inlining reexported libraries support (authored by cishida).
[llvm][TextAPI] adding inlining reexported libraries support
Apr 2 2020, 1:34 PM
cishida closed D67646: [llvm][TextAPI] adding inlining reexported libraries support.
Apr 2 2020, 1:34 PM · Restricted Project
cishida added a comment to D67646: [llvm][TextAPI] adding inlining reexported libraries support.

the lint corrections will be/have been made in the revision that lands.

Apr 2 2020, 12:28 PM · Restricted Project

Mar 31 2020

cishida retitled D67646: [llvm][TextAPI] adding inlining reexported libraries support from [TextAPI] Add Multiple Document Support to TBDv3 to [llvm][TextAPI] adding inlining reexported libraries support.
Mar 31 2020, 11:58 PM · Restricted Project
cishida updated the diff for D67646: [llvm][TextAPI] adding inlining reexported libraries support.

Updating this patch to just create inlining framework support, and I will attach lib/Object & nm support in a seperate patch

Mar 31 2020, 3:59 PM · Restricted Project

Mar 26 2020

cishida committed rGd26e0bcfba6c: [llvm][TextAPI/MachO] silence clang-tidy warnings, NFC (authored by cishida).
[llvm][TextAPI/MachO] silence clang-tidy warnings, NFC
Mar 26 2020, 4:53 PM

Mar 5 2020

cishida committed rGa0cd41342647: [TextAPI] Teach TextAPI about arm64e (authored by cishida).
[TextAPI] Teach TextAPI about arm64e
Mar 5 2020, 1:45 PM
cishida closed D75688: [TextAPI] Teach TextAPI about arm64e.
Mar 5 2020, 1:45 PM · Restricted Project
cishida accepted D75688: [TextAPI] Teach TextAPI about arm64e.

LGTM, Jürgen approved via email as well.

Mar 5 2020, 1:44 PM · Restricted Project
cishida updated the diff for D75688: [TextAPI] Teach TextAPI about arm64e.

updating Kuba's patch with tests

Mar 5 2020, 12:39 PM · Restricted Project

Mar 2 2020

cishida committed rGb796acbba24f: [llvm][MachO] fix adding weak def syms (authored by cishida).
[llvm][MachO] fix adding weak def syms
Mar 2 2020, 5:15 PM

Feb 25 2020

cishida committed rG6d2372ce584f: [llvm][TextAPI] rename test vars, NFC (authored by cishida).
[llvm][TextAPI] rename test vars, NFC
Feb 25 2020, 2:30 PM

Feb 12 2020

cishida accepted D73332: [llvm][TextAPI/MachO] Extract common code into unittest helper (NFC).

LGTM, thank you for cleaning this up.

Feb 12 2020, 4:22 PM · Restricted Project
cishida accepted D73330: [llvm][TextAPI/MachO] Extend TBD_V4 unittest to verify writing.

LGTM

Feb 12 2020, 4:22 PM · Restricted Project

Feb 11 2020

cishida committed rG8c3d0d6a5f5a: [llvm][TextAPI] add simulators to output (authored by cishida).
[llvm][TextAPI] add simulators to output
Feb 11 2020, 10:42 AM
cishida closed D74416: [llvm][TextAPI] add simulators to output.
Feb 11 2020, 10:42 AM · Restricted Project
cishida added a comment to D74416: [llvm][TextAPI] add simulators to output.

will resolve the warning: invalid case style for variable '...' [readability-identifier-naming] in a future patch since it'll cause mismatching conventions through the whole file.

Feb 11 2020, 10:42 AM · Restricted Project
cishida updated the diff for D74416: [llvm][TextAPI] add simulators to output.

Updating to use LLVM_FALLTHROUGH for cases

Feb 11 2020, 9:12 AM · Restricted Project
cishida added inline comments to D74416: [llvm][TextAPI] add simulators to output.
Feb 11 2020, 8:44 AM · Restricted Project
cishida created D74416: [llvm][TextAPI] add simulators to output.
Feb 11 2020, 7:59 AM · Restricted Project

Jan 29 2020

cishida reopened D73640: [SmallString] Add explicit conversion to std::string.

This indirection seems like unnecessary work. Could you reimplement this as a direct conversion to std::string?

Jan 29 2020, 1:40 PM · Restricted Project

Jan 27 2020

cishida accepted D73325: [llvm][TextAPI/MachO] Support writing single macCatalyst platform.

LGTM, thank you!

Jan 27 2020, 8:11 AM · Restricted Project

Jan 23 2020

cishida accepted D73328: [llvm][TextAPI/MachO] Extend TBD_V3 unittest to verify writing.

small comment, otherwise LGTM

Jan 23 2020, 11:19 PM · Restricted Project
cishida added a comment to D73326: [TAPI] Update variable names to match TAPI version in unit tests. (NFC).

nit: probably should update [TAPI] to [llvm][TextAPI/MachO] in the commit header.

Jan 23 2020, 10:52 PM · Restricted Project
cishida accepted D73326: [TAPI] Update variable names to match TAPI version in unit tests. (NFC).

LGTM, thanks!

Jan 23 2020, 10:52 PM · Restricted Project

Jan 16 2020

cishida committed rG24fca5cd7128: [lldb] add to gdb to lldb doc (authored by cishida).
[lldb] add to gdb to lldb doc
Jan 16 2020, 8:08 PM
cishida closed D72898: [lldb] add to gdb to lldb doc.
Jan 16 2020, 8:08 PM · Restricted Project
cishida updated the diff for D72898: [lldb] add to gdb to lldb doc.

Updating to fix copy/paste error

Jan 16 2020, 7:58 PM · Restricted Project
cishida created D72898: [lldb] add to gdb to lldb doc.
Jan 16 2020, 7:03 PM · Restricted Project

Dec 5 2019

cishida added inline comments to D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs..
Dec 5 2019, 7:30 AM · Restricted Project

Nov 18 2019

cishida committed rG9b36f2cfd98d: Fix iOSDarwin()'s doc comment. (authored by cishida).
Fix iOSDarwin()'s doc comment.
Nov 18 2019, 1:25 PM
cishida closed D70364: Fix iOSDarwin()'s doc comment..
Nov 18 2019, 1:24 PM · Restricted Project

Oct 9 2019

cishida committed rGf9d8162b573d: Reland "[TextAPI] Introduce TBDv4" (authored by cishida).
Reland "[TextAPI] Introduce TBDv4"
Oct 9 2019, 9:26 PM
cishida committed rL374277: Reland "[TextAPI] Introduce TBDv4".
Reland "[TextAPI] Introduce TBDv4"
Oct 9 2019, 9:26 PM

Oct 8 2019

cishida committed rGfb92ef1e55d7: Revert [TextAPI] Introduce TBDv4 (authored by cishida).
Revert [TextAPI] Introduce TBDv4
Oct 8 2019, 8:26 AM
cishida committed rL374062: Revert [TextAPI] Introduce TBDv4.
Revert [TextAPI] Introduce TBDv4
Oct 8 2019, 8:26 AM
cishida committed rG5d566c5a46ae: [TextAPI] Introduce TBDv4 (authored by cishida).
[TextAPI] Introduce TBDv4
Oct 8 2019, 8:07 AM
cishida committed rL374058: [TextAPI] Introduce TBDv4.
[TextAPI] Introduce TBDv4
Oct 8 2019, 8:07 AM
cishida closed D67529: [TextAPI] Introduce TBDv4.
Oct 8 2019, 8:07 AM · Restricted Project

Oct 7 2019

cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Fix a few typos in comments

Oct 7 2019, 11:20 AM · Restricted Project
cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Add simulator + tests

Oct 7 2019, 11:08 AM · Restricted Project
cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Reduce inplace limit for TargetList

Oct 7 2019, 9:49 AM · Restricted Project

Sep 27 2019

cishida added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 27 2019, 10:21 AM · Restricted Project
cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Update: Enforce Integer value for swift abi version

Sep 27 2019, 9:22 AM · Restricted Project

Sep 24 2019

cishida added inline comments to D63978: Clang Interface Stubs merger plumbing for Driver.
Sep 24 2019, 8:07 AM · Restricted Project, Restricted Project

Sep 23 2019

cishida added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 23 2019, 12:35 PM · Restricted Project
cishida committed rGd8d99d957c16: [TextAPI] Add New Supported Platforms (authored by cishida).
[TextAPI] Add New Supported Platforms
Sep 23 2019, 8:29 AM
cishida committed rL372618: [TextAPI] Add New Supported Platforms.
[TextAPI] Add New Supported Platforms
Sep 23 2019, 8:29 AM
cishida closed D67528: [TextAPI] Add New Supported Platforms.
Sep 23 2019, 8:29 AM · Restricted Project

Sep 20 2019

cishida committed rG81669d5ead6f: [TextAPI] Arch&Platform to Target (authored by cishida).
[TextAPI] Arch&Platform to Target
Sep 20 2019, 7:32 AM
cishida committed rL372396: [TextAPI] Arch&Platform to Target.
[TextAPI] Arch&Platform to Target
Sep 20 2019, 7:31 AM
cishida closed D67527: [TextAPI] Arch&Platform to Target.
Sep 20 2019, 7:30 AM · Restricted Project

Sep 18 2019

cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Additional Cleanup.

Sep 18 2019, 1:04 PM · Restricted Project
cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Address comments from review

Sep 18 2019, 10:29 AM · Restricted Project

Sep 16 2019

cishida created D67646: [llvm][TextAPI] adding inlining reexported libraries support.
Sep 16 2019, 7:35 PM · Restricted Project

Sep 13 2019

cishida updated the diff for D67529: [TextAPI] Introduce TBDv4.

Add enum to MetaDataSection

Sep 13 2019, 8:27 AM · Restricted Project
cishida updated the diff for D67528: [TextAPI] Add New Supported Platforms.

Inline PlatformSet Output

Sep 13 2019, 7:56 AM · Restricted Project

Sep 12 2019

cishida created D67529: [TextAPI] Introduce TBDv4.
Sep 12 2019, 4:51 PM · Restricted Project
cishida created D67528: [TextAPI] Add New Supported Platforms.
Sep 12 2019, 4:24 PM · Restricted Project
cishida created D67527: [TextAPI] Arch&Platform to Target.
Sep 12 2019, 4:21 PM · Restricted Project

Sep 11 2019

cishida added a comment to D66160: [llvm-nm] Add tapi file support.
In D66160#1666925, @kcc wrote:

Hi.

The asan bot is unhappy:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35078/steps/check-llvm%20asan/logs/stdio

Please fix or revert ASAP.

10406==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 312 byte(s) in 1 object(s) allocated from:

#0 0x514d38 in operator new(unsigned long) /b/sanitizer-x86_64-linux-fast/build/llvm-project/compiler-rt/lib/asan/asan_new_delete.cc:105
#1 0x15627c9 in llvm::yaml::MappingTraits<llvm::MachO::InterfaceFile const*>::NormalizedTBD::denormalize(llvm::yaml::IO&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/TextAPI/MachO/TextStub.cpp:403:20
#2 0x1548510 in ~MappingNormalization /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:1321:24
#3 0x1548510 in llvm::yaml::MappingTraits<llvm::MachO::InterfaceFile const*>::mapping(llvm::yaml::IO&, llvm::MachO::InterfaceFile const*&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/TextAPI/MachO/TextStub.cpp:592
#4 0x1542bbe in doMapping<const llvm::MachO::InterfaceFile *> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:961:3
#5 0x1542bbe in yamlize<const llvm::MachO::InterfaceFile *, llvm::yaml::EmptyContext> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:1085
#6 0x1542bbe in operator>><std::__1::vector<const llvm::MachO::InterfaceFile *, std::__1::allocator<const llvm::MachO::InterfaceFile *> > > /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/YAMLTraits.h:1696
#7 0x1542bbe in llvm::MachO::TextAPIReader::get(llvm::MemoryBufferRef) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/TextAPI/MachO/TextStub.cpp:633
#8 0x139fd27 in llvm::object::TapiUniversal::TapiUniversal(llvm::MemoryBufferRef, llvm::Error&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Object/TapiUniversal.cpp:25:17
#9 0x13a0b0d in llvm::object::TapiUniversal::create(llvm::MemoryBufferRef) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Object/TapiUniversal.cpp:50:42
#10 0x122d5e9 in llvm::object::createBinary(llvm::MemoryBufferRef, llvm::LLVMContext*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Object/Binary.cpp:91:12
#11 0x51cf7c in dumpSymbolNamesFromFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llvm-nm/llvm-nm.cpp:1795:7
#12 0x51bbf7 in for_each<std::__1::__wrap_iter<std::__1::basic_string<char> *>, void (*)(std::__1::basic_string<char> &)> /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/algorithm:886:9
#13 0x51bbf7 in for_each<llvm::cl::list<std::__1::basic_string<char>, bool, llvm::cl::parser<std::string> > &, void (*)(std::__1::basic_string<char> &)> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/STLExtras.h:1159
#14 0x51bbf7 in main /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llvm-nm/llvm-nm.cpp:2163
#15 0x7f08c0c232e0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
Sep 11 2019, 2:54 PM · Restricted Project
cishida committed rGbc40836a433d: Revert [llvm-nm] Add tapi file support (authored by cishida).
Revert [llvm-nm] Add tapi file support
Sep 11 2019, 2:39 PM
cishida committed rL371676: Revert [llvm-nm] Add tapi file support.
Revert [llvm-nm] Add tapi file support
Sep 11 2019, 2:39 PM
cishida committed rGaeeb9e3895e2: Revert [Object][TextAPI] NFC, fix tapi lit tests (authored by cishida).
Revert [Object][TextAPI] NFC, fix tapi lit tests
Sep 11 2019, 2:33 PM
cishida committed rL371674: Revert [Object][TextAPI] NFC, fix tapi lit tests.
Revert [Object][TextAPI] NFC, fix tapi lit tests
Sep 11 2019, 2:32 PM

Sep 10 2019

cishida committed rGb2b0ccab2f76: [Object][TextAPI] NFC, fix tapi lit tests (authored by cishida).
[Object][TextAPI] NFC, fix tapi lit tests
Sep 10 2019, 5:14 PM
cishida committed rL371577: [Object][TextAPI] NFC, fix tapi lit tests.
[Object][TextAPI] NFC, fix tapi lit tests
Sep 10 2019, 5:14 PM
cishida committed rGf88f46358dbf: [llvm-nm] Add tapi file support (authored by cishida).
[llvm-nm] Add tapi file support
Sep 10 2019, 5:01 PM
cishida committed rL371576: [llvm-nm] Add tapi file support.
[llvm-nm] Add tapi file support
Sep 10 2019, 4:59 PM
cishida closed D66160: [llvm-nm] Add tapi file support.
Sep 10 2019, 4:59 PM · Restricted Project
cishida updated the diff for D66160: [llvm-nm] Add tapi file support.

[TextAPI] add num bits to architecture

Sep 10 2019, 2:44 PM · Restricted Project
cishida updated the diff for D66160: [llvm-nm] Add tapi file support.
  • [TextAPI] move archs to architecture.def
Sep 10 2019, 1:07 PM · Restricted Project
cishida added a comment to D66160: [llvm-nm] Add tapi file support.

Does this addition mean that llvm-nm should eventually include some support for other text formats like ifs/elfabi etc? I think this could be pretty useful for writing tests, which I assume is part of the motivation here?

Sep 10 2019, 8:38 AM · Restricted Project
cishida updated the diff for D66160: [llvm-nm] Add tapi file support.

Add 64bit symbol reading

Sep 10 2019, 8:23 AM · Restricted Project

Sep 7 2019

cishida added inline comments to D63978: Clang Interface Stubs merger plumbing for Driver.
Sep 7 2019, 6:03 PM · Restricted Project, Restricted Project

Sep 6 2019

cishida accepted D67255: [llvm-ifs] Fixing hardcoding of PlatformKind for TBD generation.

LGTM

Sep 6 2019, 8:11 AM · Restricted Project
cishida added a comment to D67255: [llvm-ifs] Fixing hardcoding of PlatformKind for TBD generation.

bridgeOS hasn't been added to llvm triple yet, so it's fine to exclude it for now.
also I have a patch I'm adding very soon that takes in llvm::triple and does the arch/platform mapping so you won't need to. I'll update this file when it comes out.

Sep 6 2019, 8:10 AM · Restricted Project
cishida committed rG4f8d005831a0: [Object] remove struct constructor, NFC (authored by cishida).
[Object] remove struct constructor, NFC
Sep 6 2019, 8:02 AM
cishida committed rL371211: [Object] remove struct constructor, NFC.
[Object] remove struct constructor, NFC
Sep 6 2019, 8:02 AM