Page MenuHomePhabricator

cishida (Cyndy Ishida)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2019, 1:26 PM (122 w, 1 d)

Recent Activity

Oct 15 2021

cishida committed rG395e1fe30574: [clang] Capture Framework when HeaderSearch is resolved via headermap (authored by cishida).
[clang] Capture Framework when HeaderSearch is resolved via headermap
Oct 15 2021, 9:18 AM
cishida closed D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap.
Oct 15 2021, 9:18 AM · Restricted Project
cishida added a comment to D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap.

LGTM.

As a follow-up, do you think it would make sense to improve the documentation/comments around "index header maps"? Variable names refer to indexing while the documentation talks about building frameworks, which is confusing without referring back to the original Radar.

Oct 15 2021, 8:30 AM · Restricted Project

Oct 14 2021

cishida updated the diff for D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap.

Fix windows build.

Oct 14 2021, 7:57 AM · Restricted Project

Oct 8 2021

cishida updated the summary of D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap.
Oct 8 2021, 4:13 PM · Restricted Project
cishida requested review of D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap.
Oct 8 2021, 4:06 PM · Restricted Project

Jul 23 2021

cishida committed rG8594a24d63d8: [llvm][NFC] Fix typos in Errc.h description (authored by cishida).
[llvm][NFC] Fix typos in Errc.h description
Jul 23 2021, 11:57 AM

Jun 23 2021

cishida committed rGfb9f9497dc01: [llvm-tapi-diff] Wrap empty string around StringLiteral NFC (authored by cishida).
[llvm-tapi-diff] Wrap empty string around StringLiteral NFC
Jun 23 2021, 11:41 AM
cishida committed rG56709b869570: [TextAPI] add symbol name prefixes to central location, NFC (authored by cishida).
[TextAPI] add symbol name prefixes to central location, NFC
Jun 23 2021, 11:24 AM

Jun 9 2021

cishida committed rG5b5ab80e3195: Reland "[llvm] llvm-tapi-diff" (authored by spowell).
Reland "[llvm] llvm-tapi-diff"
Jun 9 2021, 9:21 PM
cishida added a reverting change for rG20126c9fd4af: Reland "[llvm] llvm-tapi-diff": rGe7b755ecb140: Revert "Reland "[llvm] llvm-tapi-diff"".
Jun 9 2021, 1:52 PM
cishida added a reverting change for D101835: [llvm] llvm-tapi-diff: rGe7b755ecb140: Revert "Reland "[llvm] llvm-tapi-diff"".
Jun 9 2021, 1:52 PM · Restricted Project
cishida committed rGe7b755ecb140: Revert "Reland "[llvm] llvm-tapi-diff"" (authored by cishida).
Revert "Reland "[llvm] llvm-tapi-diff""
Jun 9 2021, 1:52 PM
cishida added a reverting change for rG90a26a41e9ce: [llvm-tapi-diff] Apply stable sorting to output: rG1899cb7d0eae: Revert "[llvm-tapi-diff] Apply stable sorting to output".
Jun 9 2021, 1:50 PM
cishida committed rG1899cb7d0eae: Revert "[llvm-tapi-diff] Apply stable sorting to output" (authored by cishida).
Revert "[llvm-tapi-diff] Apply stable sorting to output"
Jun 9 2021, 1:50 PM
cishida committed rG90a26a41e9ce: [llvm-tapi-diff] Apply stable sorting to output (authored by spowell).
[llvm-tapi-diff] Apply stable sorting to output
Jun 9 2021, 1:10 PM
cishida committed rG20126c9fd4af: Reland "[llvm] llvm-tapi-diff" (authored by spowell).
Reland "[llvm] llvm-tapi-diff"
Jun 9 2021, 10:38 AM

Jun 3 2021

cishida added a comment to D101835: [llvm] llvm-tapi-diff.

The tests for this tool are observed to be failing on multiple big-endian platforms:
clang-s390x-linux: https://lab.llvm.org/buildbot/#/builders/94/builds/4116
clang-ppc64be-linux: https://lab.llvm.org/buildbot/#/builders/52/builds/8035

Jun 3 2021, 9:15 PM · Restricted Project
cishida added a reverting change for rGd1d36f7ad2ae: [llvm] llvm-tapi-diff: rG5337c7550d31: Revert "[llvm] llvm-tapi-diff".
Jun 3 2021, 9:12 PM
cishida committed rG5337c7550d31: Revert "[llvm] llvm-tapi-diff" (authored by cishida).
Revert "[llvm] llvm-tapi-diff"
Jun 3 2021, 9:12 PM
cishida added a reverting change for D101835: [llvm] llvm-tapi-diff: rG5337c7550d31: Revert "[llvm] llvm-tapi-diff".
Jun 3 2021, 9:12 PM · Restricted Project
cishida committed rGd1d36f7ad2ae: [llvm] llvm-tapi-diff (authored by spowell).
[llvm] llvm-tapi-diff
Jun 3 2021, 11:40 AM
cishida closed D101835: [llvm] llvm-tapi-diff.
Jun 3 2021, 11:40 AM · Restricted Project

May 19 2021

cishida added inline comments to D101835: [llvm] llvm-tapi-diff.
May 19 2021, 7:32 PM · Restricted Project

May 7 2021

cishida added inline comments to D101835: [llvm] llvm-tapi-diff.
May 7 2021, 4:36 PM · Restricted Project

May 6 2021

cishida committed rGc4ed142e695f: [llvm][TextAPI] add mapping from OS string to Platform (authored by cishida).
[llvm][TextAPI] add mapping from OS string to Platform
May 6 2021, 4:26 PM

May 4 2021

cishida added inline comments to D101835: [llvm] llvm-tapi-diff.
May 4 2021, 2:38 PM · Restricted Project

Apr 5 2021

cishida committed rG0116d04d04f2: [TextAPI] move source code files out of subdirectory, NFC (authored by cishida).
[TextAPI] move source code files out of subdirectory, NFC
Apr 5 2021, 10:27 AM
cishida closed D99811: [TextAPI] move source code files out of subdirectory, NFC.
Apr 5 2021, 10:27 AM · Restricted Project, Restricted Project, Restricted Project

Apr 2 2021

cishida requested review of D99811: [TextAPI] move source code files out of subdirectory, NFC.
Apr 2 2021, 12:07 PM · Restricted Project, Restricted Project, Restricted Project
cishida committed rG3a223cd4f3ad: [TextAPI] run clang-format on violating sections, NFC (authored by cishida).
[TextAPI] run clang-format on violating sections, NFC
Apr 2 2021, 11:45 AM

Apr 1 2021

cishida accepted D99673: [TextAPI] Add support for arm64_32.

LGTM

Apr 1 2021, 1:42 PM · Restricted Project

Feb 18 2021

cishida committed rGeb2eeeb76f7a: [llvm][TextAPI] add equality operator for InterfaceFile (authored by spowell).
[llvm][TextAPI] add equality operator for InterfaceFile
Feb 18 2021, 11:56 AM
cishida closed D96629: [llvm][TextAPI] add equality operator for InterfaceFile.
Feb 18 2021, 11:55 AM · Restricted Project
cishida accepted D96629: [llvm][TextAPI] add equality operator for InterfaceFile.

LGTM

Feb 18 2021, 10:04 AM · Restricted Project

Feb 17 2021

cishida added inline comments to D96629: [llvm][TextAPI] add equality operator for InterfaceFile.
Feb 17 2021, 1:24 PM · Restricted Project
cishida added inline comments to D96629: [llvm][TextAPI] add equality operator for InterfaceFile.
Feb 17 2021, 1:10 PM · Restricted Project

Feb 16 2021

cishida added inline comments to D96629: [llvm][TextAPI] add equality operator for InterfaceFile.
Feb 16 2021, 11:51 AM · Restricted Project

Jan 22 2021

cishida accepted D95259: [RGT][TextAPI] Remove a zero-trip loop and the assertions within it.

Thank you!

Jan 22 2021, 12:45 PM · Restricted Project

Oct 20 2020

cishida committed rGacb33cba6d45: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC (authored by cishida).
[llvm] Fix ODRViolations for VersionTuple YAML specializations NFC
Oct 20 2020, 6:31 PM
cishida closed D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC.
Oct 20 2020, 6:30 PM · Restricted Project
cishida updated the summary of D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC.
Oct 20 2020, 1:19 PM · Restricted Project
cishida added a reviewer for D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC: compnerd.
Oct 20 2020, 1:14 PM · Restricted Project
cishida updated the diff for D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC.

Address dblaikie's suggestion and move specialization into YAMLTraits.

Oct 20 2020, 1:13 PM · Restricted Project

Oct 19 2020

cishida requested review of D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC.
Oct 19 2020, 10:21 PM · Restricted Project

Sep 21 2020

cishida committed rG0b15cb70d318: [TextAPI] clean up auto usages in tests, NFC (authored by cishida).
[TextAPI] clean up auto usages in tests, NFC
Sep 21 2020, 8:42 AM

Aug 15 2020

cishida committed rG85d381eb02a2: [TextAPI] update DriverKit string value (authored by cishida).
[TextAPI] update DriverKit string value
Aug 15 2020, 6:47 AM

Aug 14 2020

cishida accepted D85594: [MachO] Add skeletal support for DriverKit platform.
Aug 14 2020, 12:34 PM · Restricted Project

Aug 13 2020

cishida added inline comments to D85594: [MachO] Add skeletal support for DriverKit platform.
Aug 13 2020, 11:02 PM · Restricted Project
cishida accepted D85594: [MachO] Add skeletal support for DriverKit platform.
Aug 13 2020, 9:38 PM · Restricted Project

Aug 12 2020

cishida added a comment to D84770: [llvm-libtool-darwin] Add support for -arch_only.

I think I need to add V8 support under llvm/include/llvm/TextAPI/MachO/Architecture.def here:

///
/// ARM64 architectures sorted by cpu sub type id.
///
ARCHINFO(arm64, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64_ALL, 64)
ARCHINFO(arm64e, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64E, 64)

What should be the first element for that tuple in case of V8 (arm64_v8 or arm64v8 or maybe something else) ? Thanks.

Hmm, what necessitates the TAPI patch? arm64_v8 seems fine to me, though @ributzka and @cishida should weigh in there.

Converting a yaml file with Subtype V8 to an object file requires this patch. I was trying to add a test for V8, but my yaml was incorrectly parsed as an object file with unknown architecture.

Aug 12 2020, 12:59 AM · Restricted Project
cishida added a comment to D85594: [MachO] Add skeletal support for DriverKit platform.
In D85594#2207080, @gkm wrote:

@tschuett, I prefer not to do anything that involves semantics for DriverKit, since I don't have any domain knowledge. For that matter, perhaps I shouldn't even follow-through with this diff, which I only embarked upon at your suggestion because the original author of the MachO -platform_version diff (I commandeered it) had a TODO comment. I can code-monkey the TBDv4 testcase via simple substitution, but what about TBDv1 .. TBDv3? IDK, and don't want to spend time determining minimum version# for DriverKit. Do you know that?

Aug 12 2020, 12:07 AM · Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rG5541dbb0c022: Merge pull request #984 from cyndyishida/tapi-weakdef-cherrypick (authored by cishida).
Merge pull request #984 from cyndyishida/tapi-weakdef-cherrypick
Jul 14 2020, 4:37 PM
cishida committed rGa08a41ea9c91: [llvm][MachO] fix adding weak def syms (authored by cishida).
[llvm][MachO] fix adding weak def syms
Jul 14 2020, 4:37 PM
GitHub <noreply@github.com> committed rGbdb7e469df4f: Merge pull request #768 from cyndyishida/apple/stable/20200108 (authored by cishida).
Merge pull request #768 from cyndyishida/apple/stable/20200108
Jul 14 2020, 4:22 PM
cishida committed rG8002f917938d: [llvm][TextAPI] add simulators to output (authored by cishida).
[llvm][TextAPI] add simulators to output
Jul 14 2020, 4:22 PM

Jun 30 2020

cishida committed rG89a0c4066b0e: [clang][diagnostics] Add '-Wundef-prefix' warning option (authored by zixuw).
[clang][diagnostics] Add '-Wundef-prefix' warning option
Jun 30 2020, 2:10 PM
cishida closed D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
Jun 30 2020, 2:10 PM · Restricted Project

Jun 15 2020

cishida committed rG2ba320846b1b: [llvm][TextAPI/MachO] clean up auto usages in tests, NFC (authored by cishida).
[llvm][TextAPI/MachO] clean up auto usages in tests, NFC
Jun 15 2020, 8:23 PM

Jun 11 2020

cishida accepted D81717: [llvm/Object] Reimplment basic_symbol_iterator in TapiFile.

Thanks for fixing this! one nit but LGTM

Jun 11 2020, 11:57 PM · Restricted Project
cishida committed rG28fefcc83c52: [llvm][llvm-nm] add TextAPI/MachO support (authored by cishida).
[llvm][llvm-nm] add TextAPI/MachO support
Jun 11 2020, 7:16 PM
cishida closed D81614: [llvm][llvm-nm] add TextAPI/MachO support.
Jun 11 2020, 7:16 PM · Restricted Project
cishida added a comment to D81614: [llvm][llvm-nm] add TextAPI/MachO support.

the landed patch has applied MaskRay's comments.

Jun 11 2020, 7:15 PM · Restricted Project
cishida updated the diff for D81614: [llvm][llvm-nm] add TextAPI/MachO support.

adopintg jhenderson's comments to increase Readablity & Coding Guidelines

Jun 11 2020, 8:46 AM · Restricted Project

Jun 10 2020

cishida updated the diff for D81614: [llvm][llvm-nm] add TextAPI/MachO support.

Updating to address comments, add more const correctness, fix casing on FileCheck

Jun 10 2020, 4:08 PM · Restricted Project
cishida added inline comments to D81614: [llvm][llvm-nm] add TextAPI/MachO support.
Jun 10 2020, 4:08 PM · Restricted Project
cishida created D81614: [llvm][llvm-nm] add TextAPI/MachO support.
Jun 10 2020, 3:02 PM · Restricted Project

Apr 2 2020

cishida committed rGfd4d07517b2c: [llvm][TextAPI] adding inlining reexported libraries support (authored by cishida).
[llvm][TextAPI] adding inlining reexported libraries support
Apr 2 2020, 1:34 PM
cishida closed D67646: [llvm][TextAPI] adding inlining reexported libraries support.
Apr 2 2020, 1:34 PM · Restricted Project
cishida added a comment to D67646: [llvm][TextAPI] adding inlining reexported libraries support.

the lint corrections will be/have been made in the revision that lands.

Apr 2 2020, 12:28 PM · Restricted Project

Mar 31 2020

cishida retitled D67646: [llvm][TextAPI] adding inlining reexported libraries support from [TextAPI] Add Multiple Document Support to TBDv3 to [llvm][TextAPI] adding inlining reexported libraries support.
Mar 31 2020, 11:58 PM · Restricted Project
cishida updated the diff for D67646: [llvm][TextAPI] adding inlining reexported libraries support.

Updating this patch to just create inlining framework support, and I will attach lib/Object & nm support in a seperate patch

Mar 31 2020, 3:59 PM · Restricted Project

Mar 26 2020

cishida committed rGd26e0bcfba6c: [llvm][TextAPI/MachO] silence clang-tidy warnings, NFC (authored by cishida).
[llvm][TextAPI/MachO] silence clang-tidy warnings, NFC
Mar 26 2020, 4:53 PM

Mar 5 2020

cishida committed rGa0cd41342647: [TextAPI] Teach TextAPI about arm64e (authored by cishida).
[TextAPI] Teach TextAPI about arm64e
Mar 5 2020, 1:45 PM
cishida closed D75688: [TextAPI] Teach TextAPI about arm64e.
Mar 5 2020, 1:45 PM · Restricted Project
cishida accepted D75688: [TextAPI] Teach TextAPI about arm64e.

LGTM, Jürgen approved via email as well.

Mar 5 2020, 1:44 PM · Restricted Project
cishida updated the diff for D75688: [TextAPI] Teach TextAPI about arm64e.

updating Kuba's patch with tests

Mar 5 2020, 12:39 PM · Restricted Project

Mar 2 2020

cishida committed rGb796acbba24f: [llvm][MachO] fix adding weak def syms (authored by cishida).
[llvm][MachO] fix adding weak def syms
Mar 2 2020, 5:15 PM

Feb 25 2020

cishida committed rG6d2372ce584f: [llvm][TextAPI] rename test vars, NFC (authored by cishida).
[llvm][TextAPI] rename test vars, NFC
Feb 25 2020, 2:30 PM

Feb 12 2020

cishida accepted D73332: [llvm][TextAPI/MachO] Extract common code into unittest helper (NFC).

LGTM, thank you for cleaning this up.

Feb 12 2020, 4:22 PM · Restricted Project
cishida accepted D73330: [llvm][TextAPI/MachO] Extend TBD_V4 unittest to verify writing.

LGTM

Feb 12 2020, 4:22 PM · Restricted Project

Feb 11 2020

cishida committed rG8c3d0d6a5f5a: [llvm][TextAPI] add simulators to output (authored by cishida).
[llvm][TextAPI] add simulators to output
Feb 11 2020, 10:42 AM
cishida closed D74416: [llvm][TextAPI] add simulators to output.
Feb 11 2020, 10:42 AM · Restricted Project
cishida added a comment to D74416: [llvm][TextAPI] add simulators to output.

will resolve the warning: invalid case style for variable '...' [readability-identifier-naming] in a future patch since it'll cause mismatching conventions through the whole file.

Feb 11 2020, 10:42 AM · Restricted Project
cishida updated the diff for D74416: [llvm][TextAPI] add simulators to output.

Updating to use LLVM_FALLTHROUGH for cases

Feb 11 2020, 9:12 AM · Restricted Project
cishida added inline comments to D74416: [llvm][TextAPI] add simulators to output.
Feb 11 2020, 8:44 AM · Restricted Project
cishida created D74416: [llvm][TextAPI] add simulators to output.
Feb 11 2020, 7:59 AM · Restricted Project

Jan 29 2020

cishida reopened D73640: [SmallString] Add explicit conversion to std::string.

This indirection seems like unnecessary work. Could you reimplement this as a direct conversion to std::string?

Jan 29 2020, 1:40 PM · Restricted Project

Jan 27 2020

cishida accepted D73325: [llvm][TextAPI/MachO] Support writing single macCatalyst platform.

LGTM, thank you!

Jan 27 2020, 8:11 AM · Restricted Project

Jan 23 2020

cishida accepted D73328: [llvm][TextAPI/MachO] Extend TBD_V3 unittest to verify writing.

small comment, otherwise LGTM

Jan 23 2020, 11:19 PM · Restricted Project
cishida added a comment to D73326: [TAPI] Update variable names to match TAPI version in unit tests. (NFC).

nit: probably should update [TAPI] to [llvm][TextAPI/MachO] in the commit header.

Jan 23 2020, 10:52 PM · Restricted Project
cishida accepted D73326: [TAPI] Update variable names to match TAPI version in unit tests. (NFC).

LGTM, thanks!

Jan 23 2020, 10:52 PM · Restricted Project

Jan 16 2020

cishida committed rG24fca5cd7128: [lldb] add to gdb to lldb doc (authored by cishida).
[lldb] add to gdb to lldb doc
Jan 16 2020, 8:08 PM
cishida closed D72898: [lldb] add to gdb to lldb doc.
Jan 16 2020, 8:08 PM · Restricted Project
cishida updated the diff for D72898: [lldb] add to gdb to lldb doc.

Updating to fix copy/paste error

Jan 16 2020, 7:58 PM · Restricted Project
cishida created D72898: [lldb] add to gdb to lldb doc.
Jan 16 2020, 7:03 PM · Restricted Project

Dec 5 2019

cishida added inline comments to D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs..
Dec 5 2019, 7:30 AM · Restricted Project

Nov 18 2019

cishida committed rG9b36f2cfd98d: Fix iOSDarwin()'s doc comment. (authored by cishida).
Fix iOSDarwin()'s doc comment.
Nov 18 2019, 1:25 PM
cishida closed D70364: Fix iOSDarwin()'s doc comment..
Nov 18 2019, 1:24 PM · Restricted Project

Oct 9 2019

cishida committed rGf9d8162b573d: Reland "[TextAPI] Introduce TBDv4" (authored by cishida).
Reland "[TextAPI] Introduce TBDv4"
Oct 9 2019, 9:26 PM