Page MenuHomePhabricator

cishida (Cyndy Ishida)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2019, 1:26 PM (182 w, 6 d)

Recent Activity

Dec 13 2022

cishida committed rGac20a3a5b530: [llvm][Object] set SF_Hidden flag for MachO files (authored by cishida).
[llvm][Object] set SF_Hidden flag for MachO files
Dec 13 2022, 2:59 PM · Restricted Project, Restricted Project
cishida closed D139862: [llvm][Object] set SF_Hidden flag for MachO files.
Dec 13 2022, 2:59 PM · Restricted Project, Restricted Project, Restricted Project
cishida updated the diff for D139862: [llvm][Object] set SF_Hidden flag for MachO files.

Update lld tests to include .hidden attribute.

Dec 13 2022, 10:05 AM · Restricted Project, Restricted Project, Restricted Project

Dec 12 2022

cishida requested review of D139862: [llvm][Object] set SF_Hidden flag for MachO files.
Dec 12 2022, 10:54 AM · Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

cishida accepted D135340: [PGO] Make emitted symbols hidden.

This change LGTM. My understanding of the history here, is that these symbols were exported expecting to be eventually referenced when profiling options are used but weren't always consistently exported. This kind of inconsistency of symbol exports breaks TAPI verification. In the recent past we've had a similar issue where the symbols got optimized out based on the optimization level. If __llvm_profile_raw_version and __llvm_profile_filename always have hidden visibility this should be fine for TAPI.

Oct 13 2022, 12:44 PM · Restricted Project, Restricted Project, Restricted Project

Sep 19 2022

cishida committed rGe6cdb0031529: [llvm][TextAPI] add driverkit as supported platform for older tbd (authored by cishida).
[llvm][TextAPI] add driverkit as supported platform for older tbd
Sep 19 2022, 3:09 PM · Restricted Project, Restricted Project

May 24 2022

cishida committed rGa1a14e817eeb: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls. (authored by cishida).
[Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.
May 24 2022, 8:46 AM · Restricted Project, Restricted Project
cishida closed D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls..
May 24 2022, 8:46 AM · Restricted Project, Restricted Project
cishida added inline comments to D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls..
May 24 2022, 6:08 AM · Restricted Project, Restricted Project

May 23 2022

cishida updated the diff for D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls..

Restrict using the canonical decl's source location to only when the prototype was inferred from previously seen decl.

May 23 2022, 5:39 PM · Restricted Project, Restricted Project
cishida requested review of D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls..
May 23 2022, 4:47 PM · Restricted Project, Restricted Project

May 4 2022

cishida committed rGb6c67c3c6789: [clang] Track how headers get included generally during lookup time (authored by cishida).
[clang] Track how headers get included generally during lookup time
May 4 2022, 9:58 AM · Restricted Project, Restricted Project
cishida closed D124638: [clang] Track how headers get included generally during lookup time.
May 4 2022, 9:58 AM · Restricted Project, Restricted Project

May 3 2022

cishida updated the diff for D124638: [clang] Track how headers get included generally during lookup time.

Hold include name in HeaderSearch itself, keeping HeaderFileInfo lightweight.

May 3 2022, 3:12 PM · Restricted Project, Restricted Project

May 2 2022

cishida added inline comments to D124638: [clang] Track how headers get included generally during lookup time.
May 2 2022, 12:08 PM · Restricted Project, Restricted Project
cishida added a comment to D124638: [clang] Track how headers get included generally during lookup time.

Can you describe how come the check is not reliable without this patch? It might be worth fixing the underlying reason for the unreliability first.

May 2 2022, 11:57 AM · Restricted Project, Restricted Project

Apr 28 2022

cishida requested review of D124638: [clang] Track how headers get included generally during lookup time.
Apr 28 2022, 2:29 PM · Restricted Project, Restricted Project

Apr 15 2022

cishida added a comment to D123831: [clang][extract-api] Use relative includes.

we might not always want to transform an absolute path because the resulting relative include name might get remapped in a headermap, for example in test known_files_only_hmap.c. But how does it work with modules where we need relative includes? Is the setup in known_files_only_hmap even valid?

Apr 15 2022, 6:24 PM · Restricted Project, Restricted Project

Apr 6 2022

cishida accepted D123148: [clang][extract-api] Process only APIs declared in inputs.

LGTM

Apr 6 2022, 1:00 PM · Restricted Project, Restricted Project

Apr 5 2022

cishida added inline comments to D123148: [clang][extract-api] Process only APIs declared in inputs.
Apr 5 2022, 12:22 PM · Restricted Project, Restricted Project

Jan 26 2022

cishida added inline comments to D117830: [HeaderSearch] Track framework name in LookupFile.
Jan 26 2022, 11:12 AM · Restricted Project

Jan 24 2022

cishida accepted D117830: [HeaderSearch] Track framework name in LookupFile.

I followed up about this approach with folks more familiar with SourceKit and seems fine, so LGTM. I'd wait a day to see if Jan has any concerns.

Jan 24 2022, 4:32 PM · Restricted Project
cishida added a comment to D117830: [HeaderSearch] Track framework name in LookupFile.

My understanding for the header map restriction is because headermaps are generally emitted once for a framework build and only consumed to build such framework and this struct information is only queried during this.
It sounds like for the clangd support, you're not as interested in what framework is being built, but the name of the framework when included via framework style in any context. Is that correct? It seems fine to extend its use cases. @jansvoboda11 What do you think?

Jan 24 2022, 1:13 PM · Restricted Project

Jan 12 2022

cishida accepted D117163: Replace PlatformKind with PlatformType..
Jan 12 2022, 5:56 PM · Restricted Project, Restricted Project

Dec 18 2021

cishida committed rG4a878c14c49e: [llvm-tapi-diff] rename tests for clarity, NFC (authored by cishida).
[llvm-tapi-diff] rename tests for clarity, NFC
Dec 18 2021, 6:09 PM
cishida committed rG982604cc08ca: [llvm-tapi-diff] Replicate diff utility error handling (authored by cishida).
[llvm-tapi-diff] Replicate diff utility error handling
Dec 18 2021, 10:14 AM
cishida closed D115905: [llvm-tapi-diff] Replicate diff utility error handling.
Dec 18 2021, 10:13 AM · Restricted Project

Dec 16 2021

cishida requested review of D115905: [llvm-tapi-diff] Replicate diff utility error handling.
Dec 16 2021, 1:57 PM · Restricted Project

Oct 15 2021

cishida committed rG395e1fe30574: [clang] Capture Framework when HeaderSearch is resolved via headermap (authored by cishida).
[clang] Capture Framework when HeaderSearch is resolved via headermap
Oct 15 2021, 9:18 AM
cishida closed D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap.
Oct 15 2021, 9:18 AM · Restricted Project
cishida added a comment to D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap.

LGTM.

As a follow-up, do you think it would make sense to improve the documentation/comments around "index header maps"? Variable names refer to indexing while the documentation talks about building frameworks, which is confusing without referring back to the original Radar.

Oct 15 2021, 8:30 AM · Restricted Project

Oct 14 2021

cishida updated the diff for D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap.

Fix windows build.

Oct 14 2021, 7:57 AM · Restricted Project

Oct 8 2021

cishida updated the summary of D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap.
Oct 8 2021, 4:13 PM · Restricted Project
cishida requested review of D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap.
Oct 8 2021, 4:06 PM · Restricted Project

Jul 23 2021

cishida committed rG8594a24d63d8: [llvm][NFC] Fix typos in Errc.h description (authored by cishida).
[llvm][NFC] Fix typos in Errc.h description
Jul 23 2021, 11:57 AM

Jun 23 2021

cishida committed rGfb9f9497dc01: [llvm-tapi-diff] Wrap empty string around StringLiteral NFC (authored by cishida).
[llvm-tapi-diff] Wrap empty string around StringLiteral NFC
Jun 23 2021, 11:41 AM
cishida committed rG56709b869570: [TextAPI] add symbol name prefixes to central location, NFC (authored by cishida).
[TextAPI] add symbol name prefixes to central location, NFC
Jun 23 2021, 11:24 AM

Jun 9 2021

cishida committed rG5b5ab80e3195: Reland "[llvm] llvm-tapi-diff" (authored by spowell).
Reland "[llvm] llvm-tapi-diff"
Jun 9 2021, 9:21 PM
cishida added a reverting change for rG20126c9fd4af: Reland "[llvm] llvm-tapi-diff": rGe7b755ecb140: Revert "Reland "[llvm] llvm-tapi-diff"".
Jun 9 2021, 1:52 PM
cishida added a reverting change for D101835: [llvm] llvm-tapi-diff: rGe7b755ecb140: Revert "Reland "[llvm] llvm-tapi-diff"".
Jun 9 2021, 1:52 PM · Restricted Project
cishida committed rGe7b755ecb140: Revert "Reland "[llvm] llvm-tapi-diff"" (authored by cishida).
Revert "Reland "[llvm] llvm-tapi-diff""
Jun 9 2021, 1:52 PM
cishida added a reverting change for rG90a26a41e9ce: [llvm-tapi-diff] Apply stable sorting to output: rG1899cb7d0eae: Revert "[llvm-tapi-diff] Apply stable sorting to output".
Jun 9 2021, 1:50 PM
cishida committed rG1899cb7d0eae: Revert "[llvm-tapi-diff] Apply stable sorting to output" (authored by cishida).
Revert "[llvm-tapi-diff] Apply stable sorting to output"
Jun 9 2021, 1:50 PM
cishida committed rG90a26a41e9ce: [llvm-tapi-diff] Apply stable sorting to output (authored by spowell).
[llvm-tapi-diff] Apply stable sorting to output
Jun 9 2021, 1:10 PM
cishida committed rG20126c9fd4af: Reland "[llvm] llvm-tapi-diff" (authored by spowell).
Reland "[llvm] llvm-tapi-diff"
Jun 9 2021, 10:38 AM

Jun 3 2021

cishida added a comment to D101835: [llvm] llvm-tapi-diff.

The tests for this tool are observed to be failing on multiple big-endian platforms:
clang-s390x-linux: https://lab.llvm.org/buildbot/#/builders/94/builds/4116
clang-ppc64be-linux: https://lab.llvm.org/buildbot/#/builders/52/builds/8035

Jun 3 2021, 9:15 PM · Restricted Project
cishida added a reverting change for rGd1d36f7ad2ae: [llvm] llvm-tapi-diff: rG5337c7550d31: Revert "[llvm] llvm-tapi-diff".
Jun 3 2021, 9:12 PM
cishida committed rG5337c7550d31: Revert "[llvm] llvm-tapi-diff" (authored by cishida).
Revert "[llvm] llvm-tapi-diff"
Jun 3 2021, 9:12 PM
cishida added a reverting change for D101835: [llvm] llvm-tapi-diff: rG5337c7550d31: Revert "[llvm] llvm-tapi-diff".
Jun 3 2021, 9:12 PM · Restricted Project
cishida committed rGd1d36f7ad2ae: [llvm] llvm-tapi-diff (authored by spowell).
[llvm] llvm-tapi-diff
Jun 3 2021, 11:40 AM
cishida closed D101835: [llvm] llvm-tapi-diff.
Jun 3 2021, 11:40 AM · Restricted Project

May 19 2021

cishida added inline comments to D101835: [llvm] llvm-tapi-diff.
May 19 2021, 7:32 PM · Restricted Project

May 7 2021

cishida added inline comments to D101835: [llvm] llvm-tapi-diff.
May 7 2021, 4:36 PM · Restricted Project

May 6 2021

cishida committed rGc4ed142e695f: [llvm][TextAPI] add mapping from OS string to Platform (authored by cishida).
[llvm][TextAPI] add mapping from OS string to Platform
May 6 2021, 4:26 PM

May 4 2021

cishida added inline comments to D101835: [llvm] llvm-tapi-diff.
May 4 2021, 2:38 PM · Restricted Project

Apr 5 2021

cishida committed rG0116d04d04f2: [TextAPI] move source code files out of subdirectory, NFC (authored by cishida).
[TextAPI] move source code files out of subdirectory, NFC
Apr 5 2021, 10:27 AM
cishida closed D99811: [TextAPI] move source code files out of subdirectory, NFC.
Apr 5 2021, 10:27 AM · Restricted Project, Restricted Project, Restricted Project

Apr 2 2021

cishida requested review of D99811: [TextAPI] move source code files out of subdirectory, NFC.
Apr 2 2021, 12:07 PM · Restricted Project, Restricted Project, Restricted Project
cishida committed rG3a223cd4f3ad: [TextAPI] run clang-format on violating sections, NFC (authored by cishida).
[TextAPI] run clang-format on violating sections, NFC
Apr 2 2021, 11:45 AM

Apr 1 2021

cishida accepted D99673: [TextAPI] Add support for arm64_32.

LGTM

Apr 1 2021, 1:42 PM · Restricted Project

Feb 18 2021

cishida committed rGeb2eeeb76f7a: [llvm][TextAPI] add equality operator for InterfaceFile (authored by spowell).
[llvm][TextAPI] add equality operator for InterfaceFile
Feb 18 2021, 11:56 AM
cishida closed D96629: [llvm][TextAPI] add equality operator for InterfaceFile.
Feb 18 2021, 11:55 AM · Restricted Project
cishida accepted D96629: [llvm][TextAPI] add equality operator for InterfaceFile.

LGTM

Feb 18 2021, 10:04 AM · Restricted Project

Feb 17 2021

cishida added inline comments to D96629: [llvm][TextAPI] add equality operator for InterfaceFile.
Feb 17 2021, 1:24 PM · Restricted Project
cishida added inline comments to D96629: [llvm][TextAPI] add equality operator for InterfaceFile.
Feb 17 2021, 1:10 PM · Restricted Project

Feb 16 2021

cishida added inline comments to D96629: [llvm][TextAPI] add equality operator for InterfaceFile.
Feb 16 2021, 11:51 AM · Restricted Project

Jan 22 2021

cishida accepted D95259: [RGT][TextAPI] Remove a zero-trip loop and the assertions within it.

Thank you!

Jan 22 2021, 12:45 PM · Restricted Project

Oct 20 2020

cishida committed rGacb33cba6d45: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC (authored by cishida).
[llvm] Fix ODRViolations for VersionTuple YAML specializations NFC
Oct 20 2020, 6:31 PM
cishida closed D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC.
Oct 20 2020, 6:30 PM · Restricted Project
cishida updated the summary of D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC.
Oct 20 2020, 1:19 PM · Restricted Project
cishida added a reviewer for D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC: compnerd.
Oct 20 2020, 1:14 PM · Restricted Project
cishida updated the diff for D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC.

Address dblaikie's suggestion and move specialization into YAMLTraits.

Oct 20 2020, 1:13 PM · Restricted Project

Oct 19 2020

cishida requested review of D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC.
Oct 19 2020, 10:21 PM · Restricted Project

Sep 21 2020

cishida committed rG0b15cb70d318: [TextAPI] clean up auto usages in tests, NFC (authored by cishida).
[TextAPI] clean up auto usages in tests, NFC
Sep 21 2020, 8:42 AM

Aug 15 2020

cishida committed rG85d381eb02a2: [TextAPI] update DriverKit string value (authored by cishida).
[TextAPI] update DriverKit string value
Aug 15 2020, 6:47 AM

Aug 14 2020

cishida accepted D85594: [MachO] Add skeletal support for DriverKit platform.
Aug 14 2020, 12:34 PM · Restricted Project

Aug 13 2020

cishida added inline comments to D85594: [MachO] Add skeletal support for DriverKit platform.
Aug 13 2020, 11:02 PM · Restricted Project
cishida accepted D85594: [MachO] Add skeletal support for DriverKit platform.
Aug 13 2020, 9:38 PM · Restricted Project

Aug 12 2020

cishida added a comment to D84770: [llvm-libtool-darwin] Add support for -arch_only.

I think I need to add V8 support under llvm/include/llvm/TextAPI/MachO/Architecture.def here:

///
/// ARM64 architectures sorted by cpu sub type id.
///
ARCHINFO(arm64, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64_ALL, 64)
ARCHINFO(arm64e, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64E, 64)

What should be the first element for that tuple in case of V8 (arm64_v8 or arm64v8 or maybe something else) ? Thanks.

Hmm, what necessitates the TAPI patch? arm64_v8 seems fine to me, though @ributzka and @cishida should weigh in there.

Converting a yaml file with Subtype V8 to an object file requires this patch. I was trying to add a test for V8, but my yaml was incorrectly parsed as an object file with unknown architecture.

Aug 12 2020, 12:59 AM · Restricted Project
cishida added a comment to D85594: [MachO] Add skeletal support for DriverKit platform.
In D85594#2207080, @gkm wrote:

@tschuett, I prefer not to do anything that involves semantics for DriverKit, since I don't have any domain knowledge. For that matter, perhaps I shouldn't even follow-through with this diff, which I only embarked upon at your suggestion because the original author of the MachO -platform_version diff (I commandeered it) had a TODO comment. I can code-monkey the TBDv4 testcase via simple substitution, but what about TBDv1 .. TBDv3? IDK, and don't want to spend time determining minimum version# for DriverKit. Do you know that?

Aug 12 2020, 12:07 AM · Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rG5541dbb0c022: Merge pull request #984 from cyndyishida/tapi-weakdef-cherrypick (authored by cishida).
Merge pull request #984 from cyndyishida/tapi-weakdef-cherrypick
Jul 14 2020, 4:37 PM
cishida committed rGa08a41ea9c91: [llvm][MachO] fix adding weak def syms (authored by cishida).
[llvm][MachO] fix adding weak def syms
Jul 14 2020, 4:37 PM
GitHub <noreply@github.com> committed rGbdb7e469df4f: Merge pull request #768 from cyndyishida/apple/stable/20200108 (authored by cishida).
Merge pull request #768 from cyndyishida/apple/stable/20200108
Jul 14 2020, 4:22 PM
cishida committed rG8002f917938d: [llvm][TextAPI] add simulators to output (authored by cishida).
[llvm][TextAPI] add simulators to output
Jul 14 2020, 4:22 PM

Jun 30 2020

cishida committed rG89a0c4066b0e: [clang][diagnostics] Add '-Wundef-prefix' warning option (authored by zixuw).
[clang][diagnostics] Add '-Wundef-prefix' warning option
Jun 30 2020, 2:10 PM
cishida closed D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
Jun 30 2020, 2:10 PM · Restricted Project

Jun 15 2020

cishida committed rG2ba320846b1b: [llvm][TextAPI/MachO] clean up auto usages in tests, NFC (authored by cishida).
[llvm][TextAPI/MachO] clean up auto usages in tests, NFC
Jun 15 2020, 8:23 PM

Jun 11 2020

cishida accepted D81717: [llvm/Object] Reimplment basic_symbol_iterator in TapiFile.

Thanks for fixing this! one nit but LGTM

Jun 11 2020, 11:57 PM · Restricted Project
cishida committed rG28fefcc83c52: [llvm][llvm-nm] add TextAPI/MachO support (authored by cishida).
[llvm][llvm-nm] add TextAPI/MachO support
Jun 11 2020, 7:16 PM
cishida closed D81614: [llvm][llvm-nm] add TextAPI/MachO support.
Jun 11 2020, 7:16 PM · Restricted Project
cishida added a comment to D81614: [llvm][llvm-nm] add TextAPI/MachO support.

the landed patch has applied MaskRay's comments.

Jun 11 2020, 7:15 PM · Restricted Project
cishida updated the diff for D81614: [llvm][llvm-nm] add TextAPI/MachO support.

adopintg jhenderson's comments to increase Readablity & Coding Guidelines

Jun 11 2020, 8:46 AM · Restricted Project

Jun 10 2020

cishida updated the diff for D81614: [llvm][llvm-nm] add TextAPI/MachO support.

Updating to address comments, add more const correctness, fix casing on FileCheck

Jun 10 2020, 4:08 PM · Restricted Project
cishida added inline comments to D81614: [llvm][llvm-nm] add TextAPI/MachO support.
Jun 10 2020, 4:08 PM · Restricted Project
cishida created D81614: [llvm][llvm-nm] add TextAPI/MachO support.
Jun 10 2020, 3:02 PM · Restricted Project

Apr 2 2020

cishida committed rGfd4d07517b2c: [llvm][TextAPI] adding inlining reexported libraries support (authored by cishida).
[llvm][TextAPI] adding inlining reexported libraries support
Apr 2 2020, 1:34 PM
cishida closed D67646: [llvm][TextAPI] adding inlining reexported libraries support.
Apr 2 2020, 1:34 PM · Restricted Project
cishida added a comment to D67646: [llvm][TextAPI] adding inlining reexported libraries support.

the lint corrections will be/have been made in the revision that lands.

Apr 2 2020, 12:28 PM · Restricted Project

Mar 31 2020

cishida retitled D67646: [llvm][TextAPI] adding inlining reexported libraries support from [TextAPI] Add Multiple Document Support to TBDv3 to [llvm][TextAPI] adding inlining reexported libraries support.
Mar 31 2020, 11:58 PM · Restricted Project
cishida updated the diff for D67646: [llvm][TextAPI] adding inlining reexported libraries support.

Updating this patch to just create inlining framework support, and I will attach lib/Object & nm support in a seperate patch

Mar 31 2020, 3:59 PM · Restricted Project