User Details
- User Since
- Jul 29 2019, 1:26 PM (182 w, 6 d)
Dec 13 2022
Update lld tests to include .hidden attribute.
Dec 12 2022
Oct 13 2022
This change LGTM. My understanding of the history here, is that these symbols were exported expecting to be eventually referenced when profiling options are used but weren't always consistently exported. This kind of inconsistency of symbol exports breaks TAPI verification. In the recent past we've had a similar issue where the symbols got optimized out based on the optimization level. If __llvm_profile_raw_version and __llvm_profile_filename always have hidden visibility this should be fine for TAPI.
Sep 19 2022
May 24 2022
May 23 2022
Restrict using the canonical decl's source location to only when the prototype was inferred from previously seen decl.
May 4 2022
May 3 2022
Hold include name in HeaderSearch itself, keeping HeaderFileInfo lightweight.
May 2 2022
Apr 28 2022
Apr 15 2022
we might not always want to transform an absolute path because the resulting relative include name might get remapped in a headermap, for example in test known_files_only_hmap.c. But how does it work with modules where we need relative includes? Is the setup in known_files_only_hmap even valid?
Apr 6 2022
LGTM
Apr 5 2022
Jan 26 2022
Jan 24 2022
I followed up about this approach with folks more familiar with SourceKit and seems fine, so LGTM. I'd wait a day to see if Jan has any concerns.
My understanding for the header map restriction is because headermaps are generally emitted once for a framework build and only consumed to build such framework and this struct information is only queried during this.
It sounds like for the clangd support, you're not as interested in what framework is being built, but the name of the framework when included via framework style in any context. Is that correct? It seems fine to extend its use cases. @jansvoboda11 What do you think?
Jan 12 2022
Dec 18 2021
Dec 16 2021
Oct 15 2021
Oct 14 2021
Fix windows build.
Oct 8 2021
Jul 23 2021
Jun 23 2021
Jun 9 2021
Jun 3 2021
May 19 2021
May 7 2021
May 6 2021
May 4 2021
Apr 5 2021
Apr 2 2021
Apr 1 2021
LGTM
Feb 18 2021
LGTM
Feb 17 2021
Feb 16 2021
Jan 22 2021
Thank you!
Oct 20 2020
Address dblaikie's suggestion and move specialization into YAMLTraits.
Oct 19 2020
Sep 21 2020
Aug 15 2020
Aug 14 2020
Aug 13 2020
Aug 12 2020
Jul 14 2020
Jun 30 2020
Jun 15 2020
Jun 11 2020
Thanks for fixing this! one nit but LGTM
the landed patch has applied MaskRay's comments.
adopintg jhenderson's comments to increase Readablity & Coding Guidelines
Jun 10 2020
Updating to address comments, add more const correctness, fix casing on FileCheck
Apr 2 2020
the lint corrections will be/have been made in the revision that lands.
Mar 31 2020
Updating this patch to just create inlining framework support, and I will attach lib/Object & nm support in a seperate patch