Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D85686
[CUDA][HIP] Do not externalize implicit constant static variable ClosedPublic Authored by yaxunl on Aug 10 2020, 1:42 PM.
Details
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Aug 10 2020, 1:51 PM Closed by commit rGfb04d7b4a698: [CUDA][HIP] Do not externalize implicit constant static variable (authored by yaxunl). · Explain WhyAug 10 2020, 4:13 PM This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done.
Revision Contents
Diff 284523 clang/include/clang/AST/ASTContext.h
clang/lib/AST/ASTContext.cpp
clang/lib/Sema/SemaExpr.cpp
clang/test/CodeGenCUDA/static-device-var-no-rdc.cu
|
I'd include __device__ vars into the !IsImplicit check. While we may not implicitly add the attribute now, for consistency sake they should be treated the same.