Page MenuHomePhabricator

[CUDA][HIP] Do not externalize implicit constant static variable
ClosedPublic

Authored by yaxunl on Aug 10 2020, 1:42 PM.

Diff Detail

Event Timeline

yaxunl requested review of this revision.Aug 10 2020, 1:42 PM
yaxunl created this revision.
tra accepted this revision.Aug 10 2020, 1:51 PM
tra added inline comments.
clang/lib/AST/ASTContext.cpp
11196

I'd include __device__ vars into the !IsImplicit check. While we may not implicitly add the attribute now, for consistency sake they should be treated the same.

This revision is now accepted and ready to land.Aug 10 2020, 1:51 PM
yaxunl marked an inline comment as done.Aug 10 2020, 3:37 PM
yaxunl added inline comments.
clang/lib/AST/ASTContext.cpp
11196

will do when committing.

This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2020, 4:13 PM