Page MenuHomePhabricator

[clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`
Needs ReviewPublic

Authored by fghanim on Aug 9 2020, 12:33 PM.

Details

Summary

ADD support to allow omp single to be CG-ed by the OMPBuilder. This
also uses the OMPBuilder to generate __kmpc_copyprivate calls.

Diff Detail

Event Timeline

fghanim created this revision.Aug 9 2020, 12:33 PM
fghanim requested review of this revision.Aug 9 2020, 12:33 PM

Feel free to add other reviewers. Thanks.

Before I start, Why is this change all new code and no modification or deletion of existing Clang functionality for omp single/copyprivate?

Before I start, Why is this change all new code and no modification or deletion of existing Clang functionality for omp single/copyprivate?

Because the OMPBuilder currently is not the default way to CG OMP code in clang, which means the old way needs to keep working. So, we cannot delete or modify anything, we can only add the OMPBuilder specific code, and condition its usage on whether -fopenmp-enable-irbuilder flag has been issued, or not.

What is the plan for this patch?

What is the plan for this patch?

Waiting on you to review it ;)