Page MenuHomePhabricator

[Darwin] [Driver] Clang should invoke dsymutil for multiarch builds
AcceptedPublic

Authored by dsanders on Aug 4 2020, 2:11 PM.

Details

Summary

Much like with debug info with LTO, this case also uses temporary
object files and therefore needs to externalize it before the
temporary files are deleted

Depends on D84565

Diff Detail

Unit TestsFailed

TimeTest
250 mslinux > Clang.Driver::darwin-dsymutil.c
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -target x86_64-apple-darwin10 -ccc-print-phases -arch i386 -arch x86_64 /mnt/disks/ssd0/agent/llvm-project/clang/test/Driver/darwin-dsymutil.c -g 2> /mnt/disks/ssd0/agent/llvm-project/build/tools/clang/test/Driver/Output/darwin-dsymutil.c.tmp
2,600 mswindows > Clang.Driver::darwin-dsymutil.c
Script: -- : 'RUN: at line 3'; c:\ws\w32-1\llvm-project\premerge-checks\build\bin\clang.exe -target x86_64-apple-darwin10 -ccc-print-phases -arch i386 -arch x86_64 C:\ws\w32-1\llvm-project\premerge-checks\clang\test\Driver\darwin-dsymutil.c -g 2> C:\ws\w32-1\llvm-project\premerge-checks\build\tools\clang\test\Driver\Output\darwin-dsymutil.c.tmp

Event Timeline

dsanders created this revision.Aug 4 2020, 2:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2020, 2:11 PM
dsanders requested review of this revision.Aug 4 2020, 2:11 PM
aprantl added inline comments.Aug 6 2020, 12:47 PM
clang/test/Driver/darwin-dsymutil.c
74

Is a.out the lipoed fat binary? If yes this LGTM

JDevlieghere accepted this revision.Aug 7 2020, 9:08 AM
This revision is now accepted and ready to land.Aug 7 2020, 9:08 AM
beanz added inline comments.Aug 7 2020, 10:09 AM
clang/test/Driver/darwin-dsymutil.c
74

Yes.