Page MenuHomePhabricator

[NFC][AArch64] Refactor getArgumentPopSize
ClosedPublic

Authored by kyulee on Jul 9 2020, 12:08 AM.

Details

Summary

This refactors getArgumentPopSize() to prepare for D76570

Diff Detail

Event Timeline

kyulee created this revision.Jul 9 2020, 12:08 AM
plotfi accepted this revision.Jul 9 2020, 12:22 AM
plotfi added subscribers: thegameg, aemerson.

LGTM, but I'd like @thegameg or @aemerson to take a look as well. Thanks!

llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
190

I think this could be a nicer refactoring, for a future NFC, but ignore this for now (in interest of straight forward NFC reviewing):

const bool IsTailCallReturn = (MBB.end() != MBBI) &&
  [](unsigned RetOpcode) {
    return (RetOpcode == AArch64::TCRETURNdi ||
            RetOpcode == AArch64::TCRETURNri ||
            RetOpcode == AArch64::TCRETURNriBTI);
} (MBBI->getOpcode());
This revision is now accepted and ready to land.Jul 9 2020, 12:22 AM
thegameg accepted this revision.Jul 9 2020, 10:13 AM

LGTM, thanks!

This revision was automatically updated to reflect the committed changes.