Page MenuHomePhabricator

kyulee (Kyungwoo Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 22 2019, 1:52 PM (148 w, 6 d)

Recent Activity

Tue, Jun 7

kyulee accepted D126930: Fix interaction of CFI instructions with MachineOutliner..
Tue, Jun 7, 4:06 PM · Restricted Project, Restricted Project
kyulee added a comment to D126930: Fix interaction of CFI instructions with MachineOutliner..

Thanks for fixing this!
LGTM.

Tue, Jun 7, 4:05 PM · Restricted Project, Restricted Project

Mon, Jun 6

kyulee added inline comments to D126930: Fix interaction of CFI instructions with MachineOutliner..
Mon, Jun 6, 11:24 AM · Restricted Project, Restricted Project
kyulee added inline comments to D126930: Fix interaction of CFI instructions with MachineOutliner..
Mon, Jun 6, 9:58 AM · Restricted Project, Restricted Project

Sat, Jun 4

kyulee added inline comments to D126930: Fix interaction of CFI instructions with MachineOutliner..
Sat, Jun 4, 8:54 AM · Restricted Project, Restricted Project

May 17 2022

kyulee added inline comments to D125743: [outliner] Use profile data to avoid outlining hot blocks.
May 17 2022, 11:51 AM · Restricted Project, Restricted Project

Apr 6 2022

Herald added a project to D111912: New Pass for Merging Arbitrary Pair of Functions to Reduce Code Size: Restricted Project.
Apr 6 2022, 8:01 AM · Restricted Project, Restricted Project

Mar 17 2022

kyulee committed rGddb85f34f534: [ObjCARC] Fix non-determinism (authored by kyulee).
[ObjCARC] Fix non-determinism
Mar 17 2022, 3:01 PM · Restricted Project
kyulee closed D121949: [ObjCARC] Fix non-determinism.
Mar 17 2022, 3:01 PM · Restricted Project, Restricted Project
kyulee accepted D121946: [AlwaysInliner] Emit inline remark only when successful.
Mar 17 2022, 2:03 PM · Restricted Project, Restricted Project
kyulee added reviewers for D121949: [ObjCARC] Fix non-determinism: aeubanks, ahatanak, ellis.
Mar 17 2022, 1:58 PM · Restricted Project, Restricted Project
kyulee requested review of D121949: [ObjCARC] Fix non-determinism.
Mar 17 2022, 1:55 PM · Restricted Project, Restricted Project
kyulee added inline comments to D121722: [AlwaysInliner] Check inliner errors even without assserts.
Mar 17 2022, 10:29 AM · Restricted Project, Restricted Project

Mar 3 2022

kyulee accepted D120945: [InstrProf][NFC] Fix warning by removing typecast.
Mar 3 2022, 4:33 PM · Restricted Project, Restricted Project
kyulee added a comment to D120945: [InstrProf][NFC] Fix warning by removing typecast.

LGTM

Mar 3 2022, 4:32 PM · Restricted Project, Restricted Project

Feb 19 2022

kyulee added a comment to D120121: [StableHashing] Hash vregs with multiple defs.

Is there any specific use case or reason to enhance this collision?

See D120124: I want to use this as a quick hash for MachineFunctions (either before or after SSA, before or after regalloc) to detect which FunctionPasses modify them.

Feb 19 2022, 9:54 AM · Restricted Project

Feb 18 2022

kyulee added a comment to D120121: [StableHashing] Hash vregs with multiple defs.

Stable hash was designed to infer the machine instructions that are likely to be identical so that we can optimistically outline them.
I don't have a strong suggestion on how to interpret this in the presence of virtual registers (before RA).
But by taking all their defs into account, it appears the hash is likely to be more unique than before.
Is there any specific use case or reason to enhance this collision?

Feb 18 2022, 9:05 AM · Restricted Project

Feb 2 2022

kyulee accepted D118664: [InstrProf][NFC] Remove stray option in InstrProfWriter.

LGTM

Feb 2 2022, 2:07 PM · Restricted Project

Jan 28 2022

kyulee accepted D118097: [InstrProf][NFC] Move function out of InstrProf.h.
Jan 28 2022, 12:11 AM · Restricted Project

Jan 27 2022

kyulee accepted D116180: [InstrProf] Add single byte coverage mode.
Jan 27 2022, 11:05 AM · Restricted Project, Restricted Project, Restricted Project
kyulee added a comment to D116180: [InstrProf] Add single byte coverage mode.

LGTM. I'm approving this but suggest for other reviewers'. Also I left a few comments about naming counters that may follow up.

Jan 27 2022, 11:05 AM · Restricted Project, Restricted Project, Restricted Project
kyulee accepted D118181: [InstrProf][Correlate] Verify debug info with llvm-profdata show.
Jan 27 2022, 10:02 AM · Restricted Project, Restricted Project
kyulee added a comment to D118181: [InstrProf][Correlate] Verify debug info with llvm-profdata show.

Thanks for making the flag more consistent! Could you quickly update the summary in this patch to reflect the current code?
LGTM

Jan 27 2022, 10:02 AM · Restricted Project, Restricted Project

Jan 26 2022

kyulee added inline comments to D118181: [InstrProf][Correlate] Verify debug info with llvm-profdata show.
Jan 26 2022, 12:08 AM · Restricted Project, Restricted Project
kyulee accepted D118166: [InstrProf][Correlate] Improve error messages.
Jan 26 2022, 12:08 AM · Restricted Project
kyulee added a comment to D118166: [InstrProf][Correlate] Improve error messages.

This looks reasonable by sharing a common error message concatenated by the detailed reasons as needed instead of populating all the error cases.
Unless this violates coding convention with regard to error messages, it looks good to me. I'm approving it but want to hear other reviewers' opinions.

Jan 26 2022, 12:08 AM · Restricted Project

Jan 25 2022

kyulee accepted D118176: [InstrProf][Correlator] Do not compress names when reading debug info.
Jan 25 2022, 12:44 PM · Restricted Project, Restricted Project
kyulee added a comment to D118176: [InstrProf][Correlator] Do not compress names when reading debug info.

LGTM

Jan 25 2022, 12:44 PM · Restricted Project, Restricted Project

Jan 24 2022

kyulee committed rGf1c9e7bdc921: [ObjC Availability] Add missing const to getVersion function of… (authored by lcs).
[ObjC Availability] Add missing const to getVersion function of…
Jan 24 2022, 2:53 PM
kyulee closed D112119: [ObjC Availability] Add missing const to getVersion function of ObjCAvailabilityCheckExpr class.
Jan 24 2022, 2:53 PM · Restricted Project

Jan 14 2022

kyulee added inline comments to D116180: [InstrProf] Add single byte coverage mode.
Jan 14 2022, 1:02 PM · Restricted Project, Restricted Project, Restricted Project

Jan 4 2022

kyulee added inline comments to D116180: [InstrProf] Add single byte coverage mode.
Jan 4 2022, 4:45 PM · Restricted Project, Restricted Project, Restricted Project

Dec 30 2021

kyulee accepted D115981: [InstrProf] Mark counters as used in debug correlation mode.

LGTM

Dec 30 2021, 2:43 PM · Restricted Project
kyulee accepted D116179: [InstrProf][NFC] Do not assume size of counter type.

LGTM

Dec 30 2021, 2:26 PM · Restricted Project, Restricted Project
kyulee added inline comments to D116180: [InstrProf] Add single byte coverage mode.
Dec 30 2021, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
kyulee added inline comments to D116179: [InstrProf][NFC] Do not assume size of counter type.
Dec 30 2021, 10:06 AM · Restricted Project, Restricted Project

Dec 28 2021

kyulee committed rG4ecf15b789f6: [llvm-profdata] Make -debug-info visible (authored by kyulee).
[llvm-profdata] Make -debug-info visible
Dec 28 2021, 5:36 PM
kyulee closed D116348: [llvm-profdata] Make -debug-info visible.
Dec 28 2021, 5:36 PM · Restricted Project
kyulee updated the diff for D116348: [llvm-profdata] Make -debug-info visible.

Update the comment.

Dec 28 2021, 5:34 PM · Restricted Project
kyulee added reviewers for D116348: [llvm-profdata] Make -debug-info visible: ellis, MaskRay.
Dec 28 2021, 5:11 PM · Restricted Project
kyulee requested review of D116348: [llvm-profdata] Make -debug-info visible.
Dec 28 2021, 5:09 PM · Restricted Project
kyulee added a comment to D116180: [InstrProf] Add single byte coverage mode.

I will come back to review this code later once the dependent patches land.
In the high-level discussion, this is really a function coverage because it probes the function header, but the flag or terminology inter-mixed just a coverage.
For the code (not just function) coverage, I think we might want to have an option to inject this probe in the block edge as well so that the default/code-coverage can be fully functional.
Of course, this could be a follow-up, but just head-up on how this can be factored in this design.

Dec 28 2021, 3:42 PM · Restricted Project, Restricted Project, Restricted Project
kyulee added a comment to D116179: [InstrProf][NFC] Do not assume size of counter type.

Given this change must be NFC, but subtle due to pointer arithmetic. I guess you might run more through tests with some large programs with PGO.

Dec 28 2021, 3:31 PM · Restricted Project, Restricted Project
kyulee added inline comments to D116179: [InstrProf][NFC] Do not assume size of counter type.
Dec 28 2021, 3:30 PM · Restricted Project, Restricted Project
kyulee accepted D116051: [InstrProf] Prevent duplicate functions in correlated data.
Dec 28 2021, 12:38 PM · Restricted Project, Restricted Project
kyulee added a comment to D116051: [InstrProf] Prevent duplicate functions in correlated data.

Makes sense to check deduplication using counter address instead of function name.
LGTM.

Dec 28 2021, 12:38 PM · Restricted Project, Restricted Project

Dec 20 2021

kyulee added a comment to D116051: [InstrProf] Prevent duplicate functions in correlated data.

I presume without debug-info related correlation (normal IRPGO), the metadata is merged by their linkage types/contents.
For my education, I wonder whether IRPGO might have the same named function with different different CFG shapes -- e.g., static functions.
This approach seems to pick the first appearance of metadata for the same named functions, and ignore the rest assuming they are all identical.
And also can we have a test case for this?

Dec 20 2021, 1:38 PM · Restricted Project, Restricted Project

Dec 18 2021

kyulee accepted D115979: [InstrProf] Don't profile merge by default in lightweight mode.
Dec 18 2021, 7:14 PM · Restricted Project, Restricted Project
kyulee added a comment to D115979: [InstrProf] Don't profile merge by default in lightweight mode.

For clarification, the lightweight pgo does not support merging raw data from memory (at runtime) due to missing structural data, but it does support merging raw files offline.
Would you update the comment or error message?

Dec 18 2021, 7:13 PM · Restricted Project, Restricted Project

Dec 17 2021

kyulee added a comment to D115981: [InstrProf] Mark counters as used in debug correlation mode.

My understanding is that the counter symbol is referenced by a text/code. So it's naturally retained as long as the function is kept.
Is there any specific case this needs to be explicitly used?

Dec 17 2021, 6:49 PM · Restricted Project
kyulee accepted D115915: [Try2][InstrProf] Add Correlator class to read debug info.
Dec 17 2021, 9:45 AM · Restricted Project, Restricted Project

Dec 16 2021

kyulee accepted D115913: Revert "[InstrProf] Add Correlator class to read debug info".
Dec 16 2021, 4:26 PM · Restricted Project, Restricted Project
kyulee accepted D115911: [InstrProf] Fix build error in Correlator class.
Dec 16 2021, 3:55 PM · Restricted Project
kyulee accepted D115693: [Try2][InstrProf] Attach debug info to counters.
Dec 16 2021, 1:49 PM · Restricted Project, Restricted Project, Restricted Project

Dec 13 2021

kyulee accepted D114566: [InstrProf] Add Correlator class to read debug info.
Dec 13 2021, 2:31 PM · Restricted Project, Restricted Project
kyulee accepted D114565: [InstrProf] Attach debug info to counters.
Dec 13 2021, 2:31 PM · Restricted Project, Restricted Project, Restricted Project

Dec 10 2021

kyulee added a comment to D114566: [InstrProf] Add Correlator class to read debug info.

This looks good to me. Given this works for ELF while having a minor issue with the fully inlined case for MachO, could you file a bug to follow this up?
I also let other folks review this code.

Dec 10 2021, 6:57 AM · Restricted Project, Restricted Project

Dec 7 2021

kyulee added a comment to D114565: [InstrProf] Attach debug info to counters.

This change for the profile writer looks good to me!
Before signing it off, I'd like to hear any other suggestions or opinions from @davidxl @MaskRay @alanphipps since this is technically the very first change.

Dec 7 2021, 12:25 PM · Restricted Project, Restricted Project, Restricted Project

Dec 5 2021

kyulee added inline comments to D114565: [InstrProf] Attach debug info to counters.
Dec 5 2021, 11:47 AM · Restricted Project, Restricted Project, Restricted Project
kyulee updated subscribers of D114566: [InstrProf] Add Correlator class to read debug info.

Thanks for fixing MachO.
It appears there is still an issue but it seems in dwarflinker (dsymutil). As below with clang -g -mllvm -disable-vp=true -mllvm -debug-info-correlate=true -fprofile-generate -Oz -mllvm -disable-preinline, when the function is fully inlined, dsymutil seems to optimize this static data in the final dSYM.
I was trying to use -keep-function-for-static to keep this, but still has a missing location info (DW_AT_location) at dSYM, and thus we cannot correlate foo and thus miss the coverage for it.
But I think missing location info for the function static variables seems a known issue in dsymutil, and we may follow this up. cc @clayborg

static 
int foo() {
 return 1;
}
int main() {
 return foo();
}
Dec 5 2021, 11:39 AM · Restricted Project, Restricted Project

Dec 2 2021

kyulee added inline comments to D114565: [InstrProf] Attach debug info to counters.
Dec 2 2021, 5:26 PM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2021

kyulee committed rG9e647806f3f4: [InstrProf][NFC] Refactor ProfileDataMap usage (authored by ellis).
[InstrProf][NFC] Refactor ProfileDataMap usage
Dec 1 2021, 11:49 AM
kyulee closed D114828: [InstrProf][NFC] Refactor ProfileDataMap usage.
Dec 1 2021, 11:49 AM · Restricted Project
kyulee accepted D114828: [InstrProf][NFC] Refactor ProfileDataMap usage.
Dec 1 2021, 11:35 AM · Restricted Project
kyulee added a comment to D114828: [InstrProf][NFC] Refactor ProfileDataMap usage.

LGTM

Dec 1 2021, 11:34 AM · Restricted Project

Nov 30 2021

kyulee added inline comments to D114566: [InstrProf] Add Correlator class to read debug info.
Nov 30 2021, 10:13 AM · Restricted Project, Restricted Project
kyulee added inline comments to D114565: [InstrProf] Attach debug info to counters.
Nov 30 2021, 9:58 AM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2021

kyulee committed rG0150645bf5ae: [DebugInfo] Do not replace existing nodes from DICompileUnit (authored by ellis).
[DebugInfo] Do not replace existing nodes from DICompileUnit
Nov 29 2021, 7:46 PM
kyulee closed D114556: [DebugInfo] Do not replace existing nodes from DICompileUnit.
Nov 29 2021, 7:46 PM · Restricted Project, debug-info
kyulee added inline comments to D114565: [InstrProf] Attach debug info to counters.
Nov 29 2021, 5:54 PM · Restricted Project, Restricted Project, Restricted Project

Nov 19 2021

kyulee committed rGde11de308b64: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment (authored by ellis).
[InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment
Nov 19 2021, 3:46 PM
kyulee closed D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment.
Nov 19 2021, 3:45 PM · Restricted Project, Restricted Project

Nov 14 2021

kyulee updated the summary of D113870: [DebugInfo] Fix Test Targets in D108261.
Nov 14 2021, 9:38 PM · Restricted Project
kyulee committed rG0d1d05854444: [DebugInfo] Fix Test Targets in D108261 (authored by kyulee).
[DebugInfo] Fix Test Targets in D108261
Nov 14 2021, 9:37 PM
kyulee closed D113870: [DebugInfo] Fix Test Targets in D108261.
Nov 14 2021, 9:36 PM · Restricted Project
kyulee retitled D113870: [DebugInfo] Fix Test Targets in D108261 from Fix missing REQURIES for Tests in D108261 to [DebugInfo] Fix Test Targets in D108261.
Nov 14 2021, 9:35 PM · Restricted Project
kyulee updated the diff for D113870: [DebugInfo] Fix Test Targets in D108261.

Move tests into sub-directories

Nov 14 2021, 9:30 PM · Restricted Project
kyulee added reviewers for D113870: [DebugInfo] Fix Test Targets in D108261: dblaikie, ellis.
Nov 14 2021, 8:59 PM · Restricted Project
kyulee requested review of D113870: [DebugInfo] Fix Test Targets in D108261.
Nov 14 2021, 8:56 PM · Restricted Project
kyulee committed rG6747d44bda8c: [DebugInfo] Fix end_sequence of debug_line in LTO Object (authored by kyulee).
[DebugInfo] Fix end_sequence of debug_line in LTO Object
Nov 14 2021, 8:25 PM
kyulee closed D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
Nov 14 2021, 8:25 PM · Restricted Project
kyulee abandoned D108531: [DebugInfo] Use EndLabel for AsmStreamer.
Nov 14 2021, 7:46 PM · Restricted Project
kyulee updated the summary of D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
Nov 14 2021, 7:37 PM · Restricted Project
kyulee updated the diff for D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.

Fix a typo in the comment

Nov 14 2021, 7:37 PM · Restricted Project
kyulee updated the diff for D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.

Update the comments in addEndEntry for the skipping reasons.

Nov 14 2021, 7:33 PM · Restricted Project
kyulee added a comment to D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.

Thanks for all the work/iteration/research here - sorry it was a bit fussy.

Nov 14 2021, 7:31 PM · Restricted Project
kyulee added inline comments to D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
Nov 14 2021, 5:41 PM · Restricted Project
kyulee updated the diff for D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.

Use find instead of count for a check in addEndEntry.

Nov 14 2021, 1:53 PM · Restricted Project
kyulee added inline comments to D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
Nov 14 2021, 1:45 PM · Restricted Project
kyulee updated the diff for D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
  • Add an assembly test to cover the MC path that still emits the end entry using the section end symbol.
  • Add a check for addEndEntry before adding an end entry. The MCStreamer path may not populate the line entry.
Nov 14 2021, 12:50 PM · Restricted Project
kyulee updated the summary of D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
Nov 14 2021, 12:46 PM · Restricted Project
kyulee added inline comments to D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
Nov 14 2021, 10:13 AM · Restricted Project
kyulee updated the diff for D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.

Remove a white-space diff

Nov 14 2021, 9:52 AM · Restricted Project
kyulee added a reviewer for D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object: shchenz.
Nov 14 2021, 9:46 AM · Restricted Project
kyulee updated the diff for D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.

Terminate the line table aligning with Range creation:

  • When a new range is formed due to section or CU change
  • When nodebug function starts
  • When module is finished

From the above, I think the line table is well-formed in DwarfDebug (normal compiler path).
No need specialization for asm streamer or object stremer to end the line table.

Nov 14 2021, 9:45 AM · Restricted Project

Nov 13 2021

kyulee updated the diff for D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
  • Ensure the line table is terminated in DwarfDebug (compiler) path.
  • Still preserve the old code to synthesize the end entry for the assembly path.
Nov 13 2021, 5:58 PM · Restricted Project
kyulee added inline comments to D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
Nov 13 2021, 4:39 PM · Restricted Project
kyulee added inline comments to D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
Nov 13 2021, 12:05 PM · Restricted Project
kyulee added inline comments to D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.
Nov 13 2021, 11:55 AM · Restricted Project
kyulee updated the diff for D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object.

Fix the test failures by restoring PrevCU check instead of assertion.

  • Line table entrty insertion is independent of PrevCU creation.
Nov 13 2021, 11:47 AM · Restricted Project