Page MenuHomePhabricator

plotfi (Puyan Lotfi)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2017, 10:52 AM (111 w, 1 d)

Recent Activity

Yesterday

plotfi added a comment to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

This appears to only happen with -fintegrated-cc1, with fno-integrated-cc1 it does not repro. Still looking into this.

Fri, Jan 17, 11:39 AM · Restricted Project
plotfi added a comment to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

Thanks for pinging on this @thegameg. I had been looking at this a day or two ago but got side-tracked. Will take another look.

Fri, Jan 17, 10:51 AM · Restricted Project

Mon, Jan 13

plotfi added a comment to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

This test fails on Windows: http://45.33.8.238/win/5658/step_7.txt

Looks like this expects itanium mangling; maybe you want -triple %itanium_abi_triple?

Mon, Jan 13, 6:41 PM · Restricted Project
plotfi added a comment to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

This test fails on Windows: http://45.33.8.238/win/5658/step_7.txt

Looks like this expects itanium mangling; maybe you want -triple %itanium_abi_triple?

Since the bot's been red for a while now, I went ahead and landed that fix in 84baf123. The bot's green now, but please check if that's what the test wants to test or if this just papers over things.

Mon, Jan 13, 6:41 PM · Restricted Project
plotfi added a comment to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

This breaks tests on macOS: http://45.33.8.238/mac/5672/step_7.txt (macOS prefixes functions with an extra _.)

Mon, Jan 13, 2:21 PM · Restricted Project
plotfi committed rGa506f7f9105e: [clang][IFS][test] Fixing mangled name of a test for Darwin. (authored by plotfi).
[clang][IFS][test] Fixing mangled name of a test for Darwin.
Mon, Jan 13, 2:02 PM
plotfi added a comment to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

This breaks tests on macOS: http://45.33.8.238/mac/5672/step_7.txt (macOS prefixes functions with an extra _.)

Mon, Jan 13, 1:24 PM · Restricted Project
plotfi committed rGbd8c8827d96f: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block. (authored by plotfi).
[clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.
Mon, Jan 13, 1:06 PM
plotfi committed rGb7526cc21ce5: [NFC][clang][IFS] Adding braces to if-statement as prep for D71301. (authored by plotfi).
[NFC][clang][IFS] Adding braces to if-statement as prep for D71301.
Mon, Jan 13, 1:05 PM
plotfi closed D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..
Mon, Jan 13, 1:05 PM · Restricted Project
plotfi updated the diff for D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

Going to do an NFC pre-commit before this to add the braces.

Mon, Jan 13, 12:27 PM · Restricted Project
plotfi updated the diff for D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..
Mon, Jan 13, 11:31 AM · Restricted Project
plotfi updated the diff for D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

using isa

Mon, Jan 13, 11:31 AM · Restricted Project
plotfi committed rG484a7472f1aa: [llvm][MIRVRegNamerUtils] Adding hashing on FrameIndex MachineOperands. (authored by plotfi).
[llvm][MIRVRegNamerUtils] Adding hashing on FrameIndex MachineOperands.
Mon, Jan 13, 10:45 AM
plotfi closed D71583: [llvm][MIRVRegNamerUtils] Add support for hashing MachineOperand FrameIndices..
Mon, Jan 13, 10:45 AM · Restricted Project

Dec 18 2019

plotfi added a comment to D71583: [llvm][MIRVRegNamerUtils] Add support for hashing MachineOperand FrameIndices..

ping

Dec 18 2019, 5:12 PM · Restricted Project

Dec 16 2019

plotfi created D71583: [llvm][MIRVRegNamerUtils] Add support for hashing MachineOperand FrameIndices..
Dec 16 2019, 5:12 PM · Restricted Project
plotfi committed rG204dfabfe68a: [NFC][llvm][MIRVRegNamerUtils] Moving some switch cases and altering comments. (authored by plotfi).
[NFC][llvm][MIRVRegNamerUtils] Moving some switch cases and altering comments.
Dec 16 2019, 3:57 PM
plotfi committed rGf63b64c0c3b4: [llvm][MIRVRegNamerUtils] Adding hashing on CImm / FPImm MachineOperands. (authored by plotfi).
[llvm][MIRVRegNamerUtils] Adding hashing on CImm / FPImm MachineOperands.
Dec 16 2019, 3:28 PM
plotfi closed D71558: [llvm][MIRVRegNamerUtils] Adding hashing on CImm / FPImm MachineOperands..
Dec 16 2019, 3:28 PM · Restricted Project
plotfi created D71558: [llvm][MIRVRegNamerUtils] Adding hashing on CImm / FPImm MachineOperands..
Dec 16 2019, 10:34 AM · Restricted Project

Dec 13 2019

plotfi committed rG816985c12053: [NFC][llvm][MIRVRegNamerUtils] Refactoring GetHashableMO into switch-statement. (authored by plotfi).
[NFC][llvm][MIRVRegNamerUtils] Refactoring GetHashableMO into switch-statement.
Dec 13 2019, 11:55 PM
plotfi abandoned D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..

Abandoning. Will post some piecemeal patches that handle the various MO types separately.

Dec 13 2019, 11:54 PM · Restricted Project
plotfi added a comment to D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..

I'm going to create a new diff that is purely NFC, but moves this code to use the switch-statement. I will add multiple diffs them for specific things like CImm/FPImm. I'll eventually abandon this diff.

Dec 13 2019, 4:22 PM · Restricted Project
plotfi updated the diff for D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..

adding hash against RC/RB

Dec 13 2019, 2:23 PM · Restricted Project

Dec 12 2019

plotfi added inline comments to D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..
Dec 12 2019, 2:11 PM · Restricted Project
plotfi added inline comments to D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..
Dec 12 2019, 12:28 PM · Restricted Project
plotfi updated the diff for D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..

Being more explicit about which MachineOperand types can be hashed and which ones can be skipped due to unstable hashing on pointers as @aditya_nandakumar mentioned. Also brought back hashing on a vreg's defining MI operand because that makes sense.

Dec 12 2019, 12:25 PM · Restricted Project
plotfi retitled D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr. from [llvm][NFCi][lMIRVRegNamerUtils] Leverage MachineInstrExpressionTrait for hashing a MachineInstr. to [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..
Dec 12 2019, 12:24 PM · Restricted Project
plotfi added inline comments to D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..
Dec 12 2019, 11:19 AM · Restricted Project
plotfi updated the summary of D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..
Dec 12 2019, 10:51 AM · Restricted Project
plotfi updated the summary of D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..
Dec 12 2019, 10:51 AM · Restricted Project
plotfi updated the diff for D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..
Dec 12 2019, 10:51 AM · Restricted Project
plotfi updated the summary of D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..
Dec 12 2019, 10:51 AM · Restricted Project
plotfi retitled D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr. from [llvm][NFCi][lMIRVRegNamerUtils] Leverage llvm::hash_value(MachineOperand) for hashing a MachineInstr. to [llvm][NFCi][lMIRVRegNamerUtils] Leverage MachineInstrExpressionTrait for hashing a MachineInstr..
Dec 12 2019, 10:51 AM · Restricted Project
plotfi committed rG756db63af964: [NFC][llvm][MIRVRegNamerUtils] Moving methods around. Making some private. (authored by plotfi).
[NFC][llvm][MIRVRegNamerUtils] Moving methods around. Making some private.
Dec 12 2019, 12:44 AM

Dec 11 2019

plotfi created D71396: [llvm][NFCi][lMIRVRegNamerUtils] Leverage hash_value for hashing a MachineInstr..
Dec 11 2019, 11:48 PM · Restricted Project
plotfi added a comment to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

Should probably add a check for __block variables.

Dec 11 2019, 7:33 PM · Restricted Project
plotfi committed rGf5b7a468375d: [llvm][MIRVRegNamerUtils] Adding hashing on memoperands. (authored by plotfi).
[llvm][MIRVRegNamerUtils] Adding hashing on memoperands.
Dec 11 2019, 7:20 PM
plotfi closed D71328: [llvm][MIRVRegNamerUtils] Adding hashing for memoperands..
Dec 11 2019, 7:19 PM · Restricted Project
plotfi updated the diff for D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..
Dec 11 2019, 12:37 PM · Restricted Project
plotfi abandoned D71317: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

Abandoning. Duplicate diff

Dec 11 2019, 12:37 PM · Restricted Project
plotfi updated the summary of D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..
Dec 11 2019, 12:37 PM · Restricted Project
plotfi retitled D71328: [llvm][MIRVRegNamerUtils] Adding hashing for memoperands. from [llvm][MIRVRegNamerUtils] Adding hashinf for memoperands. to [llvm][MIRVRegNamerUtils] Adding hashing for memoperands..
Dec 11 2019, 9:33 AM · Restricted Project

Dec 10 2019

plotfi created D71328: [llvm][MIRVRegNamerUtils] Adding hashing for memoperands..
Dec 10 2019, 10:43 PM · Restricted Project
plotfi committed rGf364686f34d8: [llvm][MIRVRegNamerUtil] Adding hashing against MachineInstr flags. (authored by plotfi).
[llvm][MIRVRegNamerUtil] Adding hashing against MachineInstr flags.
Dec 10 2019, 5:23 PM
plotfi closed D70479: [MIRVRegNamerUtils] Add additional hashing on MachineInstr flags..
Dec 10 2019, 5:23 PM · Restricted Project
plotfi created D71317: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..
Dec 10 2019, 4:55 PM · Restricted Project
plotfi created D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..
Dec 10 2019, 1:43 PM · Restricted Project
plotfi updated the diff for D70479: [MIRVRegNamerUtils] Add additional hashing on MachineInstr flags..

Adding test case.

Dec 10 2019, 1:47 AM · Restricted Project
plotfi added inline comments to D70479: [MIRVRegNamerUtils] Add additional hashing on MachineInstr flags..
Dec 10 2019, 1:47 AM · Restricted Project

Dec 9 2019

plotfi committed rG479e3b85e27b: [NFCi][llvm][MIRVRegNamerUtils] Making some code cleanup and stylistic changes. (authored by plotfi).
[NFCi][llvm][MIRVRegNamerUtils] Making some code cleanup and stylistic changes.
Dec 9 2019, 8:39 PM
plotfi closed D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 8:39 PM · Restricted Project
plotfi updated the diff for D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 6:40 PM · Restricted Project
plotfi added inline comments to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 4:16 PM · Restricted Project
plotfi added inline comments to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 3:39 PM · Restricted Project
plotfi updated the diff for D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 3:39 PM · Restricted Project
plotfi added a comment to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.

The std::transform better expresses the intent IMO. I think that it is definitely more idiomatic C++, so I think that is an improvement.

I agree with this. Was going through the changes in this util in my downtime and just saw some opportunities to spruce some things up. I find it really odd that you'd have a HashOperand lambda and not want to apply that to your collection of uses from a llvm::transform.

FWIW I'm not really convinced that std::transform is *ever* clearer or better any more since C++11 gave us auto and range-for.

In any case, the rest of this all seems like a nice clean up to me.

Dec 9 2019, 3:30 PM · Restricted Project
plotfi added a comment to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.

The std::transform better expresses the intent IMO. I think that it is definitely more idiomatic C++, so I think that is an improvement.

Dec 9 2019, 3:03 PM · Restricted Project
plotfi added inline comments to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 3:03 PM · Restricted Project
plotfi updated the diff for D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.

Update to make llvm::transform more clear than standard for-loop

Dec 9 2019, 3:03 PM · Restricted Project
plotfi added inline comments to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 1:42 PM · Restricted Project
plotfi added a comment to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.

I don't know what the convention of LLVM is here - but I prefer the simple for loop with a push back vs a use of transform (which is not really transforming anything) which is confusing.

Dec 9 2019, 12:16 PM · Restricted Project
plotfi added inline comments to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 12:07 PM · Restricted Project
plotfi committed rGd694594d7650: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs. (authored by plotfi).
[clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.
Dec 9 2019, 11:57 AM
plotfi closed D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs..
Dec 9 2019, 11:57 AM · Restricted Project
plotfi updated the diff for D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.

Updated based on @compnerd's feedback.

Dec 9 2019, 10:52 AM · Restricted Project
plotfi added inline comments to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 10:52 AM · Restricted Project

Dec 8 2019

plotfi created D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 8 2019, 10:25 PM · Restricted Project

Dec 6 2019

plotfi abandoned D70839: [clang][IFS] Claiming -emit-merged-ifs in clang driver when -c is used..

This commit is no good. I got some wrong inspiration from a lot of the code claiming random args in the driver. abandoning.

Dec 6 2019, 5:56 PM · Restricted Project

Dec 5 2019

plotfi updated the summary of D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs..
Dec 5 2019, 2:39 PM · Restricted Project
plotfi updated the summary of D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs..
Dec 5 2019, 2:39 PM · Restricted Project
plotfi updated the diff for D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs..

Updating comments and altering test as per @cishida and @compnerd's feedback

Dec 5 2019, 2:39 PM · Restricted Project
plotfi added inline comments to D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs..
Dec 5 2019, 2:39 PM · Restricted Project
plotfi committed rGef7267def69f: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols. (authored by plotfi).
[llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols.
Dec 5 2019, 9:57 AM
plotfi closed D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..
Dec 5 2019, 9:57 AM · Restricted Project

Dec 4 2019

plotfi updated the diff for D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..

adding tests for weak/strong mismatch that is also a size/type mismatch for a given symbol.

Dec 4 2019, 11:16 PM · Restricted Project
plotfi added inline comments to D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..
Dec 4 2019, 9:12 PM · Restricted Project
plotfi added inline comments to D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..
Dec 4 2019, 9:12 PM · Restricted Project
plotfi updated the diff for D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..

Update based on @compnerd's feedback

Dec 4 2019, 5:56 PM · Restricted Project
plotfi committed rG4ef9110b8d10: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now. (authored by plotfi).
[clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.
Dec 4 2019, 5:10 PM
plotfi closed D70838: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now..
Dec 4 2019, 5:10 PM · Restricted Project
plotfi committed rG07e445103e36: [clang][IFS] Adding support for new clang interface stubs decl types. (authored by plotfi).
[clang][IFS] Adding support for new clang interface stubs decl types.
Dec 4 2019, 4:13 PM
plotfi closed D70728: [clang][IFS] Adding support for new clang interface stubs decl types..
Dec 4 2019, 4:13 PM · Restricted Project
plotfi committed rGfdc6f4b97b0e: [llvm] Fixing MIRVRegNamerUtils to properly handle 2+ MachineBasicBlocks. (authored by plotfi).
[llvm] Fixing MIRVRegNamerUtils to properly handle 2+ MachineBasicBlocks.
Dec 4 2019, 3:37 PM
plotfi closed D70478: [MIRVRegNamerUtils] Fix for BasicBlock numbering parameter..
Dec 4 2019, 3:37 PM · Restricted Project

Dec 2 2019

plotfi added a comment to D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

Could you upload a diff with more context (-U9999)?

Dec 2 2019, 2:25 PM · Restricted Project

Nov 30 2019

plotfi updated the diff for D70478: [MIRVRegNamerUtils] Fix for BasicBlock numbering parameter..

Will land on Monday when holiday is over. I don't want to be that guy.

Nov 30 2019, 4:14 PM · Restricted Project

Nov 29 2019

plotfi updated the diff for D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..
Nov 29 2019, 5:06 PM · Restricted Project
plotfi updated the diff for D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..

fixing indentation

Nov 29 2019, 5:02 PM · Restricted Project
plotfi updated the diff for D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..

Updated based on @compnerd's suggestions.

Nov 29 2019, 4:57 PM · Restricted Project
plotfi added inline comments to D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..
Nov 29 2019, 4:39 PM · Restricted Project

Nov 28 2019

plotfi created D70839: [clang][IFS] Claiming -emit-merged-ifs in clang driver when -c is used..
Nov 28 2019, 11:58 PM · Restricted Project
plotfi created D70838: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now..
Nov 28 2019, 10:48 PM · Restricted Project
plotfi added a comment to D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

LGTM assuming @qcolombet or @aemerson have no objections.

Nov 28 2019, 2:08 PM · Restricted Project
plotfi added a reviewer for D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols.: cishida.
Nov 28 2019, 1:56 PM · Restricted Project
plotfi added a reviewer for D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.: cishida.
Nov 28 2019, 1:56 PM · Restricted Project
plotfi created D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..
Nov 28 2019, 1:56 PM · Restricted Project
plotfi added a reviewer for D70728: [clang][IFS] Adding support for new clang interface stubs decl types.: cishida.
Nov 28 2019, 1:56 PM · Restricted Project

Nov 26 2019

plotfi created D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs..
Nov 26 2019, 9:10 PM · Restricted Project