Page MenuHomePhabricator

plotfi (Puyan Lotfi)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2017, 10:52 AM (94 w, 20 h)

Recent Activity

Sun, Sep 15

plotfi added inline comments to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Sun, Sep 15, 5:36 PM · Restricted Project

Fri, Sep 13

plotfi added a comment to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..

I think this change might be breaking builds: http://lab.llvm.org:8011/builders/clang-aarch64-linux-build-cache/builds/16888

Fri, Sep 13, 11:15 AM · Restricted Project
plotfi added a comment to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Fri, Sep 13, 11:14 AM · Restricted Project

Thu, Sep 12

plotfi added reviewers for D67527: [TextAPI] Arch&Platform to Target: compnerd, smeenai.
Thu, Sep 12, 4:24 PM · Restricted Project

Tue, Sep 10

plotfi added a comment to D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..

Nice! Thanks @phosek. I’m fine with a revert. Currently away from keyboard.

Tue, Sep 10, 5:38 PM · Restricted Project
plotfi added a comment to D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..

Where are your bots?

Tue, Sep 10, 5:26 PM · Restricted Project
plotfi committed rG244e73848544: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds. (authored by plotfi).
Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds.
Tue, Sep 10, 4:02 PM
plotfi added a comment to D66160: [llvm-nm] Add tapi file support.

Ah I get it, because ld64 is tbd-aware the end product is the text. I’m still not sure if I will add any support to lld for something like ifs, things still seem good just using the ifs text format for the intermediate symbol merging.

Tue, Sep 10, 9:48 AM · Restricted Project

Sat, Sep 7

plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.
Sat, Sep 7, 12:50 AM · Restricted Project

Fri, Sep 6

plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.

Adding better wiring up to llvm-ifs

Fri, Sep 6, 6:17 PM · Restricted Project
plotfi committed rG5476bd943203: [llvm-ifs] Improving detection of PlatformKind from triple for TBD generation. (authored by plotfi).
[llvm-ifs] Improving detection of PlatformKind from triple for TBD generation.
Fri, Sep 6, 1:00 PM
plotfi added a comment to D66160: [llvm-nm] Add tapi file support.

Does this addition mean that llvm-nm should eventually include some support for other text formats like ifs/elfabi etc? I think this could be pretty useful for writing tests, which I assume is part of the motivation here?

Fri, Sep 6, 11:00 AM · Restricted Project
plotfi added a comment to D67255: [llvm-ifs] Fixing hardcoding of PlatformKind for TBD generation.

bridgeOS hasn't been added to llvm triple yet, so it's fine to exclude it for now.
also I have a patch I'm adding very soon that takes in llvm::triple and does the arch/platform mapping so you won't need to. I'll update this file when it comes out.

Fri, Sep 6, 10:34 AM · Restricted Project
plotfi added a comment to D67209: [MIR] MIR Namer pass.

Hi,

I did a minor change to the test case in r371171 since the

;CHECK: bb

checks matched on the line

;ModuleID = '/repo/bb/

in the output instead of the wanted "bb.0:".

I fixed it by reading input from stdin instead of from the file to make the change as small as possible, but perhaps the

;CHECK: bb

lines should be changed to

;CHECK-LABEL: bb.0:

etc instead.

Fri, Sep 6, 10:34 AM · Restricted Project

Thu, Sep 5

plotfi created D67255: [llvm-ifs] Fixing hardcoding of PlatformKind for TBD generation.
Thu, Sep 5, 11:15 PM · Restricted Project
plotfi added a comment to D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..

Ping?

Thu, Sep 5, 4:46 PM · Restricted Project
plotfi committed rGdc97ca9f25ac: [MIR] MIRNamer pass for improving MIR test authoring experience. (authored by plotfi).
[MIR] MIRNamer pass for improving MIR test authoring experience.
Thu, Sep 5, 1:45 PM
plotfi updated the diff for D67209: [MIR] MIR Namer pass.

addressing @paquette's feedback

Thu, Sep 5, 12:15 PM · Restricted Project

Wed, Sep 4

plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Wed, Sep 4, 10:15 PM · Restricted Project
plotfi created D67209: [MIR] MIR Namer pass.
Wed, Sep 4, 10:01 PM · Restricted Project
plotfi committed rG6d3ea2d9b60b: [mir-canon][NFC] Adding -verify-machineinstrs to mir-canon tests. (authored by plotfi).
[mir-canon][NFC] Adding -verify-machineinstrs to mir-canon tests.
Wed, Sep 4, 7:12 PM
plotfi created D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..
Wed, Sep 4, 3:27 PM · Restricted Project
plotfi abandoned D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..
Wed, Sep 4, 2:46 PM · Restricted Project
plotfi committed rG028061d4ebeb: [mir-canon][NFC] Move MIR vreg renaming code to separate file for better reuse. (authored by plotfi).
[mir-canon][NFC] Move MIR vreg renaming code to separate file for better reuse.
Wed, Sep 4, 2:30 PM
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..

More comments.

Wed, Sep 4, 12:57 PM · Restricted Project

Tue, Sep 3

plotfi committed rG954d6d661f33: [NFC][llvm-ifs] Adding .ifs files to the test list for llvm-ifs tool. (authored by plotfi).
[NFC][llvm-ifs] Adding .ifs files to the test list for llvm-ifs tool.
Tue, Sep 3, 5:50 PM
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Tue, Sep 3, 4:40 PM · Restricted Project
plotfi added inline comments to D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Tue, Sep 3, 4:40 PM · Restricted Project
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Tue, Sep 3, 4:13 PM · Restricted Project
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..

addressing @paquette's suggestions.

Tue, Sep 3, 4:07 PM · Restricted Project
plotfi added inline comments to D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Tue, Sep 3, 3:41 PM · Restricted Project
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Tue, Sep 3, 3:41 PM · Restricted Project
plotfi updated the diff for D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..

Moving the guts of the candidate walk loop into the reusable MIRVRegNamer.cpp library

Tue, Sep 3, 2:18 PM · Restricted Project
plotfi added inline comments to D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Tue, Sep 3, 2:18 PM · Restricted Project
plotfi added inline comments to D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..
Tue, Sep 3, 10:47 AM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Tue, Sep 3, 10:45 AM · Restricted Project
plotfi created D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse..
Tue, Sep 3, 10:45 AM · Restricted Project
plotfi added a comment to D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..

Sounds good.

Tue, Sep 3, 9:29 AM · Restricted Project

Mon, Sep 2

plotfi created D67061: [mir-canon][NFCi] Adding opt arg to enable vreg renaming only mode..
Mon, Sep 2, 12:39 AM · Restricted Project

Sat, Aug 31

plotfi committed rG75a8a212d4e4: [GlobalISel][NFC] Regression test cases for aarch64 legalizer (s128 sext+icmp). (authored by plotfi).
[GlobalISel][NFC] Regression test cases for aarch64 legalizer (s128 sext+icmp).
Sat, Aug 31, 5:46 PM

Fri, Aug 30

plotfi committed rG0227208b8753: [IFS][NFC] llvm-ifs: Fixing build bot build break: revert r370517 and r370510. (authored by plotfi).
[IFS][NFC] llvm-ifs: Fixing build bot build break: revert r370517 and r370510.
Fri, Aug 30, 1:32 PM
plotfi committed rG7e9dd09db8a4: [IFS][NFC] llvm-ifs: Fixing build bot error due to commit conflicts. (authored by plotfi).
[IFS][NFC] llvm-ifs: Fixing build bot error due to commit conflicts.
Fri, Aug 30, 1:10 PM
plotfi committed rG979e7cda8048: [IFS][NFC] llvm-ifs: Fixing build errors for bots using GCC. (authored by plotfi).
[IFS][NFC] llvm-ifs: Fixing build errors for bots using GCC.
Fri, Aug 30, 12:55 PM
plotfi committed rGd719c50655e7: [llvm-ifs][IFS] llvm Interface Stubs merging + object file generation tool. (authored by plotfi).
[llvm-ifs][IFS] llvm Interface Stubs merging + object file generation tool.
Fri, Aug 30, 11:27 AM
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

longer flags, no more =

Fri, Aug 30, 10:13 AM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Fri, Aug 30, 9:55 AM · Restricted Project

Thu, Aug 29

plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Thu, Aug 29, 2:06 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

better diag, better test names

Thu, Aug 29, 2:04 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

adding .data and .rodata to elf sections

Thu, Aug 29, 10:13 AM · Restricted Project

Wed, Aug 28

plotfi added a comment to D66029: llvm-canon.

Gentle ping ;)

I would like to ask someone to commit this for me. I don't have commit rights.

Wed, Aug 28, 9:59 PM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Wed, Aug 28, 10:46 AM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
  • Dropping vestigial ELFSymbols, now I have IFSSymbol.
  • addressed @compnerd 's feedback
Wed, Aug 28, 10:46 AM · Restricted Project

Tue, Aug 27

plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

More version checks

Tue, Aug 27, 2:35 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

Checking for conflicts in the Ifs header.

Tue, Aug 27, 1:21 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

Added some better conflict checking tests.

Tue, Aug 27, 11:59 AM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Tue, Aug 27, 11:12 AM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Tue, Aug 27, 11:07 AM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Tue, Aug 27, 2:31 AM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

test updates based on feedback

Tue, Aug 27, 2:19 AM · Restricted Project

Mon, Aug 26

plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

adding another test, to merge objects and funcs of different sizes.

Mon, Aug 26, 4:54 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

Adding some tests. and added some really basic symbol conflict error checking (no resolution though).

Mon, Aug 26, 2:42 PM · Restricted Project

Fri, Aug 23

plotfi updated the summary of D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Fri, Aug 23, 5:47 PM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Fri, Aug 23, 5:47 PM · Restricted Project
plotfi added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Fri, Aug 23, 5:29 PM · Restricted Project
plotfi added a reviewer for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool.: cishida.
Fri, Aug 23, 5:28 PM · Restricted Project
plotfi updated the diff for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
  • Addressing @compnerd's feedback, still need to do some smarter conflict resolution for symbols and add tests.
  • Added rudimentary TBD support.
Fri, Aug 23, 4:14 PM · Restricted Project

Thu, Aug 22

plotfi committed rG926f4f76c3f8: [clang][ifs] Dropping older experimental interface stub formats. (authored by plotfi).
[clang][ifs] Dropping older experimental interface stub formats.
Thu, Aug 22, 4:48 PM
plotfi committed rGd24184591fb7: [clang][ifs] New interface stubs format (llvm triple based). (authored by plotfi).
[clang][ifs] New interface stubs format (llvm triple based).
Thu, Aug 22, 4:31 PM
plotfi updated the diff for D66573: [clang][ifs] Dropping older experimental interface stub formats..

Better diag

Thu, Aug 22, 2:43 PM · Restricted Project, Restricted Project
plotfi added inline comments to D66446: [clang][IFS] Adding new Interface Stubs format. .
Thu, Aug 22, 10:25 AM · Restricted Project, Restricted Project
plotfi added a comment to D66029: llvm-canon.

Looking a lot better.

Thu, Aug 22, 1:12 AM · Restricted Project

Wed, Aug 21

plotfi created D66573: [clang][ifs] Dropping older experimental interface stub formats..
Wed, Aug 21, 7:00 PM · Restricted Project, Restricted Project

Aug 20 2019

plotfi added a comment to D61767: [llvm-elfabi] Emit ELF header and string table section.

@jakehehrlich Haven't seen an update on this diff in a while. How are things going?

Aug 20 2019, 9:57 AM · Restricted Project
plotfi abandoned D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP). .
Aug 20 2019, 9:54 AM

Aug 19 2019

plotfi updated the diff for D66446: [clang][IFS] Adding new Interface Stubs format. .

Adding ObjectFileFormat

Aug 19 2019, 3:17 PM · Restricted Project, Restricted Project
plotfi created D66446: [clang][IFS] Adding new Interface Stubs format. .
Aug 19 2019, 3:13 PM · Restricted Project, Restricted Project
plotfi added inline comments to D66446: [clang][IFS] Adding new Interface Stubs format. .
Aug 19 2019, 3:13 PM · Restricted Project, Restricted Project
plotfi added a reviewer for D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool.: rupprecht.
Aug 19 2019, 8:26 AM · Restricted Project
plotfi updated the summary of D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Aug 19 2019, 12:39 AM · Restricted Project
plotfi added a comment to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..

There is another tool tools/llvm-elfabi that does something very similar. (To be honest I don't quite get the point why that tool is required and why it has to be a llvm tool.) Nevertheless, it exists there, though not actively developed. Does this tool intend to replace/complement it?

Aug 19 2019, 12:35 AM · Restricted Project

Aug 18 2019

plotfi created D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Aug 18 2019, 11:49 PM · Restricted Project

Aug 14 2019

plotfi committed rG740f69b91b4c: [NFC][clang] Moving argument handling: Driver::BuildActions -> handleArguments (authored by plotfi).
[NFC][clang] Moving argument handling: Driver::BuildActions -> handleArguments
Aug 14 2019, 10:04 AM

Aug 13 2019

plotfi retitled D63978: Clang Interface Stubs merger plumbing for Driver from Very early work on interface stub merger plumbing. to Clang Interface Stubs merger plumbing for Driver.
Aug 13 2019, 2:41 PM · Restricted Project
plotfi updated the diff for D63978: Clang Interface Stubs merger plumbing for Driver.

Updated. Much better cleaner implementation.

Aug 13 2019, 2:41 PM · Restricted Project
plotfi added a comment to D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments..

@aaron.ballman Good catch on the /Yc /Yu args. I like the way its looking a lot more now.

Aug 13 2019, 12:11 PM · Restricted Project, Restricted Project
plotfi updated the diff for D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments..
Aug 13 2019, 12:06 PM · Restricted Project, Restricted Project
plotfi updated the diff for D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments..
Aug 13 2019, 12:06 PM · Restricted Project, Restricted Project
plotfi added inline comments to D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments..
Aug 13 2019, 12:06 PM · Restricted Project, Restricted Project
plotfi updated the diff for D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments..

Moved the initialization of YcArg and YuArg and initial handling of those args into handleArguments. ninja check-clang passes.

Aug 13 2019, 12:02 PM · Restricted Project, Restricted Project
plotfi added inline comments to D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments..
Aug 13 2019, 11:45 AM · Restricted Project, Restricted Project
plotfi committed rGe5ade767e5d1: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases (authored by plotfi).
[NFC][clang] Adding argument based Phase list filtering to getComplicationPhases
Aug 13 2019, 11:42 AM

Aug 12 2019

plotfi added a comment to D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases.

@aaron.ballman How does this look to you?

Aug 12 2019, 6:44 PM · Restricted Project, Restricted Project

Aug 11 2019

plotfi added inline comments to D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases.
Aug 11 2019, 12:36 AM · Restricted Project, Restricted Project

Aug 10 2019

plotfi updated the diff for D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments..

really sorry for how bad this diff looks. phab just doesnt present in a very ideal way.

Aug 10 2019, 6:05 PM · Restricted Project, Restricted Project
plotfi created D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments..
Aug 10 2019, 6:02 PM · Restricted Project, Restricted Project
plotfi added inline comments to D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases.
Aug 10 2019, 2:08 PM · Restricted Project, Restricted Project
plotfi updated the diff for D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases.
Aug 10 2019, 2:08 PM · Restricted Project, Restricted Project

Aug 9 2019

plotfi updated subscribers of D66029: llvm-canon.
Aug 9 2019, 8:33 PM · Restricted Project
plotfi added inline comments to D66029: llvm-canon.
Aug 9 2019, 8:33 PM · Restricted Project
plotfi added a comment to D66029: llvm-canon.

Please add lit tests.

Aug 9 2019, 8:33 PM · Restricted Project