@smeenai I think if this change works then for now we can just land it because we have several bots to turn green in the short term. Would you be fine with allowing for this fix in the near term?

Wed, Jul 17, 1:13 PM · Restricted Project

plotfi added a comment to D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table..

@aaron.ballman Any thoughts on this?

Wed, Jul 17, 11:24 AM · Restricted Project, Restricted Project

Mon, Jul 15

plotfi added a comment to D55277: [RISCV] Match GNU tools canonical JALR and add aliases.

In D55277#1586961, @asb wrote:

In D55277#1586959, @plotfi wrote:

In D55277#1586958, @asb wrote:

In D55277#1586957, @plotfi wrote:

Test failures in lld tests: http://lab.llvm.org:8011/builders/lld-x86_64-ubuntu-fast/builds/3357

Sorry about that, patch incoming.

I got one coming too. Should I wait for yours or just land this one?

Oh great, please land yours then. Mind is written blind as lld doesn't seem to be building after I add it to LLVM_ENABLE_PROJECTS. Will have to wipe my build dir and wait a while.

Mon, Jul 15, 11:04 PM · Restricted Project

plotfi committed rG3e10905c49ff: [NFC][test] Fix for riscv tests. (authored by plotfi).

[NFC][test] Fix for riscv tests.

Mon, Jul 15, 11:00 PM

plotfi added a comment to D55277: [RISCV] Match GNU tools canonical JALR and add aliases.

Don't worry about it, I landed a change in r366183

Mon, Jul 15, 10:58 PM · Restricted Project

plotfi added a comment to D55277: [RISCV] Match GNU tools canonical JALR and add aliases.

In D55277#1586958, @asb wrote:

In D55277#1586957, @plotfi wrote:

Test failures in lld tests: http://lab.llvm.org:8011/builders/lld-x86_64-ubuntu-fast/builds/3357

Sorry about that, patch incoming.

Mon, Jul 15, 10:56 PM · Restricted Project

plotfi added a comment to D55277: [RISCV] Match GNU tools canonical JALR and add aliases.

Test failures in lld tests: http://lab.llvm.org:8011/builders/lld-x86_64-ubuntu-fast/builds/3357

Mon, Jul 15, 10:38 PM · Restricted Project

plotfi added a comment to D55277: [RISCV] Match GNU tools canonical JALR and add aliases.

This change has caused test failures in lld tests:

Mon, Jul 15, 10:38 PM · Restricted Project

Tue, Jul 2

plotfi updated the diff for D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table..

Update diff based on @compnerd's feedback

Tue, Jul 2, 4:40 PM · Restricted Project, Restricted Project

plotfi created D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table..

Tue, Jul 2, 1:49 PM · Restricted Project, Restricted Project

plotfi added a reviewer for D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.: compnerd.

Tue, Jul 2, 1:49 PM · Restricted Project, Restricted Project

plotfi abandoned D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver..

Tue, Jul 2, 1:46 PM · Restricted Project

Mon, Jul 1

plotfi added a comment to D60974: Clang IFSO driver action..

In D60974#1565632, @jfb wrote:

In D60974#1565621, @plotfi wrote:

In D60974#1565577, @jfb wrote:

Looking at the code quickly, I'm not sure that this should be in clang itself. It sounds like a better fit for a clang-based tool, and not clang. Why does it need to be part of clang?

@jfb I think this could actually be refactored into a clang based tool come to think of it, but I am also looking at how to add some features to the driver so that it can support job pipelines that are different from the standard PP -> CC1 -> BE -> ASM -> LINK pipeline. I can work on a change once I sort out this pipeline work to move the interface generation into a clang tool so that instead of invoking clang -cc1 to generate the interfaces the clang driver invokes the new clang interface generation tool.

That sounds pretty good, thanks! Maybe someone like @ributzka / @arphaman / @Bigcheese have opinions on how to best do this.
Once you do this, can you also revert rL364855?

Mon, Jul 1, 4:05 PM · Restricted Project, Restricted Project

plotfi added a comment to D60974: Clang IFSO driver action..

In D60974#1565577, @jfb wrote:

Looking at the code quickly, I'm not sure that this should be in clang itself. It sounds like a better fit for a clang-based tool, and not clang. Why does it need to be part of clang?

Mon, Jul 1, 3:49 PM · Restricted Project, Restricted Project

plotfi added a comment to D60974: Clang IFSO driver action..

In D60974#1565570, @bruno wrote:

I am currently working on the next part of clang interface stubs that will take the interface stubs per compilation unit and merge them into one text stub (which will be used by something like llvm-elfabi to generate a stubbed out ELF .so file). I was using llvm-nm, but there are cases where the symbol is present in the .o file but it is marked as HIDDEN and llvm-readelf was what I was using to determine if the symbol was in fact marked as hidden. In these cases, the linker will not emit the symbol in the final .so file but it still needs the symbol as part of linking.

This is similar to using "llvm-bcanalyzer" to check for serialization stuff from clang. We can't guarantee that to be available and adding a dep here would be weird. One way to workaround that would be to have a %llvm-readelf thing in lit and not run tests if not available (which also makes it questionable if it's not always running, but better than nothing?). Another option is to add a small clang tool that dumps what you need to check.

Mon, Jul 1, 3:35 PM · Restricted Project, Restricted Project

plotfi added a comment to D60974: Clang IFSO driver action..

In D60974#1565577, @jfb wrote:

Looking at the code quickly, I'm not sure that this should be in clang itself. It sounds like a better fit for a clang-based tool, and not clang. Why does it need to be part of clang?

Mon, Jul 1, 3:35 PM · Restricted Project, Restricted Project

plotfi added a comment to D60974: Clang IFSO driver action..

In D60974#1565544, @jfb wrote:

In D60974#1565541, @plotfi wrote:

In D60974#1565527, @jfb wrote:

In D60974#1565517, @jfb wrote:

In D60974#1565054, @plotfi wrote:

So I think I know what may be going on on your end. The llvm-readelf in your path I believe might be the wrong lllvm-readelf (llvm-readelf-7). Are you sure you built llvm-readelf from git?

Please don't do this. Your commit is wrong, and the right action from you is to revert it or fix it. I've fixed it for you here: rL364855

I'm also really not sure this is any good: why does clang look at ELF? In general I'd expect you to test something *way* earlier than ELF. Are you sure you're testing the right thing?

Ah, I must have mistakenly thought that other tools were already using llvm-readelf in cfe. Sorry about this.

This is in fact intended. The interface stubs feature needs to be verified against the actual symbols that are emitted into the elf binary. In the cases where I use llvm-readelf, I am using it to determine if the symbol is visible (to nm for example) but marked hidden in the .o file (but will end up being hidden in when linked).

Currently clang -emit-interface-stubs is not using any elf libraries, but it needs to verify against llvm-nm and/or llvm-readelf in these lit tests to determine if the visibility of the symbols generated in the text stubs is correct.

llvm-nm is already in the list of requirement for clang, so that would be fine to use. I'm not sure llvm-readelf is necessarily built for all targets, so my "fix" might still be broken. It's also another dependency, and a weird one at that. Can you test the property you're looking for in IR directly? And then test, in LLVM, that the same IR generates the ELF binary you want?

Mon, Jul 1, 3:21 PM · Restricted Project, Restricted Project

plotfi added a comment to D60974: Clang IFSO driver action..

@ymandel @jfb Thanks for reaching out on this. Apologies for missing this one.

Mon, Jul 1, 3:15 PM · Restricted Project, Restricted Project

plotfi added a comment to D60974: Clang IFSO driver action..

In D60974#1565544, @jfb wrote:

In D60974#1565541, @plotfi wrote:

In D60974#1565527, @jfb wrote:

In D60974#1565517, @jfb wrote:

In D60974#1565054, @plotfi wrote:

So I think I know what may be going on on your end. The llvm-readelf in your path I believe might be the wrong lllvm-readelf (llvm-readelf-7). Are you sure you built llvm-readelf from git?

Please don't do this. Your commit is wrong, and the right action from you is to revert it or fix it. I've fixed it for you here: rL364855

I'm also really not sure this is any good: why does clang look at ELF? In general I'd expect you to test something *way* earlier than ELF. Are you sure you're testing the right thing?

Ah, I must have mistakenly thought that other tools were already using llvm-readelf in cfe. Sorry about this.

This is in fact intended. The interface stubs feature needs to be verified against the actual symbols that are emitted into the elf binary. In the cases where I use llvm-readelf, I am using it to determine if the symbol is visible (to nm for example) but marked hidden in the .o file (but will end up being hidden in when linked).

Currently clang -emit-interface-stubs is not using any elf libraries, but it needs to verify against llvm-nm and/or llvm-readelf in these lit tests to determine if the visibility of the symbols generated in the text stubs is correct.

llvm-nm is already in the list of requirement for clang, so that would be fine to use. I'm not sure llvm-readelf is necessarily built for all targets, so my "fix" might still be broken. It's also another dependency, and a weird one at that. Can you test the property you're looking for in IR directly? And then test, in LLVM, that the same IR generates the ELF binary you want?

Mon, Jul 1, 3:13 PM · Restricted Project, Restricted Project

plotfi updated subscribers of rL364855: Fix breakage introduced by D60974.

In rL364855#666893, @jfb wrote:

FWIW I don't think this is the right fix, and we should revert it once @plotfi fixes the tests from D60974.

Mon, Jul 1, 3:13 PM

plotfi added a comment to rL364855: Fix breakage introduced by D60974.

Thank you @jfb !
I missed this, and hadn't noticed any bots fail on it.

Mon, Jul 1, 3:13 PM

plotfi added a comment to D60974: Clang IFSO driver action..

In D60974#1565527, @jfb wrote:

In D60974#1565517, @jfb wrote:

In D60974#1565054, @plotfi wrote:

So I think I know what may be going on on your end. The llvm-readelf in your path I believe might be the wrong lllvm-readelf (llvm-readelf-7). Are you sure you built llvm-readelf from git?

Please don't do this. Your commit is wrong, and the right action from you is to revert it or fix it. I've fixed it for you here: rL364855

I'm also really not sure this is any good: why does clang look at ELF? In general I'd expect you to test something *way* earlier than ELF. Are you sure you're testing the right thing?

Mon, Jul 1, 3:08 PM · Restricted Project, Restricted Project

plotfi added a comment to D60974: Clang IFSO driver action..

In D60974#1564747, @ymandel wrote:

The tests for this code are failing in my build. Any suggestions welcome.

My setup:

cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=/usr/bin/clang-7 -DCMAKE_CXX_COMPILER=/usr/bin/clang++-7 -DCMAKE_C_FLAGS='-gmlt -Wall' -DCMAKE_CXX_FLAGS='-gmlt -Wall' -DLLVM_PARALLEL_LINK_JOBS=6 -DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra' ../llvm-project/llvm

with head at:

commit 3b7668ae4bb8fabf95bd78dc6a06ca75f6ec3958 (HEAD, origin/master, origin/HEAD)
Author: Matt Arsenault <Matthew.Arsenault@amd.com>
Date:   Mon Jul 1 13:34:26 2019 +0000

    AMDGPU/GlobalISel: Improve icmp selection coverage.
    
    Select s64 eq/ne scalar icmp.
    
    llvm-svn: 364765

The failures:

ninja check-clang
[3586/3587] Running the Clang regression tests
llvm-lit: <...>/llvm-project/llvm/utils/lit/lit/llvm/config.py:340: note: using clang: <...>/build/bin/clang
FAIL: Clang :: InterfaceStubs/virtual.cpp (6035 of 15113)
******************** TEST 'Clang :: InterfaceStubs/virtual.cpp' FAILED ********************
Script:
--
: 'RUN: at line 2';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-TAPI <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp
: 'RUN: at line 5';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-TAPI2 <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp
: 'RUN: at line 8';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp |  llvm-readelf -s - 2>&1 | <...>/build/bin/FileCheck -check-prefix=CHECK-SYMBOLS <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp
--
Exit Code: 1

Command Output (stderr):
--
<...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp:16:23: error: CHECK-SYMBOLS-DAG: expected string not found in input
// CHECK-SYMBOLS-DAG: NOTYPE GLOBAL HIDDEN {{.*}} _ZNK1Q5func1Ev
                      ^
<stdin>:1:1: note: scanning from here
There are 28 section headers, starting at offset 0x718:
^
<stdin>:4:25: note: possible intended match here
 [Nr] Name Type Address Off Size ES Flg Lk Inf Al
                        ^

--

********************
FAIL: Clang :: InterfaceStubs/class-template-specialization.cpp (6041 of 15113)
******************** TEST 'Clang :: InterfaceStubs/class-template-specialization.cpp' FAILED ********************
Script:
--
: 'RUN: at line 2';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-TAPI <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp
: 'RUN: at line 6';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-TAPI2 <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp
: 'RUN: at line 9';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp |  llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-SYMBOLS <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp
--
Exit Code: 1

Command Output (stderr):
--
<...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp:26:23: error: CHECK-SYMBOLS-DAG: expected string not found in input
// CHECK-SYMBOLS-DAG: FUNC GLOBAL DEFAULT {{[0-9]}} _Z1g
                      ^
<stdin>:1:1: note: scanning from here
There are 12 section headers, starting at offset 0x2a8:
^
<stdin>:7:41: note: possible intended match here
 [ 2] .text PROGBITS 0000000000000000 000040 000017 00 AX 0 0 16
                                        ^

--

********************
FAIL: Clang :: InterfaceStubs/hidden-class-inheritance.cpp (6044 of 15113)
******************** TEST 'Clang :: InterfaceStubs/hidden-class-inheritance.cpp' FAILED ********************
Script:
--
: 'RUN: at line 2';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY="" -DCHILD_CLASS_VISIBILITY=""  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-X <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 7';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c  -DPARENT_CLASS_VISIBILITY="" -DCHILD_CLASS_VISIBILITY=""  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-X-RE <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 13';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY=HIDDEN -DCHILD_CLASS_VISIBILITY=""  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-HP <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 18';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY=HIDDEN -DCHILD_CLASS_VISIBILITY=""  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-HP2 <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 23';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c  -DPARENT_CLASS_VISIBILITY=HIDDEN -DCHILD_CLASS_VISIBILITY=""  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-HP-RE <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 29';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY="" -DCHILD_CLASS_VISIBILITY=HIDDEN  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-HC <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 34';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY="" -DCHILD_CLASS_VISIBILITY=HIDDEN  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-HC2 <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 39';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c  -DPARENT_CLASS_VISIBILITY="" -DCHILD_CLASS_VISIBILITY=HIDDEN  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-HC-RE <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 45';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY=HIDDEN -DCHILD_CLASS_VISIBILITY=HIDDEN  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-HP-HC <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 50';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c  -DPARENT_CLASS_VISIBILITY=HIDDEN -DCHILD_CLASS_VISIBILITY=HIDDEN  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-HP-HC-RE <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
--
Exit Code: 1

Command Output (stderr):
--
<...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp:65:16: error: CHECK-X-RE: expected string not found in input
// CHECK-X-RE: FUNC WEAK DEFAULT {{[0-9]+}} _ZN1C1mEv
               ^
<stdin>:1:1: note: scanning from here
There are 48 section headers, starting at offset 0xdb0:
^
<stdin>:7:48: note: possible intended match here
 [ 2] .text PROGBITS 0000000000000000 000040 00005c 00 AX 0 0 16
                                               ^

--

********************
FAIL: Clang :: InterfaceStubs/visibility.cpp (6110 of 15113)
******************** TEST 'Clang :: InterfaceStubs/visibility.cpp' FAILED ********************
Script:
--
: 'RUN: at line 2';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 -fvisibility=hidden  <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp | <...>/build/bin/FileCheck --check-prefix=CHECK-CMD-HIDDEN <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 6';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-yaml-elf-v1 -fvisibility=hidden  <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp | <...>/build/bin/FileCheck --check-prefix=CHECK-CMD-HIDDEN <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 10';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp |  <...>/build/bin/FileCheck --check-prefix=CHECK-CMD <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 14';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-yaml-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp |  <...>/build/bin/FileCheck --check-prefix=CHECK-CMD <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 18';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp |  <...>/build/bin/FileCheck --check-prefix=CHECK-CMD2 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 22';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-yaml-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp |  <...>/build/bin/FileCheck --check-prefix=CHECK-CMD2 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 26';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp | llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-SYMBOLS <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
--
Exit Code: 1

Command Output (stderr):
--
<...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp:44:23: error: CHECK-SYMBOLS-DAG: expected string not found in input
// CHECK-SYMBOLS-DAG: DEFAULT {{.*}} _Z10cmdVisiblev
                      ^
<stdin>:1:1: note: scanning from here
There are 9 section headers, starting at offset 0x2a8:
^
<stdin>:4:34: note: possible intended match here
 [Nr] Name Type Address Off Size ES Flg Lk Inf Al
                                 ^

--

********************
Testing Time: 34.72s
********************
Failing Tests (4):
    Clang :: InterfaceStubs/class-template-specialization.cpp
    Clang :: InterfaceStubs/hidden-class-inheritance.cpp
    Clang :: InterfaceStubs/virtual.cpp
    Clang :: InterfaceStubs/visibility.cpp

  Expected Passes    : 14989
  Expected Failures  : 21
  Unsupported Tests  : 99
  Unexpected Failures: 4
FAILED: tools/clang/test/CMakeFiles/check-clang

where <...> stands for my local clang repo directory.

Mon, Jul 1, 10:35 AM · Restricted Project, Restricted Project

plotfi added a comment to D60974: Clang IFSO driver action..

In D60974#1564747, @ymandel wrote:

The tests for this code are failing in my build. Any suggestions welcome.

My setup:

cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=/usr/bin/clang-7 -DCMAKE_CXX_COMPILER=/usr/bin/clang++-7 -DCMAKE_C_FLAGS='-gmlt -Wall' -DCMAKE_CXX_FLAGS='-gmlt -Wall' -DLLVM_PARALLEL_LINK_JOBS=6 -DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra' ../llvm-project/llvm

with head at:

commit 3b7668ae4bb8fabf95bd78dc6a06ca75f6ec3958 (HEAD, origin/master, origin/HEAD)
Author: Matt Arsenault <Matthew.Arsenault@amd.com>
Date:   Mon Jul 1 13:34:26 2019 +0000

    AMDGPU/GlobalISel: Improve icmp selection coverage.
    
    Select s64 eq/ne scalar icmp.
    
    llvm-svn: 364765

The failures:

ninja check-clang
[3586/3587] Running the Clang regression tests
llvm-lit: <...>/llvm-project/llvm/utils/lit/lit/llvm/config.py:340: note: using clang: <...>/build/bin/clang
FAIL: Clang :: InterfaceStubs/virtual.cpp (6035 of 15113)
******************** TEST 'Clang :: InterfaceStubs/virtual.cpp' FAILED ********************
Script:
--
: 'RUN: at line 2';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-TAPI <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp
: 'RUN: at line 5';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-TAPI2 <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp
: 'RUN: at line 8';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp |  llvm-readelf -s - 2>&1 | <...>/build/bin/FileCheck -check-prefix=CHECK-SYMBOLS <...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp
--
Exit Code: 1

Command Output (stderr):
--
<...>/llvm-project/clang/test/InterfaceStubs/virtual.cpp:16:23: error: CHECK-SYMBOLS-DAG: expected string not found in input
// CHECK-SYMBOLS-DAG: NOTYPE GLOBAL HIDDEN {{.*}} _ZNK1Q5func1Ev
                      ^
<stdin>:1:1: note: scanning from here
There are 28 section headers, starting at offset 0x718:
^
<stdin>:4:25: note: possible intended match here
 [Nr] Name Type Address Off Size ES Flg Lk Inf Al
                        ^

--

********************
FAIL: Clang :: InterfaceStubs/class-template-specialization.cpp (6041 of 15113)
******************** TEST 'Clang :: InterfaceStubs/class-template-specialization.cpp' FAILED ********************
Script:
--
: 'RUN: at line 2';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-TAPI <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp
: 'RUN: at line 6';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-TAPI2 <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp
: 'RUN: at line 9';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp |  llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-SYMBOLS <...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp
--
Exit Code: 1

Command Output (stderr):
--
<...>/llvm-project/clang/test/InterfaceStubs/class-template-specialization.cpp:26:23: error: CHECK-SYMBOLS-DAG: expected string not found in input
// CHECK-SYMBOLS-DAG: FUNC GLOBAL DEFAULT {{[0-9]}} _Z1g
                      ^
<stdin>:1:1: note: scanning from here
There are 12 section headers, starting at offset 0x2a8:
^
<stdin>:7:41: note: possible intended match here
 [ 2] .text PROGBITS 0000000000000000 000040 000017 00 AX 0 0 16
                                        ^

--

********************
FAIL: Clang :: InterfaceStubs/hidden-class-inheritance.cpp (6044 of 15113)
******************** TEST 'Clang :: InterfaceStubs/hidden-class-inheritance.cpp' FAILED ********************
Script:
--
: 'RUN: at line 2';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY="" -DCHILD_CLASS_VISIBILITY=""  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-X <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 7';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c  -DPARENT_CLASS_VISIBILITY="" -DCHILD_CLASS_VISIBILITY=""  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-X-RE <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 13';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY=HIDDEN -DCHILD_CLASS_VISIBILITY=""  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-HP <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 18';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY=HIDDEN -DCHILD_CLASS_VISIBILITY=""  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-HP2 <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 23';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c  -DPARENT_CLASS_VISIBILITY=HIDDEN -DCHILD_CLASS_VISIBILITY=""  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-HP-RE <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 29';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY="" -DCHILD_CLASS_VISIBILITY=HIDDEN  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-HC <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 34';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY="" -DCHILD_CLASS_VISIBILITY=HIDDEN  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-HC2 <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 39';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c  -DPARENT_CLASS_VISIBILITY="" -DCHILD_CLASS_VISIBILITY=HIDDEN  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-HC-RE <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 45';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1  -DPARENT_CLASS_VISIBILITY=HIDDEN -DCHILD_CLASS_VISIBILITY=HIDDEN  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  <...>/build/bin/FileCheck -check-prefix=CHECK-HP-HC <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
: 'RUN: at line 50';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c  -DPARENT_CLASS_VISIBILITY=HIDDEN -DCHILD_CLASS_VISIBILITY=HIDDEN  -DPARENT_METHOD_VISIBILITY="" -DCHILD_METHOD_VISIBILITY="" <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp |  llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-HP-HC-RE <...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp
--
Exit Code: 1

Command Output (stderr):
--
<...>/llvm-project/clang/test/InterfaceStubs/hidden-class-inheritance.cpp:65:16: error: CHECK-X-RE: expected string not found in input
// CHECK-X-RE: FUNC WEAK DEFAULT {{[0-9]+}} _ZN1C1mEv
               ^
<stdin>:1:1: note: scanning from here
There are 48 section headers, starting at offset 0xdb0:
^
<stdin>:7:48: note: possible intended match here
 [ 2] .text PROGBITS 0000000000000000 000040 00005c 00 AX 0 0 16
                                               ^

--

********************
FAIL: Clang :: InterfaceStubs/visibility.cpp (6110 of 15113)
******************** TEST 'Clang :: InterfaceStubs/visibility.cpp' FAILED ********************
Script:
--
: 'RUN: at line 2';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 -fvisibility=hidden  <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp | <...>/build/bin/FileCheck --check-prefix=CHECK-CMD-HIDDEN <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 6';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-yaml-elf-v1 -fvisibility=hidden  <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp | <...>/build/bin/FileCheck --check-prefix=CHECK-CMD-HIDDEN <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 10';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp |  <...>/build/bin/FileCheck --check-prefix=CHECK-CMD <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 14';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-yaml-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp |  <...>/build/bin/FileCheck --check-prefix=CHECK-CMD <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 18';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-tapi-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp |  <...>/build/bin/FileCheck --check-prefix=CHECK-CMD2 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 22';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs  -interface-stub-version=experimental-yaml-elf-v1 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp |  <...>/build/bin/FileCheck --check-prefix=CHECK-CMD2 <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
: 'RUN: at line 26';   <...>/build/bin/clang -target x86_64-unknown-linux-gnu -o - -c <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp | llvm-readelf -s - 2>&1 |  <...>/build/bin/FileCheck -check-prefix=CHECK-SYMBOLS <...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp
--
Exit Code: 1

Command Output (stderr):
--
<...>/llvm-project/clang/test/InterfaceStubs/visibility.cpp:44:23: error: CHECK-SYMBOLS-DAG: expected string not found in input
// CHECK-SYMBOLS-DAG: DEFAULT {{.*}} _Z10cmdVisiblev
                      ^
<stdin>:1:1: note: scanning from here
There are 9 section headers, starting at offset 0x2a8:
^
<stdin>:4:34: note: possible intended match here
 [Nr] Name Type Address Off Size ES Flg Lk Inf Al
                                 ^

--

********************
Testing Time: 34.72s
********************
Failing Tests (4):
    Clang :: InterfaceStubs/class-template-specialization.cpp
    Clang :: InterfaceStubs/hidden-class-inheritance.cpp
    Clang :: InterfaceStubs/virtual.cpp
    Clang :: InterfaceStubs/visibility.cpp

  Expected Passes    : 14989
  Expected Failures  : 21
  Unsupported Tests  : 99
  Unexpected Failures: 4
FAILED: tools/clang/test/CMakeFiles/check-clang

where <...> stands for my local clang repo directory.

Mon, Jul 1, 9:31 AM · Restricted Project, Restricted Project

Sun, Jun 30

plotfi updated the diff for D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver..

Removing obvious comment.

Sun, Jun 30, 10:30 AM · Restricted Project

plotfi updated the diff for D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver..

Add full context, change std::set to llvm::SmallSet

Sun, Jun 30, 10:28 AM · Restricted Project

plotfi added inline comments to D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver..

Sun, Jun 30, 10:19 AM · Restricted Project

plotfi updated the diff for D63978: Very early work on interface stub merger plumbing. .

had some accidentally not-removed stray print output and/or expletives, apologies.

Sun, Jun 30, 10:13 AM · Restricted Project

plotfi created D63978: Very early work on interface stub merger plumbing. .

Sun, Jun 30, 10:11 AM · Restricted Project

plotfi added a reviewer for D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver.: compnerd.

Sun, Jun 30, 10:03 AM · Restricted Project

plotfi created D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver..

Sun, Jun 30, 10:03 AM · Restricted Project

Jun 20 2019

plotfi committed rG678e19d80c2a: [NFC] Fix for InterfaceStubs tests (adding REQUIRES: x86-registered-target). (authored by plotfi).

[NFC] Fix for InterfaceStubs tests (adding REQUIRES: x86-registered-target).

Jun 20 2019, 11:25 AM

plotfi added a comment to D60974: Clang IFSO driver action..

This was re-landed in r363948

Jun 20 2019, 10:02 AM · Restricted Project, Restricted Project

plotfi committed rG68f29dac4be8: [clang-ifs] Clang Interface Stubs, first version (second landing attempt). (authored by plotfi).

[clang-ifs] Clang Interface Stubs, first version (second landing attempt).

Jun 20 2019, 10:00 AM

Jun 19 2019

plotfi committed rGd5d15b4c1fd9: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC). (authored by plotfi).

[clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

Jun 19 2019, 11:00 PM

plotfi added inline comments to D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC)..

Jun 19 2019, 5:43 PM · Restricted Project, Restricted Project

plotfi updated the diff for D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC)..

full context

Jun 19 2019, 5:42 PM · Restricted Project, Restricted Project

plotfi updated the diff for D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC)..

moving datalayout.h

Jun 19 2019, 5:41 PM · Restricted Project, Restricted Project

plotfi updated the summary of D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC)..

Jun 19 2019, 5:35 PM · Restricted Project, Restricted Project

plotfi created D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC)..

Jun 19 2019, 5:32 PM · Restricted Project, Restricted Project

plotfi updated the diff for D60974: Clang IFSO driver action..

This should address the shared lib issue.

Jun 19 2019, 3:29 PM · Restricted Project, Restricted Project

plotfi committed rG3ff8c3b73f6d: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC). (authored by plotfi).

[clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC).

Jun 19 2019, 1:49 PM

plotfi added inline comments to D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..

Jun 19 2019, 11:41 AM · Restricted Project, Restricted Project

plotfi updated the diff for D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..

Update to address @aaron.ballman's catch that ASTNameGenerator was not private enough.

Jun 19 2019, 11:09 AM · Restricted Project, Restricted Project

plotfi added inline comments to D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..

Jun 19 2019, 10:21 AM · Restricted Project, Restricted Project

plotfi retitled D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC). from [clang][AST] MangleUtil: A refactoring of CodegenNameGeneratorImpl (NFC). to [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..

Jun 19 2019, 10:00 AM · Restricted Project, Restricted Project

plotfi updated the diff for D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..

Addressing @compnerd's feedback.

Jun 19 2019, 10:00 AM · Restricted Project, Restricted Project

Jun 18 2019

plotfi created D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..

Jun 18 2019, 8:03 PM · Restricted Project, Restricted Project

Jun 17 2019

plotfi added a comment to D60974: Clang IFSO driver action..

In D60974#1547682, @MaskRay wrote:

@plotfi Sorry I have to revert this patch. This can also cause problems in -DBUILD_SHARED_LIBS=off builds. clangFrontend files cannot #include "clang/Index/CodegenNameGenerator.h", I think you may have to move files around.

Jun 17 2019, 11:08 PM · Restricted Project, Restricted Project

plotfi added a comment to D60974: Clang IFSO driver action..

I had to back out r363646. While it worked for me building locally with and without shared lib, it appears to have caused bots to break. I will take another look at fixing it in about 10 hours.

Jun 17 2019, 10:16 PM · Restricted Project, Restricted Project

plotfi committed rG4d36782446da: [NFC] Undoing r363646 to fix bots. (authored by plotfi).

[NFC] Undoing r363646 to fix bots.

Jun 17 2019, 10:14 PM

plotfi committed rGe86b89ba46ec: [NFC] Fixing -DBUILD_SHARED_LIBS=ON problem caused by layering issue in D60974 (authored by plotfi).

[NFC] Fixing -DBUILD_SHARED_LIBS=ON problem caused by layering issue in D60974

Jun 17 2019, 9:40 PM

plotfi added inline comments to D60974: Clang IFSO driver action..

Jun 17 2019, 9:39 PM · Restricted Project, Restricted Project

plotfi added inline comments to D60974: Clang IFSO driver action..

Jun 17 2019, 7:18 PM · Restricted Project, Restricted Project

plotfi added inline comments to D60974: Clang IFSO driver action..