- User Since
- Nov 30 2017, 10:52 AM (304 w, 3 d)
Tue, Sep 12
Apr 13 2023
Mar 17 2023
Nov 1 2022
LGTM, Nice work John.
Oct 11 2022
Oct 6 2022
LGTM but waiting on Akira would be nice imho.
@ahatanak how does this diff look to you?
Sep 28 2022
Sep 27 2022
Sep 26 2022
Updated based on @ahatanak's feedback.
Sep 23 2022
Sep 21 2022
I think the decision tree goes
Sep 20 2022
Sep 13 2022
Sep 10 2022
Adding a test case to cover @protocol methods not being allowed to contain direct
Sep 9 2022
Updated to use mangleObjCMethodName in clang/lib/AST/Mangle.cpp to set the _+<a: > direct method name.
Updated with some of @mwyman's feedback.
Aug 8 2022
Updating implementation to use an objc_direct_visible attr to explicitly mark when we want objc_direct to be exposed outside of the link unit.
I tried running the following on some example code and got a stacktrace:
Jul 19 2022
Jun 29 2022
Jun 21 2022
Thanks for the feedback on corner cases @aaron.ballman, this will give me more concrete things to think about here.
This is pretty incomplete. Please ignore for now.
Apr 5 2022
@rjmccall would you be able to review this patch? What do you think of this approach? This change is to support C++-Interop on the Swift side.
Jan 25 2022
Oct 15 2021
Jun 28 2021
Jun 10 2021
May 3 2021
LGTM once you've addressed @phosek's nits.
Mar 31 2021
Mar 30 2021
Mar 25 2021
I will take another look over this commit in the morning. Overall looks good.
Mar 3 2021
This makes sense to me. I approve. Can we move the 3/60 seconds number to a const int value set somewhere higher up in the file as a global with a comment explaining this as well?
Feb 16 2021
If @compnerd has no gripes go ahead and land. LGTM.
Before landing, please make sure to run the check-clang tests as well because the interface stubs generation on the clang driver side invokes llvm-ifs.
Feb 1 2021
Ping? Haven't seen any chatter in a while. Anything new here? I don't want to hold you folks up.
Jan 24 2021
@wolfgangp I get this warning on macOS. I noticed it wasn't fixed in https://github.com/llvm/llvm-project/commit/c6e8f81410a2942b5abd112aa6e468268e01d946#diff-67f7be4aff998787c9c4efcb95e5d0dc225e1dcd37b9b005a3db5493f02efdc3 so I posted this small diff.
Jan 20 2021
Is this still open? Seems good to go.
Jan 12 2021
Jan 11 2021
- I think for unification, the first thing would be unifying the text abi file format. Currently, the YAML format used by ifs is very similar to the one used in InterfaceStub(elfabi), however there are not compatible. One thing is that ifs embeds llvm triples in the text ifs file while elfabi does not do that. Elfabi get platform and endianness information from command line instead of getting them from the text stub file. We did that because there are use cases that we generate ELF stubs for multiple platforms using a single set of text abi files. Is there a specific reason why ifs text files require llvm triples? Is it feasible to make llvm-ifs to get the platform information from the command line options?
Oct 27 2020
Updated based on @paquette's feedback. This only includes the StableHashTree data structure and a unit test.
Oct 23 2020
Nice. Will you folks be updating llvm-ifs to use this support instead of yaml2obj soon? If so add me to the review, I will be happy to take a look.
Oct 20 2020
Thanks for fixing this @cishida!
I think I am overall ok with this for now until the TBE folks post some more patches to integrate ifs and tbe.
Oct 7 2020
@vsk any update on this? Is there anything we can do to help in landing this patch in llvm-project/main?
Oct 1 2020
Overall looks good.
Sep 24 2020
spelling and grammar
Cleaning up patch to be easier to understand.
@sdesmalen @efriedma @dmgreen Hi Sander, Eli, Dave. Would any of you have some time to help review this Prolog Epilog Size optimization patch? Much appreciated if you do. Me and @kyulee would be available to chat on IRC or discord about it for more info.