- User Since
- Nov 30 2017, 10:52 AM (151 w, 3 d)
Fri, Oct 23
Nice. Will you folks be updating llvm-ifs to use this support instead of yaml2obj soon? If so add me to the review, I will be happy to take a look.
Tue, Oct 20
Thanks for fixing this @cishida!
I think I am overall ok with this for now until the TBE folks post some more patches to integrate ifs and tbe.
Wed, Oct 7
@vsk any update on this? Is there anything we can do to help in landing this patch in llvm-project/main?
Thu, Oct 1
Overall looks good.
Sep 24 2020
spelling and grammar
Cleaning up patch to be easier to understand.
@sdesmalen @efriedma @dmgreen Hi Sander, Eli, Dave. Would any of you have some time to help review this Prolog Epilog Size optimization patch? Much appreciated if you do. Me and @kyulee would be available to chat on IRC or discord about it for more info.
Sep 23 2020
Sep 18 2020
Sep 15 2020
Sep 14 2020
Sep 8 2020
Sep 3 2020
Sep 2 2020
I've updated the diff to reflect the alternate non-wrapper exposure. This way requires the sanitizing of the exported objc_direct method name.
Sep 1 2020
Aug 29 2020
Aug 26 2020
Aug 25 2020
Aug 23 2020
LGTM. Go ahead and land it.
Aug 20 2020
@lanza I did it as a CodeGen option for now because we don't want anything like this to be the default until the ABI is fleshed out.
I think one danger in altering the name of the function to some extent is you dont want to clash potentially with user defined C functions.
Aug 19 2020
Ok, LGTM. I will land for you, but in your name on git. Thanks for this patch @kyulee.
Aug 18 2020
Aug 17 2020
change for clang-tidy and clang-format.
I think this LGTM. @kyulee are there any other tests that use this flag? Can you add a test that both adds and also removes some different attributes. Also a test that adds and removes he same attribute too would be good.
Good stuff. Thanks for replying so quickly @fhahn :-)
Aug 15 2020
@fhahn I ran into an llvm_unreachable when building matrix-types-spec.cpp as part of an llvm-test-suite build using -Oz with -flto=thin. I reduced the IR that hit the unreachable to:
Aug 14 2020
Please Update Diff.
Aug 11 2020
Aug 10 2020
Overall this change makes sense. I don't see why we shouldn't have this ability to remove attrs.
Closing, cause phab doesn't seem to be auto-closing.
Landed at https://github.com/llvm/llvm-project/commit/7bc03f55539f7f081daea5363f2e4845b2e75f57
Aug 9 2020
Aug 8 2020
Adding BLR-based test case that explodes LR and all other registers to achieve the same assert without noreturn.
Jul 22 2020
Jul 21 2020
Update based on @paquette's feedback
Jul 20 2020
@t.p.northover gentle ping
Solidified the cases where we want to bail out after speaking with @paquette some more