I think this change might be breaking builds: http://lab.llvm.org:8011/builders/clang-aarch64-linux-build-cache/builds/16888

Nice! Thanks @phosek. I’m fine with a revert. Currently away from keyboard.

Where are your bots?

Ah I get it, because ld64 is tbd-aware the end product is the text. I’m still not sure if I will add any support to lld for something like ifs, things still seem good just using the ifs text format for the intermediate symbol merging.

Adding better wiring up to llvm-ifs

Does this addition mean that llvm-nm should eventually include some support for other text formats like ifs/elfabi etc? I think this could be pretty useful for writing tests, which I assume is part of the motivation here?

In D67255#1660946, @cishida wrote:

bridgeOS hasn't been added to llvm triple yet, so it's fine to exclude it for now.
also I have a patch I'm adding very soon that takes in llvm::triple and does the arch/platform mapping so you won't need to. I'll update this file when it comes out.

In D67209#1660346, @uabelho wrote:

Hi,

I did a minor change to the test case in r371171 since the

;CHECK: bb

checks matched on the line

;ModuleID = '/repo/bb/

in the output instead of the wanted "bb.0:".

I fixed it by reading input from stdin instead of from the file to make the change as small as possible, but perhaps the

;CHECK: bb

lines should be changed to

;CHECK-LABEL: bb.0:

etc instead.

Ping?

addressing @paquette's feedback

More comments.

addressing @paquette's suggestions.

Moving the guts of the candidate walk loop into the reusable MIRVRegNamer.cpp library

Sounds good.

longer flags, no more =

better diag, better test names

adding .data and .rodata to elf sections

In D66029#1648887, @mpaszkowski wrote:

Gentle ping ;)

I would like to ask someone to commit this for me. I don't have commit rights.

• Dropping vestigial ELFSymbols, now I have IFSSymbol.
• addressed @compnerd 's feedback

More version checks

Checking for conflicts in the Ifs header.

Added some better conflict checking tests.

test updates based on feedback

adding another test, to merge objects and funcs of different sizes.

Adding some tests. and added some really basic symbol conflict error checking (no resolution though).

• Addressing @compnerd's feedback, still need to do some smarter conflict resolution for symbols and add tests.
• Added rudimentary TBD support.

Better diag

Looking a lot better.

@jakehehrlich Haven't seen an update on this diff in a while. How are things going?

Adding ObjectFileFormat

In D66405#1634787, @MaskRay wrote:

There is another tool tools/llvm-elfabi that does something very similar. (To be honest I don't quite get the point why that tool is required and why it has to be a llvm tool.) Nevertheless, it exists there, though not actively developed. Does this tool intend to replace/complement it?

Updated. Much better cleaner implementation.

@aaron.ballman Good catch on the /Yc /Yu args. I like the way its looking a lot more now.

Moved the initialization of YcArg and YuArg and initial handling of those args into handleArguments. ninja check-clang passes.

@aaron.ballman How does this look to you?

really sorry for how bad this diff looks. phab just doesnt present in a very ideal way.

Please add lit tests.