Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| clang/lib/CodeGen/CGBuiltin.cpp | ||
|---|---|---|
| 5612–5613 | Is there a reason you can't do a single cast here? | |
| clang/lib/CodeGen/CGBuiltin.cpp | ||
|---|---|---|
| 5612–5613 | GetNeonType should probably just return a FixedVectorType. | |
Comment Actions
there's a few places the getNumElements calls can be fixed by getting the initial cast right
| clang/lib/CodeGen/CGBuiltin.cpp | ||
|---|---|---|
| 5982 | cast here | |
| 9879 | cast here | |
| clang/lib/CodeGen/CGExpr.cpp | ||
| 1765 | cast here | |
| 1799 | cast here | |
| 2214 | missed one here | |
| clang/lib/CodeGen/CGExprScalar.cpp | ||
| 1638 | cast here | |
| clang/lib/CodeGen/SwiftCallingConv.cpp | ||
| 321 | cast here | |
Comment Actions
I plan to investigate the changes proposed by @c-rhodes. I'm a bit swamped right now so it may take a bit.
Is there a reason you can't do a single cast here?