Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
5623–5625 | Is there a reason you can't do a single cast here? |
clang/lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
5623–5625 | GetNeonType should probably just return a FixedVectorType. |
Comment Actions
there's a few places the getNumElements calls can be fixed by getting the initial cast right
clang/lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
5994 | cast here | |
9840 | cast here | |
clang/lib/CodeGen/CGExpr.cpp | ||
1770 | cast here | |
1804 | cast here | |
2219 | missed one here | |
clang/lib/CodeGen/CGExprScalar.cpp | ||
1561 | cast here | |
clang/lib/CodeGen/SwiftCallingConv.cpp | ||
321 | cast here |
Comment Actions
I plan to investigate the changes proposed by @c-rhodes. I'm a bit swamped right now so it may take a bit.
Is there a reason you can't do a single cast here?