Adds implementation of getMainExecutable() and is_local_impl() to Support/Unix/Path.inc.
Both are needed to compile LLVM for z/OS.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
some nitpick comments. I'm not familiar with z/OS's APIs here so not qualified to fully review the change in getMainExecutable but seems reasonable
llvm/lib/Support/Unix/Path.inc | ||
---|---|---|
55 | this should probably be part of the #ifdef/#elif block? | |
70 | Maybe this? #if !defined(PATH_MAX) # if defined(__GNU__) # define PATH_MAX 4096 # elif defined(__MVS__) # define PATH_MAX _XOPEN_PATH_MAX # endif #endif |
Comment Actions
- Moved the first #if defined(__MVS__) into the if/elif casecade right above
- Rearranged the #if !defined(PATH_MAX) guarded section
llvm/lib/Support/Unix/Path.inc | ||
---|---|---|
62–63 | Minor nit: The comment placement is awkward here. It would work just find inside the __GNU__ block. |
this should probably be part of the #ifdef/#elif block?