Bfloat16 support added for the following intrinsics:
- ST1
- STNT1
Paths
| Differential D82448
[AArch64][SVE] Add bfloat16 support to store intrinsics ClosedPublic Authored by kmclaughlin on Jun 24 2020, 3:42 AM.
Details Summary Bfloat16 support added for the following intrinsics:
Diff Detail
Event TimelineHerald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 24 2020, 3:42 AM Herald added subscribers: llvm-commits, cfe-commits, danielkiss and 5 others. · View Herald Transcript Comment Actions LGTM, just one nit. Francesco
This revision is now accepted and ready to land.Jun 24 2020, 7:25 AM Comment Actions
Comment Actions Thank you for updating the patch with the missing tests. I only have one request for the code involving assertions, and the use of let Predicates = .... Francesco
This revision now requires changes to proceed.Jun 24 2020, 11:50 AM Comment Actions
Comment Actions Thanks for reviewing this again, @fpetrogalli!
Comment Actions LGTM, thank you!
This revision is now accepted and ready to land.Jun 25 2020, 7:46 AM Closed by commit rGedcfef8fee13: [AArch64][SVE] Add bfloat16 support to store intrinsics (authored by kmclaughlin). · Explain WhyJun 26 2020, 3:14 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 273641 clang/include/clang/Basic/arm_sve.td
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_stnt1-bfloat.c
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
llvm/test/CodeGen/AArch64/sve-intrinsics-st1-addressing-mode-reg-imm.ll
llvm/test/CodeGen/AArch64/sve-intrinsics-st1-addressing-mode-reg-reg.ll
llvm/test/CodeGen/AArch64/sve-intrinsics-st1.ll
llvm/test/CodeGen/AArch64/sve-intrinsics-stores.ll
llvm/test/CodeGen/AArch64/sve-masked-ldst-nonext.ll
llvm/test/CodeGen/AArch64/sve-pred-contiguous-ldst-addressing-mode-reg-imm.ll
llvm/test/CodeGen/AArch64/sve-pred-contiguous-ldst-addressing-mode-reg-reg.ll
llvm/test/CodeGen/AArch64/sve-pred-non-temporal-ldst-addressing-mode-reg-imm.ll
llvm/test/CodeGen/AArch64/sve-pred-non-temporal-ldst-addressing-mode-reg-reg.ll
|
Nit: is it worth adding the ASM-NOT: warning check that is used in other tests? Of course, only if it doesn't fail, for in such case we would have to address the problem in a separate patch.
(Same for all the new C tests added in this patch).