This patch is part of supporting -fstack-clash-protection. Implemented probing when emitting prologue.
Details
- Reviewers
hfinkel jonpa serge-sans-paille nemanjai sfertile jsji - Group Reviewers
Restricted Project - Commits
- rGc352e0885a6b: [PowerPC] Implement probing for prologue
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/PowerPC/PPCFrameLowering.cpp | ||
---|---|---|
681 | We are in prologue, there shouldn't be any use of cr before this, why can't we simply always use CR0 here? | |
1032–1042 | Can we add comments about free probe? | |
1034 | Add comment about why we need this pseudo? and when it will be handled. | |
1374 | Where -> StackAllocAIPos ? | |
1409 | Comments/code mismatch? We are generating RLDICL/RLWINM below, please add comments about the calculation as well.. | |
1439 | What if we can't find CR and we don't build with assert on? | |
1448 | There are several instance of similar code, maybe worth a NFC refactor first. | |
1461 | We have to check. and do Residual block regardless of NumBlocks, please move it out of if/else. | |
1470 | Shall we recomputeLiveIns for both LoopMBB and ExitBB? |
Address @jsji 's comments.
Use CTR loop to synthesize probe loop so that we can use a GPR to materialize large probe size.
We are in prologue, there shouldn't be any use of cr before this, why can't we simply always use CR0 here?