This is an archive of the discontinued LLVM Phabricator instance.

[XCOFF][AIX] Use 'L..' instead of '.L' for getPrivateGlobalPrefix in DataLayout
ClosedPublic

Authored by jasonliu on Jun 5 2020, 9:14 AM.

Details

Summary

D80831 changed part of the prefix usage for AIX. But there are other places getting prefix from DataLayout.
This patch intends to make prefix usage consistent on AIX.

Diff Detail

Event Timeline

jasonliu created this revision.Jun 5 2020, 9:14 AM
llvm/lib/IR/DataLayout.cpp
450

This is an addition to the IR. Should there be a bitcode test?

llvm/lib/IR/DataLayout.cpp
450

There should be an update to the LLVM Language Reference Manual.

Based on the result of the pre-merge checks, do we need to include the clang change in the scope here?

Based on the result of the pre-merge checks, do we need to include the clang change in the scope here?

Yes, looks like I need to include the clang portion as well. Thanks!

jasonliu updated this revision to Diff 269304.Jun 8 2020, 12:02 PM

Added clang portion of the change.
Added unittest to test mangler.
Added description in Language Reference Manual.

jasonliu marked 3 inline comments as done.Jun 8 2020, 12:04 PM
jasonliu added inline comments.
llvm/lib/IR/DataLayout.cpp
450

This is an addition to the IR. Should there be a bitcode test?

I added an unittest in IR, hope that's enough.

jasonliu edited the summary of this revision. (Show Details)Jun 8 2020, 12:04 PM
clang/lib/Basic/Targets/PPC.h
352–355

Triple.isOSAIX() is used by D79719; do we want to be consistent in using that?

401–405

Triple.isOSAIX() is used by D79719; do we want to be consistent in using that?

jasonliu updated this revision to Diff 272429.Jun 22 2020, 7:33 AM

Use Triple.isOSAIX() instead.

jasonliu marked 2 inline comments as done.Jun 22 2020, 7:33 AM

Gentle ping.

This revision is now accepted and ready to land.Jul 2 2020, 12:14 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2020, 11:53 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript