Added codegen for use_device_addr clause. The components of the list
items are mapped as a kind of RETURN components and then the returned
base address is used instead of the real address of the base declaration
used in the use_device_addr expressions.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/lib/CodeGen/CGOpenMPRuntime.cpp | ||
---|---|---|
7631 | I'm not a fan of this implicit encoding. Can't we add a new map type or modifier? |
Comment Actions
I was hoping @dreachem and maybe @RaviNarayanaswamy would look at this.
clang/lib/CodeGen/CGOpenMPRuntime.cpp | ||
---|---|---|
7631 | Better, thanks. The comment change is probably not needed anymore. |
Comment Actions
One nit below, the others seem silent. LGTM.
clang/lib/Sema/SemaOpenMP.cpp | ||
---|---|---|
18438 | Leftover? |
clang/lib/Sema/SemaOpenMP.cpp | ||
---|---|---|
18438 | Yes, forgot to remove |
Comment Actions
Hi, you can drop Reviewers: Subscribers: Tags: and the text Summary: with the following script
arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F - }
Reviewed By: is considered important by some people. You should keep the tag. (I have updated my script to use --date=now (setting author date to committer date))
https://reviews.llvm.org/D80978 contains a git pre-push hook to automate this.
I'm not a fan of this implicit encoding. Can't we add a new map type or modifier?