Page MenuHomePhabricator

[llvm] [CodeGen] [X86] Fix issues with v4i1 instruction selection
ClosedPublic

Authored by aartbik on Tue, May 19, 1:08 PM.

Diff Detail

Event Timeline

aartbik created this revision.Tue, May 19, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, May 19, 1:09 PM
craig.topper added inline comments.Tue, May 19, 1:31 PM
llvm/lib/Target/X86/X86ISelLowering.cpp
39635

Can we just change this to EVT instead?

aartbik updated this revision to Diff 265117.Tue, May 19, 7:56 PM
aartbik marked 2 inline comments as done.

added regression test for select as well, addressed comment

This revision is now accepted and ready to land.Tue, May 19, 9:03 PM
aartbik added inline comments.Tue, May 19, 10:13 PM
llvm/lib/Target/X86/X86ISelLowering.cpp
39635

Yes, that works too. Thanks! I changed it, and also added a regression test for the previous crash, just to make sure this keeps working.

RKSimon added inline comments.
llvm/test/CodeGen/X86/pr45995-2.ll
3

Both these run args look over constrained - llc -mtriple=x86_64-- -mattr=+avx512dq,+avx512vl might be enough?

aartbik added inline comments.Wed, May 20, 11:39 AM
llvm/test/CodeGen/X86/pr45995-2.ll
3

Oops, I started the land already, but should have addressed this first. Apologizes.
Happy to relax this in a follow-up if needed. But just curious, what are the (dis)advantages of adding some extra args in a crash-before/pass-after regression test?
(but I agree that e.g. the syntax flag is a personal setting)

This revision was automatically updated to reflect the committed changes.