Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

People reidtatge

reidtatge (Reid Tatge)
User

Projects

User does not belong to any projects.

User Details

User Since
May 7 2020, 4:13 PM (185 w, 4 d)

Recent Activity
View All

Sep 1 2023

reidtatge added a comment to D158790: [MDL] First full integration of MDL with LLVM.

Hi Michael, responses to your questions and comments!

Sep 1 2023, 11:01 AM · Restricted Project, Restricted Project
reidtatge added a comment to D158790: [MDL] First full integration of MDL with LLVM.
In D158790#4626610, @lattner wrote:

This is exciting! Please start a thread to discuss integrating this on the forum, this is a significant enough change and addition that I expect many folks to have opinions.

Sep 1 2023, 10:17 AM · Restricted Project, Restricted Project

Aug 31 2023

reidtatge added a comment to D158790: [MDL] First full integration of MDL with LLVM.

Will do.

Aug 31 2023, 10:51 AM · Restricted Project, Restricted Project

Aug 29 2023

reidtatge updated the summary of D158790: [MDL] First full integration of MDL with LLVM.
Aug 29 2023, 10:52 AM · Restricted Project, Restricted Project

Aug 28 2023

reidtatge updated the summary of D158790: [MDL] First full integration of MDL with LLVM.
Aug 28 2023, 2:54 PM · Restricted Project, Restricted Project
reidtatge updated the summary of D158790: [MDL] First full integration of MDL with LLVM.
Aug 28 2023, 2:54 PM · Restricted Project, Restricted Project

Aug 25 2023

reidtatge updated the diff for D158790: [MDL] First full integration of MDL with LLVM.

Fixed build problems

Aug 25 2023, 2:52 PM · Restricted Project, Restricted Project
reidtatge updated subscribers of D158790: [MDL] First full integration of MDL with LLVM.

It looks like I rebased with a version that includes the commit you
reverted. This is messy...

Aug 25 2023, 10:40 AM · Restricted Project, Restricted Project

Aug 24 2023

reidtatge requested review of D158790: [MDL] First full integration of MDL with LLVM.
Aug 24 2023, 4:05 PM · Restricted Project, Restricted Project

Aug 4 2020

reidtatge accepted D84888: [mlir] [VectorOps] Add expand/compress operations to Vector dialect.
Aug 4 2020, 10:36 AM · Restricted Project
reidtatge added inline comments to D84888: [mlir] [VectorOps] Add expand/compress operations to Vector dialect.
Aug 4 2020, 10:36 AM · Restricted Project

Jul 29 2020

reidtatge accepted D84699: [mlir] [VectorOps] [integration_test] Sparse matrix times vector (jagged SAXPY version).

Nice. LGTM

Jul 29 2020, 12:49 PM · Restricted Project

Jun 29 2020

reidtatge accepted D82674: [mlir] [VectorOps] Extend vector reduction integration test with reassoc=true cases..
Jun 29 2020, 12:28 PM · Restricted Project

Jun 19 2020

reidtatge accepted D82144: [mlir] [VectorOps] Improve vector.constant_mask lowering.

LGTM

Jun 19 2020, 10:18 AM · Restricted Project

Jun 9 2020

reidtatge accepted D81503: [mlir] [VectorOps] Handle 'vector.shape_cast' lowering for all cases.

Regarding the loop starting on line 1502: it bugs me that there's no readable/efficient way to assert "don't do this on the first (or last) iteration".

Jun 9 2020, 3:28 PM · Restricted Project

May 14 2020

reidtatge accepted rGfb2c4d50f142: [mlir] [VectorOps] Implement vector.constant_mask lowering to LLVM IR.
May 14 2020, 12:31 PM

May 11 2020

reidtatge committed rG334a4159eca0: [mlir][Vector] NFC - Rename vector.strided_slice into vector. (authored by reidtatge).
[mlir][Vector] NFC - Rename vector.strided_slice into vector.
May 11 2020, 2:36 PM
reidtatge closed D79734: [mlir][VectorOps] NFC - Rename vector.strided_slice into vector.extract_strided_slice.
May 11 2020, 2:35 PM · Restricted Project
reidtatge retitled D79734: [mlir][VectorOps] NFC - Rename vector.strided_slice into vector.extract_strided_slice from [mlir][Vector] NFC - Rename vector.strided_slice into vector.extract_strided_slice to [mlir][VectorOps] NFC - Rename vector.strided_slice into vector.extract_strided_slice.
May 11 2020, 2:35 PM · Restricted Project
reidtatge retitled D79734: [mlir][VectorOps] NFC - Rename vector.strided_slice into vector.extract_strided_slice from Rename vector.strided_slice into vector.extract_strided_slice to [mlir][Vector] NFC - Rename vector.strided_slice into vector.extract_strided_slice.
May 11 2020, 2:35 PM · Restricted Project
Herald added a reviewer for D79734: [mlir][VectorOps] NFC - Rename vector.strided_slice into vector.extract_strided_slice: aartbik.
May 11 2020, 11:50 AM · Restricted Project