Page MenuHomePhabricator

[DAG] SimplifyMultipleUseDemandedBits - remove superfluous bitcasts

Authored by RKSimon on Thu, May 7, 6:42 AM.



If the SimplifyMultipleUseDemandedBits calls BITCASTs that peek through back to the original type then we can remove the BITCASTs entirely.

I think this is a win in all cases but wanted to double check with AMDGPU/THUMB2 guys.

Diff Detail

Event Timeline

RKSimon created this revision.Thu, May 7, 6:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, May 7, 6:42 AM
dmgreen added inline comments.Thu, May 7, 9:15 AM

These are both OK I think. Both tests are mostly "we don't crash" kind of tests, and the changes look OK, considering the input.

foad added a subscriber: foad.Fri, May 8, 1:02 AM

@arsenm Does the amdgpu/fshr.ll change look ok to you?

arsenm added inline comments.Fri, May 8, 6:26 AM

This is better

spatel accepted this revision.Fri, May 8, 7:25 AM

Seems obviously correct and x86 diffs LGTM.

This revision is now accepted and ready to land.Fri, May 8, 7:25 AM
This revision was automatically updated to reflect the committed changes.