This revision adds support for propagating constants across symbol-based callgraph edges. It uses the existing Call/CallableOpInterfaces to detect the dataflow edges, and propagates constants through arguments and out of returns.
Depends On D78522
Differential D78592
[mlir][SCCP] Add support for propagating across symbol based calls rriddle on Apr 21 2020, 3:21 PM. Authored by
Details This revision adds support for propagating constants across symbol-based callgraph edges. It uses the existing Call/CallableOpInterfaces to detect the dataflow edges, and propagates constants through arguments and out of returns. Depends On D78522
Diff Detail
Event TimelineComment Actions Looks great!
When can the arguments not be tracked? And shouldn't the CallableOpInterface guarantee that?
Comment Actions I thought I had a reason originally, but after thinking about it the constraints of symbol visibility already guarantee this today. Comment Actions
Could you say a line or two on what 'initial' is or what other things you want to add in the near term?
Comment Actions It'd be good to incorporate this understanding somewhere as a comment. Sorry about the delay - I should be able to get back on this by later today. Comment Actions Looks great overall. A bunch of mostly minor comments on tweaking doc/comments. Feel free to ignore the minor ones if not necessary. Many of them are also due to the order in which I looked at the changes and "local" reading.
Comment Actions Resolve comments
|