Page MenuHomePhabricator

[DebugInfo] Fix reading DWARFv5 type units in DWP.
ClosedPublic

Authored by ikudrin on Apr 6 2020, 7:37 AM.

Details

Summary

In DWARFv5, type units are stored in .debug_info sections, along with compilation units, and they are distinguished by the unit_type field in the header, not by the name of the section. It is impossible to associate the correct index section of a DWP file with the unit before the unit's header is read. This patch fixes reading DWARFv5 type units by parsing the header first and then applying the index entry according to the actual unit type.

Diff Detail

Event Timeline

ikudrin created this revision.Apr 6 2020, 7:37 AM
dblaikie accepted this revision.Apr 6 2020, 3:06 PM

Looks good - thanks!

This revision is now accepted and ready to land.Apr 6 2020, 3:06 PM
This revision was automatically updated to reflect the committed changes.