Page MenuHomePhabricator

tamur (Ali Tamur)
User

Projects

User Details

User Since
Aug 8 2018, 2:38 PM (95 w, 1 d)

Recent Activity

Mar 23 2020

tamur added a comment to D75485: Support DW_FORM_strx* in llvm-dwp..

Friendly ping?

Mar 23 2020, 12:33 PM · Restricted Project

Mar 10 2020

tamur added inline comments to D75485: Support DW_FORM_strx* in llvm-dwp..
Mar 10 2020, 7:42 PM · Restricted Project
tamur updated the diff for D75485: Support DW_FORM_strx* in llvm-dwp..
Mar 10 2020, 7:42 PM · Restricted Project

Mar 6 2020

tamur added a comment to D75485: Support DW_FORM_strx* in llvm-dwp..

BTW, have you tested the resultant dwp for debuggability with GDB ?? I also tried to apply locally D74312(info + str_offsets support), As I recall loading of dwp was fine. But their were some complaints reported when you try running/set break etc. If possible can you confirm this ?

Mar 6 2020, 12:08 PM · Restricted Project

Mar 5 2020

tamur added a comment to D75485: Support DW_FORM_strx* in llvm-dwp..

Ah, looks like this overlaps a bit with https://reviews.llvm.org/D74312 - might be worth checking there if there's any necessary issues (rather than orthogonal pieces) that patch addresses that this one doesn't, etc.

Mar 5 2020, 5:32 PM · Restricted Project
tamur updated the diff for D75485: Support DW_FORM_strx* in llvm-dwp..

Done reviewer suggestions and fixed clang -format complaints.

Mar 5 2020, 5:31 PM · Restricted Project
tamur added a reviewer for D75485: Support DW_FORM_strx* in llvm-dwp.: SouraVX.
Mar 5 2020, 5:31 PM · Restricted Project

Mar 4 2020

tamur added inline comments to D75485: Support DW_FORM_strx* in llvm-dwp..
Mar 4 2020, 5:59 PM · Restricted Project
tamur updated the diff for D75485: Support DW_FORM_strx* in llvm-dwp..
  • Introduce a CompileUnitHeader structure, it is needed to know the dwarf version, because, for example, debug_str_offsets sectoins have a header only when dwarf version is 5.
  • Introduce a function to parse CompileUnitHeader.
  • Introduce a function to compute the size of debug_str_offsets section headers.
  • Fix writeStringsAndOffsets to copy debug_str_offsets section headers correctly.
  • Get getIndexedString funciton to handle DW_FORM_strx forms correctly.
Mar 4 2020, 5:59 PM · Restricted Project
tamur updated the diff for D75485: Support DW_FORM_strx* in llvm-dwp..

I deleted "#include " line in handle_strx.test and ran clang-format on llvm-dwp.cc

Mar 4 2020, 9:34 AM · Restricted Project

Mar 3 2020

tamur updated the diff for D75485: Support DW_FORM_strx* in llvm-dwp..

Simplified the test. llvm-dwp and llvm-dwarfdump works fine for this simple test, but in any case I don't want to overspecify the output.

Mar 3 2020, 6:30 PM · Restricted Project
tamur added inline comments to D75485: Support DW_FORM_strx* in llvm-dwp..
Mar 3 2020, 6:30 PM · Restricted Project

Mar 2 2020

tamur created D75485: Support DW_FORM_strx* in llvm-dwp..
Mar 2 2020, 3:39 PM · Restricted Project

Feb 28 2020

tamur added a member for debug-info: tamur.
Feb 28 2020, 5:20 PM

Feb 21 2020

tamur accepted D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does.
Feb 21 2020, 5:33 PM · Restricted Project
tamur added a reviewer for D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does: MaskRay.
Feb 21 2020, 5:33 PM · Restricted Project

Jan 27 2020

tamur created D73514: [libcxx] Add a std::string_view pretty printer for libcxx..
Jan 27 2020, 5:24 PM · Restricted Project

Oct 9 2019

tamur added a comment to D63978: Clang Interface Stubs merger plumbing for Driver.

It seems that with this patch, llvm-ifs starts to depend on yaml2obj, which as far as I know, was only used for testing purposes until now. Is this intended?

Oct 9 2019, 11:17 AM · Restricted Project, Restricted Project

Oct 1 2019

tamur accepted D68306: Determine endianness at a time when it doesn't inadvertantly clear gdb's wrap_buffer via gdb.execute..
Oct 1 2019, 3:36 PM · Restricted Project

Jul 15 2019

tamur committed rGe7e8789a632f: Revert "[OPENMP]Add support for analysis of if clauses." (authored by tamur).
Revert "[OPENMP]Add support for analysis of if clauses."
Jul 15 2019, 8:21 PM
tamur committed rL366169: Revert "[OPENMP]Add support for analysis of if clauses.".
Revert "[OPENMP]Add support for analysis of if clauses."
Jul 15 2019, 8:21 PM
tamur added a reverting change for rL366068: [OPENMP]Add support for analysis of if clauses.: rL366169: Revert "[OPENMP]Add support for analysis of if clauses.".
Jul 15 2019, 8:21 PM
tamur added a comment to rL366068: [OPENMP]Add support for analysis of if clauses..

Hi, This patch have broken 86 tests under clang/test/OpenMP/ when run with address sanitizer.

Jul 15 2019, 8:11 PM

Jun 27 2019

tamur committed rG9a89d657b1a5: Fixing a couple of wrong logical operator bugs. (authored by tamur).
Fixing a couple of wrong logical operator bugs.
Jun 27 2019, 5:13 PM
tamur committed rL364614: Fixing a couple of wrong logical operator bugs..
Fixing a couple of wrong logical operator bugs.
Jun 27 2019, 5:11 PM

Jun 12 2019

tamur accepted D63228: [llvm] Expose DWARFDebugLine::LineTable::getFileNameEntry.
Jun 12 2019, 2:56 PM · debug-info, Restricted Project

Apr 18 2019

tamur committed rG783d84bb395c: [llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt (authored by tamur).
[llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt
Apr 18 2019, 7:26 PM
tamur committed rL358732: [llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt.
[llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt
Apr 18 2019, 7:26 PM
tamur committed rLLD358732: [llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt.
[llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt
Apr 18 2019, 7:26 PM
tamur committed rGb6a8a6caa814: Fix typo in function name [NFC] (authored by tamur).
Fix typo in function name [NFC]
Apr 18 2019, 7:16 PM
tamur committed rL358731: Fix typo in function name [NFC].
Fix typo in function name [NFC]
Apr 18 2019, 7:16 PM
tamur committed rC358731: Fix typo in function name [NFC].
Fix typo in function name [NFC]
Apr 18 2019, 7:16 PM
tamur committed rG5377748d5463: Add header guard to Reusables.h [NFC] (authored by tamur).
Add header guard to Reusables.h [NFC]
Apr 18 2019, 5:42 PM
tamur committed rL358724: Add header guard to Reusables.h [NFC].
Add header guard to Reusables.h [NFC]
Apr 18 2019, 5:42 PM
tamur committed rC358724: Add header guard to Reusables.h [NFC].
Add header guard to Reusables.h [NFC]
Apr 18 2019, 5:42 PM

Apr 17 2019

tamur committed rG6263365b082d: Fix a typo in comments. [NFC] (authored by tamur).
Fix a typo in comments. [NFC]
Apr 17 2019, 7:41 PM
tamur committed rL358639: Fix a typo in comments. [NFC].
Fix a typo in comments. [NFC]
Apr 17 2019, 7:37 PM

Apr 16 2019

tamur committed rGe8de5cd6023f: Fix a typo in comments. [NFC] (authored by tamur).
Fix a typo in comments. [NFC]
Apr 16 2019, 2:39 PM
tamur committed rL358531: Fix a typo in comments. [NFC].
Fix a typo in comments. [NFC]
Apr 16 2019, 2:39 PM

Apr 11 2019

tamur added inline comments to D60487: [llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt.
Apr 11 2019, 1:18 PM · Restricted Project
tamur committed rG7822b4618853: Revert "Use llvm::lower_bound. NFC" (authored by tamur).
Revert "Use llvm::lower_bound. NFC"
Apr 11 2019, 10:35 AM
tamur added a reverting change for rL358161: Use llvm::lower_bound. NFC: rL358199: Revert "Use llvm::lower_bound. NFC".
Apr 11 2019, 10:33 AM
tamur committed rL358199: Revert "Use llvm::lower_bound. NFC".
Revert "Use llvm::lower_bound. NFC"
Apr 11 2019, 10:33 AM
tamur added a comment to rL358161: Use llvm::lower_bound. NFC.

This seems to have broken the test: llvm/test/tools/llvm-exegesis/X86/uops-CMOV16rm-noreg.s

Apr 11 2019, 10:06 AM

Apr 10 2019

tamur committed rG59a0e047015b: [llvm] Non-functional change: declared a local variable as const. (authored by tamur).
[llvm] Non-functional change: declared a local variable as const.
Apr 10 2019, 11:29 AM
tamur committed rL358120: [llvm] Non-functional change: declared a local variable as const..
[llvm] Non-functional change: declared a local variable as const.
Apr 10 2019, 11:28 AM
tamur updated the diff for D60487: [llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt.
Apr 10 2019, 10:20 AM · Restricted Project

Apr 9 2019

tamur created D60487: [llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt.
Apr 9 2019, 2:36 PM · Restricted Project

Mar 26 2019

tamur committed rG02e96648d75b: Revert "[llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5. (authored by tamur).
Revert "[llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5.
Mar 26 2019, 1:07 PM
tamur committed rL357026: Revert "[llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5..
Revert "[llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5.
Mar 26 2019, 1:07 PM
tamur added a reverting change for rL357020: [lld] Reapply "Prevent duplicate files in debug line header in dwarf 5.": rL357026: Revert "[llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5..
Mar 26 2019, 1:07 PM
tamur committed rGcea954802817: Revert "[lld] Reapply "Prevent duplicate files in debug line header in dwarf 5. (authored by tamur).
Revert "[lld] Reapply "Prevent duplicate files in debug line header in dwarf 5.
Mar 26 2019, 12:58 PM
tamur committed rLLD357025: Revert "[lld] Reapply "Prevent duplicate files in debug line header in dwarf 5..
Revert "[lld] Reapply "Prevent duplicate files in debug line header in dwarf 5.
Mar 26 2019, 12:58 PM
tamur added a reverting change for rL357020: [lld] Reapply "Prevent duplicate files in debug line header in dwarf 5.": rL357025: Revert "[lld] Reapply "Prevent duplicate files in debug line header in dwarf 5..
Mar 26 2019, 12:58 PM
tamur committed rL357025: Revert "[lld] Reapply "Prevent duplicate files in debug line header in dwarf 5..
Revert "[lld] Reapply "Prevent duplicate files in debug line header in dwarf 5.
Mar 26 2019, 12:58 PM
tamur committed rLLD357020: [lld] Reapply "Prevent duplicate files in debug line header in dwarf 5.".
[lld] Reapply "Prevent duplicate files in debug line header in dwarf 5."
Mar 26 2019, 12:01 PM
tamur committed rG5c2f176ccc22: [lld] Reapply "Prevent duplicate files in debug line header in dwarf 5." (authored by tamur).
[lld] Reapply "Prevent duplicate files in debug line header in dwarf 5."
Mar 26 2019, 12:00 PM
tamur committed rL357020: [lld] Reapply "Prevent duplicate files in debug line header in dwarf 5.".
[lld] Reapply "Prevent duplicate files in debug line header in dwarf 5."
Mar 26 2019, 12:00 PM
tamur committed rG2f5cd03a3f1c: [llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5." (authored by tamur).
[llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5."
Mar 26 2019, 11:54 AM
tamur committed rL357018: [llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5.".
[llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5."
Mar 26 2019, 11:54 AM

Mar 25 2019

tamur added a comment to D59664: [llvm] Non-functional change: declared a couple of local variables as const..

Reverted changes to llvm/MC/MCContext.h

Mar 25 2019, 9:51 PM · Restricted Project
tamur updated the diff for D59664: [llvm] Non-functional change: declared a couple of local variables as const..
Mar 25 2019, 9:48 PM · Restricted Project
tamur committed rGfdce82a814c0: Revert "[llvm] Prevent duplicate files in debug line header in dwarf 5." (authored by tamur).
Revert "[llvm] Prevent duplicate files in debug line header in dwarf 5."
Mar 25 2019, 2:08 PM
tamur added a reverting change for rG312ab05887d0: [llvm] Prevent duplicate files in debug line header in dwarf 5.: rGfdce82a814c0: Revert "[llvm] Prevent duplicate files in debug line header in dwarf 5.".
Mar 25 2019, 2:08 PM
tamur committed rL356951: Revert "[llvm] Prevent duplicate files in debug line header in dwarf 5.".
Revert "[llvm] Prevent duplicate files in debug line header in dwarf 5."
Mar 25 2019, 2:07 PM
tamur committed rG800fe977d068: Revert "[lld] Prevent duplicate files in debug line header in dwarf 5." (authored by tamur).
Revert "[lld] Prevent duplicate files in debug line header in dwarf 5."
Mar 25 2019, 2:06 PM
tamur added a reverting change for rG5aa7478a55fa: [lld] Prevent duplicate files in debug line header in dwarf 5.: rG800fe977d068: Revert "[lld] Prevent duplicate files in debug line header in dwarf 5.".
Mar 25 2019, 2:06 PM
tamur committed rLLD356949: Revert "[lld] Prevent duplicate files in debug line header in dwarf 5.".
Revert "[lld] Prevent duplicate files in debug line header in dwarf 5."
Mar 25 2019, 2:06 PM
tamur committed rL356949: Revert "[lld] Prevent duplicate files in debug line header in dwarf 5.".
Revert "[lld] Prevent duplicate files in debug line header in dwarf 5."
Mar 25 2019, 2:05 PM
tamur committed rG5aa7478a55fa: [lld] Prevent duplicate files in debug line header in dwarf 5. (authored by tamur).
[lld] Prevent duplicate files in debug line header in dwarf 5.
Mar 25 2019, 1:20 PM
tamur committed rLLD356943: [lld] Prevent duplicate files in debug line header in dwarf 5..
[lld] Prevent duplicate files in debug line header in dwarf 5.
Mar 25 2019, 1:17 PM
tamur committed rL356943: [lld] Prevent duplicate files in debug line header in dwarf 5..
[lld] Prevent duplicate files in debug line header in dwarf 5.
Mar 25 2019, 1:17 PM
tamur closed D59671: [lld] Prevent duplicate files in debug line header in dwarf 5..
Mar 25 2019, 1:17 PM · Restricted Project
tamur committed rG312ab05887d0: [llvm] Prevent duplicate files in debug line header in dwarf 5. (authored by tamur).
[llvm] Prevent duplicate files in debug line header in dwarf 5.
Mar 25 2019, 1:07 PM
tamur committed rL356941: [llvm] Prevent duplicate files in debug line header in dwarf 5..
[llvm] Prevent duplicate files in debug line header in dwarf 5.
Mar 25 2019, 1:07 PM
tamur closed D59515: [llvm] Prevent duplicate files in debug line header in dwarf 5..
Mar 25 2019, 1:07 PM · debug-info, Restricted Project

Mar 22 2019

tamur added inline comments to D59515: [llvm] Prevent duplicate files in debug line header in dwarf 5..
Mar 22 2019, 2:11 PM · debug-info, Restricted Project
tamur updated the diff for D59515: [llvm] Prevent duplicate files in debug line header in dwarf 5..
Mar 22 2019, 2:09 PM · debug-info, Restricted Project

Mar 21 2019

tamur created D59671: [lld] Prevent duplicate files in debug line header in dwarf 5..
Mar 21 2019, 3:04 PM · Restricted Project
tamur added a comment to D59515: [llvm] Prevent duplicate files in debug line header in dwarf 5..

I moved nfc changes to a separate patch.

Mar 21 2019, 2:28 PM · debug-info, Restricted Project
tamur updated the diff for D59515: [llvm] Prevent duplicate files in debug line header in dwarf 5..
Mar 21 2019, 2:26 PM · debug-info, Restricted Project
tamur created D59664: [llvm] Non-functional change: declared a couple of local variables as const..
Mar 21 2019, 1:32 PM · Restricted Project

Mar 18 2019

tamur created D59515: [llvm] Prevent duplicate files in debug line header in dwarf 5..
Mar 18 2019, 3:22 PM · debug-info, Restricted Project

Mar 7 2019

tamur committed rGd0156256e2c2: [lldb] Fix DW_OP_addrx uses. (authored by tamur).
[lldb] Fix DW_OP_addrx uses.
Mar 7 2019, 11:41 AM
tamur committed rLLDB355629: [lldb] Fix DW_OP_addrx uses..
[lldb] Fix DW_OP_addrx uses.
Mar 7 2019, 11:40 AM
tamur committed rL355629: [lldb] Fix DW_OP_addrx uses..
[lldb] Fix DW_OP_addrx uses.
Mar 7 2019, 11:40 AM
tamur closed D59004: [lldb] Fix DW_OP_addrx uses..
Mar 7 2019, 11:40 AM · Restricted Project, Restricted Project

Mar 6 2019

tamur updated the diff for D59004: [lldb] Fix DW_OP_addrx uses..

Discarded changes to the unit test and added a lit test.

Mar 6 2019, 9:13 PM · Restricted Project, Restricted Project

Mar 5 2019

tamur updated the diff for D59004: [lldb] Fix DW_OP_addrx uses..

Added a test.

Mar 5 2019, 4:27 PM · Restricted Project, Restricted Project
tamur added inline comments to D59004: [lldb] Fix DW_OP_addrx uses..
Mar 5 2019, 3:57 PM · Restricted Project, Restricted Project
tamur updated the diff for D59004: [lldb] Fix DW_OP_addrx uses..
Mar 5 2019, 3:57 PM · Restricted Project, Restricted Project
tamur created D59004: [lldb] Fix DW_OP_addrx uses..
Mar 5 2019, 3:38 PM · Restricted Project, Restricted Project

Feb 2 2019

tamur added a reverting change for D44571: [CGP] Avoid segmentation fault when doing PHI node simplifications: rGd482b01a62ab: Use a data structure better suited for large sets in SimplificationTracker..
Feb 2 2019, 9:22 AM

Jan 16 2019

tamur abandoned D56808: [llvm-readobj] Fix hexdump test.

I found a workaround, cancelling the patch.

Jan 16 2019, 4:39 PM
tamur updated the diff for D56808: [llvm-readobj] Fix hexdump test.
Jan 16 2019, 2:37 PM
tamur retitled D56808: [llvm-readobj] Fix hexdump test from Fix hexdump test to [llvm-readobj] Fix hexdump test.
Jan 16 2019, 2:15 PM
tamur created D56808: [llvm-readobj] Fix hexdump test.
Jan 16 2019, 1:53 PM

Jan 15 2019

tamur added a comment to D54428: [clangd] XPC transport layer, framework, test-client.

This patch seems to have broken the compilation. I get the following error on a linux platform:
[12/14] Linking CXX executable bin/clangd
FAILED: bin/clangd
: && /usr/local/google/home/tamur/src/llvm/2018_nov_12/llvm/Stable/bin/clang++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -fuse-ld=lld -Wl,--color-diagnostics -Wl,-allow-shlib-undefined -Wl,-O3 -Wl,--gc-sections tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o -o bin/clangd -Wl,-rpath,"\$ORIGIN/../lib" lib/libLLVMSupport.so.8svn -lpthread lib/libclangBasic.so.8svn lib/libclangDaemon.so.8svn lib/libclangFormat.so.8svn lib/libclangFrontend.so.8svn lib/libclangSema.so.8svn lib/libclangTooling.so.8svn lib/libclangToolingCore.so.8svn && :
ld.lld: error: undefined symbol: clang::clangd::newXPCTransport()

Jan 15 2019, 10:33 PM

Jan 14 2019

tamur created D56693: Remove unused variable somehow left in rL351132.
Jan 14 2019, 5:48 PM
tamur abandoned D56689: Remove unused variable somehow left in rL351132.
Jan 14 2019, 5:07 PM