Friendly ping?

BTW, have you tested the resultant dwp for debuggability with GDB ?? I also tried to apply locally D74312(info + str_offsets support), As I recall loading of dwp was fine. But their were some complaints reported when you try running/set break etc. If possible can you confirm this ?

In D75485#1908787, @dblaikie wrote:

Ah, looks like this overlaps a bit with https://reviews.llvm.org/D74312 - might be worth checking there if there's any necessary issues (rather than orthogonal pieces) that patch addresses that this one doesn't, etc.

Done reviewer suggestions and fixed clang -format complaints.

• Introduce a CompileUnitHeader structure, it is needed to know the dwarf version, because, for example, debug_str_offsets sectoins have a header only when dwarf version is 5.
• Introduce a function to parse CompileUnitHeader.
• Introduce a function to compute the size of debug_str_offsets section headers.
• Fix writeStringsAndOffsets to copy debug_str_offsets section headers correctly.
• Get getIndexedString funciton to handle DW_FORM_strx forms correctly.

I deleted "#include " line in handle_strx.test and ran clang-format on llvm-dwp.cpp

Simplified the test. llvm-dwp and llvm-dwarfdump works fine for this simple test, but in any case I don't want to overspecify the output.

It seems that with this patch, llvm-ifs starts to depend on yaml2obj, which as far as I know, was only used for testing purposes until now. Is this intended?

Hi, This patch have broken 86 tests under clang/test/OpenMP/ when run with address sanitizer.

This seems to have broken the test: llvm/test/tools/llvm-exegesis/X86/uops-CMOV16rm-noreg.s

Reverted changes to llvm/MC/MCContext.h

I moved nfc changes to a separate patch.

Discarded changes to the unit test and added a lit test.

Added a test. (test with dwarf5 generation would fail without other changes).

I found a workaround, cancelling the patch.