Page MenuHomePhabricator

[Alignment][NFC] Transitionning more getMachineMemOperand call sites
ClosedPublic

Authored by gchatelet on Mar 31 2020, 1:05 AM.

Details

Summary

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Diff Detail

Event Timeline

gchatelet created this revision.Mar 31 2020, 1:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2020, 1:05 AM
courbet accepted this revision.Mar 31 2020, 1:15 AM
courbet added inline comments.
llvm/lib/Target/PowerPC/PPCISelLowering.h
994

This is a potential functional change, so I'll mention what I checked for posterity:
There are three instantiations of this class. In all cases, Alignment is never read before being written to.

This revision is now accepted and ready to land.Mar 31 2020, 1:15 AM
gchatelet marked 2 inline comments as done.Mar 31 2020, 1:35 AM
gchatelet added inline comments.
llvm/lib/Target/PowerPC/PPCISelLowering.h
994

Yes I checked as well manually (by reading the code) and by running all tests and asserting when Alignment was read and equal to zero.

This revision was automatically updated to reflect the committed changes.
gchatelet marked an inline comment as done.