Page MenuHomePhabricator

[VPlan] Use on VPWidenRecipe per original IR instruction. (NFC).
ClosedPublic

Authored by fhahn on Mar 28 2020, 7:19 AM.

Details

Summary

This patch changes VPWidenRecipe to only store a single original IR
instruction. This is the first required step towards modeling it's
operands as VPValues and also towards breaking it up into a
VPInstruction.

Discussed as part of D74695.

Diff Detail

Unit TestsFailed

TimeTest
75,730 mslldb-api.tools/lldb-server::Unknown Unit Message ("")
Script: -- /usr/bin/python /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/lldb/test/API/dotest.py --arch x86_64 -s /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/lldb-test-traces -S nm -u CXXFLAGS -u CFLAGS --env ARCHIVER=/usr/bin/ar --env OBJCOPY=/usr/bin/objcopy --env LLVM_LIBS_DIR=/mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/./lib --build-dir /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/lldb-test-build.noindex --lldb-module-cache-dir /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/./bin/lldb --compiler /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/./bin/clang --dsymutil /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/./bin/dsymutil --filecheck /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/./bin/FileCheck --lldb-libs-dir /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/./lib /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/lldb/test/API/tools/lldb-server -p TestLldbGdbServer.py
130 mslldb-unit.Host/_/HostTests::Unknown Unit Message ("")
Note: Google Test filter = ConnectionFileDescriptorTest.TCPGetURIv6 [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.

Event Timeline

fhahn created this revision.Mar 28 2020, 7:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2020, 7:19 AM
gilr added inline comments.Mar 28 2020, 10:28 AM
llvm/lib/Transforms/Vectorize/VPlan.cpp
717–718

No need for the line break anymore - can be a single row as other simple recipes.

fhahn updated this revision to Diff 253364.Mar 28 2020, 11:26 AM
fhahn marked an inline comment as done.

Update test checking VPBB iterator, remove newline from printing.

gilr accepted this revision.Mar 28 2020, 11:03 PM

LGTM, with a nit.

llvm/lib/Transforms/Vectorize/VPlan.h
760–763

Comment still relates to the old range of ingredients.

766

Comment still relates to the old range of ingredients.

This revision is now accepted and ready to land.Mar 28 2020, 11:03 PM
This revision was automatically updated to reflect the committed changes.