HomePhabricator

[llvm-rc] Allow -1 for menu item IDs

Authored by mstorsjo on Mar 27 2020, 12:58 PM.

Description

[llvm-rc] Allow -1 for menu item IDs

This seems to be used in some resource files, e.g.
https://github.com/wxWidgets/wxWidgets/blob/f3217573d7240411e7817c9d76d965b2452987a2/include/wx/msw/wx.rc#L28.

MSVC rc.exe and GNU windres both allow any value here, and silently
just truncate to uint16_t range. This just explicitly allows the
-1 value and errors out on others - the same was done for control
IDs in dialogs in c1a67857ba0a6ba558818b589fe7c0fcc8f238ae.

Differential Revision: https://reviews.llvm.org/D76951

Details

Committed
mstorsjoMar 28 2020, 5:32 AM
Differential Revision
D76951: [llvm-rc] Allow -1 for menu item IDs
Parents
rG8c1dbd5c1e2b: [X86][SSE] Add testnzc(~X,Y) -> testnzc(X,Y) test cases
Branches
Unknown
Tags
Unknown