Page MenuHomePhabricator

Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins
ClosedPublic

Authored by ajwock on Mar 27 2020, 1:01 PM.

Details

Summary

This patch adds a test for the PowerPC fma compiler builtins, some variations of which negate inputs and outputs. The code to generate IR for these builtins was untested before this patch.

Originally, the code used the outdated method of subtracting floating point values from -0.0 as floating point negation. This patch remedies that.

Diff Detail

Event Timeline

ajwock created this revision.Mar 27 2020, 1:01 PM
jsji added a reviewer: Restricted Project.Mar 27 2020, 1:14 PM
jsji added a project: Restricted Project.
cameron.mcinally accepted this revision.Mar 27 2020, 2:08 PM

LGTM, assuming Harbormaster whines are addressed.

This revision is now accepted and ready to land.Mar 27 2020, 2:08 PM
ajwock updated this revision to Diff 254609.Apr 2 2020, 1:24 PM

Rebased for harbormaster.

This revision was automatically updated to reflect the committed changes.