Page MenuHomePhabricator

[AST][SVE] Treat built-in SVE types as POD
ClosedPublic

Authored by rsandifo-arm on Mar 24 2020, 4:50 AM.

Details

Summary

Built-in SVE types are POD in much the same that scalars and
fixed-length vectors are.

Diff Detail

Event Timeline

rsandifo-arm created this revision.Mar 24 2020, 4:50 AM
Herald added a project: Restricted Project. · View Herald Transcript
efriedma added inline comments.Mar 24 2020, 12:25 PM
clang/lib/AST/Type.cpp
2500

Can you rearrange this so isSizelessBuiltinType() is at the bottom? It should be rare. (Assuming it doesn't need to be before the isIncompleteType() check.)

rsandifo-arm marked an inline comment as done.Mar 24 2020, 3:36 PM
rsandifo-arm added inline comments.
clang/lib/AST/Type.cpp
2500

I should have mentioned that, but yeah: the call is placed here so that it continues to work when/if IsCompleteType returns true for these types. (I have a patch for that, similar to D76221, but I don't know whether it will be acceptable.)

efriedma accepted this revision.Mar 25 2020, 11:44 AM

Okay, then LGTM

This revision is now accepted and ready to land.Mar 25 2020, 11:44 AM
This revision was automatically updated to reflect the committed changes.